From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B19EAC43381 for ; Thu, 28 Mar 2019 14:00:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 88DCA21773 for ; Thu, 28 Mar 2019 14:00:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726322AbfC1OA3 (ORCPT ); Thu, 28 Mar 2019 10:00:29 -0400 Received: from mx1.redhat.com ([209.132.183.28]:50976 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726082AbfC1OA3 (ORCPT ); Thu, 28 Mar 2019 10:00:29 -0400 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 63CD480E44; Thu, 28 Mar 2019 14:00:24 +0000 (UTC) Received: from localhost.localdomain (ovpn-12-53.pek2.redhat.com [10.72.12.53]) by smtp.corp.redhat.com (Postfix) with ESMTPS id CA8BA1001E6B; Thu, 28 Mar 2019 14:00:06 +0000 (UTC) Subject: Re: [PATCH 2/3 v9] resource: add the new I/O resource descriptor 'IORES_DESC_RESERVED' To: Borislav Petkov Cc: linux-kernel@vger.kernel.org, kexec@lists.infradead.org, tglx@linutronix.de, mingo@redhat.com, akpm@linux-foundation.org, dave.hansen@linux.intel.com, luto@kernel.org, peterz@infradead.org, x86@kernel.org, hpa@zytor.com, dyoung@redhat.com, bhe@redhat.com, Thomas.Lendacky@amd.com References: <20190321103309.27883-1-lijiang@redhat.com> <20190321103309.27883-3-lijiang@redhat.com> <20190322192800.GM12472@zn.tnic> <47bfcbe2-1631-9733-74c2-fb3e56540052@redhat.com> <20190325122426.GK12016@zn.tnic> From: lijiang Message-ID: <86919dfe-ab72-efef-8304-b2608078d320@redhat.com> Date: Thu, 28 Mar 2019 22:00:01 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20190325122426.GK12016@zn.tnic> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.25]); Thu, 28 Mar 2019 14:00:28 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 在 2019年03月25日 20:24, Borislav Petkov 写道: > On Mon, Mar 25, 2019 at 02:53:02PM +0800, lijiang wrote: >> In this function, i printed its values, and only got the value of reserved >> type, so i changed the IORES_DESC_NONE to the IORES_DESC_RESERVED. >> >> In addition, after the new descriptor 'IORES_DESC_RESERVED' is introduced, >> the IORES_DESC_NONE does not include the IORES_DESC_RESERVED any more, it >> could miss to handle the value of the reserved type. > > Yes, IORES_DESC_RESERVED is supposed to denote the e820 reserved type. > Why should IORES_DESC_NONE include it ?!?! > > IORES_DESC_NONE is, well, an invalid, i.e., "none" type: Yes, i see. That indicates an empty area, or "void" type. > > /* > * I/O Resource Descriptors > * > * Descriptors are used by walk_iomem_res_desc() and region_intersects() > * for searching a specific resource range in the iomem table. Assign > * a new descriptor when a resource range supports the search interfaces. > * Otherwise, resource.desc must be set to IORES_DESC_NONE (0). > */ > >> Do you mean i should never touch the three chunks? If i made a mistake, i >> will remove this changes next post. > > I'm looking at the hunks below and you're changing ->desc assignments in > some random function which doesn't look like you know what you're doing. > Maybe it gets you what you want but it sure as hell doesn't look right > to me. > I have realized that there could be a problem with this changes. Indeed, here it denotes an empty area instead of a reserved area. BTW: Looks like the name of this function(__reserve_region_with_split) is a bit misleading. Thank you for pointing out this problem, i will correct them next post. Lianbo From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mx1.redhat.com ([209.132.183.28]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1h9Va8-0004eZ-Ip for kexec@lists.infradead.org; Thu, 28 Mar 2019 14:00:39 +0000 Subject: Re: [PATCH 2/3 v9] resource: add the new I/O resource descriptor 'IORES_DESC_RESERVED' References: <20190321103309.27883-1-lijiang@redhat.com> <20190321103309.27883-3-lijiang@redhat.com> <20190322192800.GM12472@zn.tnic> <47bfcbe2-1631-9733-74c2-fb3e56540052@redhat.com> <20190325122426.GK12016@zn.tnic> From: lijiang Message-ID: <86919dfe-ab72-efef-8304-b2608078d320@redhat.com> Date: Thu, 28 Mar 2019 22:00:01 +0800 MIME-Version: 1.0 In-Reply-To: <20190325122426.GK12016@zn.tnic> Content-Language: en-US List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "kexec" Errors-To: kexec-bounces+dwmw2=infradead.org@lists.infradead.org To: Borislav Petkov Cc: Thomas.Lendacky@amd.com, x86@kernel.org, bhe@redhat.com, peterz@infradead.org, dave.hansen@linux.intel.com, kexec@lists.infradead.org, linux-kernel@vger.kernel.org, mingo@redhat.com, luto@kernel.org, hpa@zytor.com, tglx@linutronix.de, dyoung@redhat.com, akpm@linux-foundation.org 5ZyoIDIwMTnlubQwM+aciDI15pelIDIwOjI0LCBCb3Jpc2xhdiBQZXRrb3Yg5YaZ6YGTOgo+IE9u IE1vbiwgTWFyIDI1LCAyMDE5IGF0IDAyOjUzOjAyUE0gKzA4MDAsIGxpamlhbmcgd3JvdGU6Cj4+ IEluIHRoaXMgZnVuY3Rpb24sIGkgcHJpbnRlZCBpdHMgdmFsdWVzLCBhbmQgb25seSBnb3QgdGhl IHZhbHVlIG9mIHJlc2VydmVkCj4+IHR5cGUsIHNvIGkgY2hhbmdlZCB0aGUgSU9SRVNfREVTQ19O T05FIHRvIHRoZSBJT1JFU19ERVNDX1JFU0VSVkVELgo+Pgo+PiBJbiBhZGRpdGlvbiwgYWZ0ZXIg dGhlIG5ldyBkZXNjcmlwdG9yICdJT1JFU19ERVNDX1JFU0VSVkVEJyBpcyBpbnRyb2R1Y2VkLAo+ PiB0aGUgSU9SRVNfREVTQ19OT05FIGRvZXMgbm90IGluY2x1ZGUgdGhlIElPUkVTX0RFU0NfUkVT RVJWRUQgYW55IG1vcmUsIGl0Cj4+IGNvdWxkIG1pc3MgdG8gaGFuZGxlIHRoZSB2YWx1ZSBvZiB0 aGUgcmVzZXJ2ZWQgdHlwZS4KPiAKPiBZZXMsIElPUkVTX0RFU0NfUkVTRVJWRUQgaXMgc3VwcG9z ZWQgdG8gZGVub3RlIHRoZSBlODIwIHJlc2VydmVkIHR5cGUuCj4gV2h5IHNob3VsZCBJT1JFU19E RVNDX05PTkUgaW5jbHVkZSBpdCA/IT8hCj4gCj4gSU9SRVNfREVTQ19OT05FIGlzLCB3ZWxsLCBh biBpbnZhbGlkLCBpLmUuLCAibm9uZSIgdHlwZToKClllcywgaSBzZWUuIFRoYXQgaW5kaWNhdGVz IGFuIGVtcHR5IGFyZWEsIG9yICJ2b2lkIiB0eXBlLgoKPiAKPiAvKgo+ICAqIEkvTyBSZXNvdXJj ZSBEZXNjcmlwdG9ycwo+ICAqCj4gICogRGVzY3JpcHRvcnMgYXJlIHVzZWQgYnkgd2Fsa19pb21l bV9yZXNfZGVzYygpIGFuZCByZWdpb25faW50ZXJzZWN0cygpCj4gICogZm9yIHNlYXJjaGluZyBh IHNwZWNpZmljIHJlc291cmNlIHJhbmdlIGluIHRoZSBpb21lbSB0YWJsZS4gIEFzc2lnbgo+ICAq IGEgbmV3IGRlc2NyaXB0b3Igd2hlbiBhIHJlc291cmNlIHJhbmdlIHN1cHBvcnRzIHRoZSBzZWFy Y2ggaW50ZXJmYWNlcy4KPiAgKiBPdGhlcndpc2UsIHJlc291cmNlLmRlc2MgbXVzdCBiZSBzZXQg dG8gSU9SRVNfREVTQ19OT05FICgwKS4KPiAgKi8KPiAKPj4gRG8geW91IG1lYW4gaSBzaG91bGQg bmV2ZXIgdG91Y2ggdGhlIHRocmVlIGNodW5rcz8gSWYgaSBtYWRlIGEgbWlzdGFrZSwgaQo+PiB3 aWxsIHJlbW92ZSB0aGlzIGNoYW5nZXMgbmV4dCBwb3N0Lgo+IAo+IEknbSBsb29raW5nIGF0IHRo ZSBodW5rcyBiZWxvdyBhbmQgeW91J3JlIGNoYW5naW5nIC0+ZGVzYyBhc3NpZ25tZW50cyBpbgo+ IHNvbWUgcmFuZG9tIGZ1bmN0aW9uIHdoaWNoIGRvZXNuJ3QgbG9vayBsaWtlIHlvdSBrbm93IHdo YXQgeW91J3JlIGRvaW5nLgo+IE1heWJlIGl0IGdldHMgeW91IHdoYXQgeW91IHdhbnQgYnV0IGl0 IHN1cmUgYXMgaGVsbCBkb2Vzbid0IGxvb2sgcmlnaHQKPiB0byBtZS4KPiAKSSBoYXZlIHJlYWxp emVkIHRoYXQgdGhlcmUgY291bGQgYmUgYSBwcm9ibGVtIHdpdGggdGhpcyBjaGFuZ2VzLiBJbmRl ZWQsIGhlcmUKaXQgZGVub3RlcyBhbiBlbXB0eSBhcmVhIGluc3RlYWQgb2YgYSByZXNlcnZlZCBh cmVhLgoKQlRXOiBMb29rcyBsaWtlIHRoZSBuYW1lIG9mIHRoaXMgZnVuY3Rpb24oX19yZXNlcnZl X3JlZ2lvbl93aXRoX3NwbGl0KSBpcyBhIGJpdAptaXNsZWFkaW5nLgoKVGhhbmsgeW91IGZvciBw b2ludGluZyBvdXQgdGhpcyBwcm9ibGVtLCBpIHdpbGwgY29ycmVjdCB0aGVtIG5leHQgcG9zdC4K CkxpYW5ibwoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18K a2V4ZWMgbWFpbGluZyBsaXN0CmtleGVjQGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3Rz LmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9rZXhlYwo=