From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id ECBC3C433F5 for ; Tue, 12 Apr 2022 14:25:05 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 1A95510E28D; Tue, 12 Apr 2022 14:25:05 +0000 (UTC) Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by gabe.freedesktop.org (Postfix) with ESMTPS id 2C0FA10E28D for ; Tue, 12 Apr 2022 14:25:04 +0000 (UTC) Received: from [192.168.1.111] (91-156-85-209.elisa-laajakaista.fi [91.156.85.209]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 53F24486; Tue, 12 Apr 2022 16:25:01 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1649773502; bh=TD/bZV0n+8gOuaITuXISCNvKDTaVocldAK+mP8GfBLA=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=qWqtmbG+qDmmBC5ucGcMjlZotm5YfmGMe11bdqgwIAxkUhErnX5V1SOMFJ22CqFaN oybAlLuQC0/8TaltkrMd7+POolRP0MdihrnqljtTSoChK5/8v4nh6n4qKVu5R17Stq AwZSOW0KWK4kgTn0lwILUtQF6vdaIuB45sV8TBPI= Message-ID: <86a07099-1074-e8d1-6d0e-1ce68414b627@ideasonboard.com> Date: Tue, 12 Apr 2022 17:24:58 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: Re: [PATCH] drm/tidss: Soft Reset DISPC on startup Content-Language: en-US To: Devarsh Thakkar , linux-kernel@vger.kernel.org, jyri.sarha@iki.fi, tomba@kernel.org, airlied@linux.ie, daniel@ffwll.ch, dri-devel@lists.freedesktop.org References: <20220314113739.18000-1-devarsht@ti.com> From: Tomi Valkeinen In-Reply-To: <20220314113739.18000-1-devarsht@ti.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: nm@ti.com, vigneshr@ti.com, a-bhatia1@ti.com, laurent.pinchart@ideasonboard.com, nikhil.nd@ti.com, linux-arm-kernel@lists.infradead.org, r-ravikumar@ti.com Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Hi, On 14/03/2022 13:37, Devarsh Thakkar wrote: > Soft reset the display subsystem controller on startup and wait for > the reset to complete. This helps the scenario where display was > already in use by some other core before the linux was booted. The reason the omapdrm doesn't do a reset is that the PM features on some of the DSS registers were set and controlled outside dss driver, so the dss driver could not do a reset just like that. That design was carried to the tidss driver, although I'm not sure if the reason is valid on AM6 and J7 platforms. If that reasoning is not valid, this patch is ok and: Reviewed-by: Tomi Valkeinen Tomi > Signed-off-by: Devarsh Thakkar > --- > drivers/gpu/drm/tidss/tidss_dispc.c | 18 ++++++++++++++++++ > 1 file changed, 18 insertions(+) > > diff --git a/drivers/gpu/drm/tidss/tidss_dispc.c b/drivers/gpu/drm/tidss/tidss_dispc.c > index 60b92df615aa..dae47853b728 100644 > --- a/drivers/gpu/drm/tidss/tidss_dispc.c > +++ b/drivers/gpu/drm/tidss/tidss_dispc.c > @@ -2650,6 +2650,20 @@ static void dispc_init_errata(struct dispc_device *dispc) > } > } > > +static void dispc_softreset(struct dispc_device *dispc) > +{ > + u32 val; > + int ret = 0; > + > + /* Soft reset */ > + REG_FLD_MOD(dispc, DSS_SYSCONFIG, 1, 1, 1); > + /* Wait for reset to complete */ > + ret = readl_poll_timeout(dispc->base_common + DSS_SYSSTATUS, > + val, val & 1, 100, 5000); > + if (ret) > + dev_warn(dispc->dev, "failed to reset dispc\n"); > +} > + > int dispc_init(struct tidss_device *tidss) > { > struct device *dev = tidss->dev; > @@ -2709,6 +2723,10 @@ int dispc_init(struct tidss_device *tidss) > return r; > } > > + /* K2G display controller does not support soft reset */ > + if (feat->subrev != DISPC_K2G) > + dispc_softreset(dispc); > + > for (i = 0; i < dispc->feat->num_vps; i++) { > u32 gamma_size = dispc->feat->vp_feat.color.gamma_size; > u32 *gamma_table; From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 766B0C433F5 for ; Tue, 12 Apr 2022 14:25:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1356525AbiDLO1a (ORCPT ); Tue, 12 Apr 2022 10:27:30 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56206 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1356506AbiDLO1X (ORCPT ); Tue, 12 Apr 2022 10:27:23 -0400 Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8B2FE19034 for ; Tue, 12 Apr 2022 07:25:05 -0700 (PDT) Received: from [192.168.1.111] (91-156-85-209.elisa-laajakaista.fi [91.156.85.209]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 53F24486; Tue, 12 Apr 2022 16:25:01 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1649773502; bh=TD/bZV0n+8gOuaITuXISCNvKDTaVocldAK+mP8GfBLA=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=qWqtmbG+qDmmBC5ucGcMjlZotm5YfmGMe11bdqgwIAxkUhErnX5V1SOMFJ22CqFaN oybAlLuQC0/8TaltkrMd7+POolRP0MdihrnqljtTSoChK5/8v4nh6n4qKVu5R17Stq AwZSOW0KWK4kgTn0lwILUtQF6vdaIuB45sV8TBPI= Message-ID: <86a07099-1074-e8d1-6d0e-1ce68414b627@ideasonboard.com> Date: Tue, 12 Apr 2022 17:24:58 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: Re: [PATCH] drm/tidss: Soft Reset DISPC on startup Content-Language: en-US To: Devarsh Thakkar , linux-kernel@vger.kernel.org, jyri.sarha@iki.fi, tomba@kernel.org, airlied@linux.ie, daniel@ffwll.ch, dri-devel@lists.freedesktop.org Cc: nm@ti.com, a-bhatia1@ti.com, r-ravikumar@ti.com, nikhil.nd@ti.com, linux-arm-kernel@lists.infradead.org, vigneshr@ti.com, laurent.pinchart@ideasonboard.com References: <20220314113739.18000-1-devarsht@ti.com> From: Tomi Valkeinen In-Reply-To: <20220314113739.18000-1-devarsht@ti.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On 14/03/2022 13:37, Devarsh Thakkar wrote: > Soft reset the display subsystem controller on startup and wait for > the reset to complete. This helps the scenario where display was > already in use by some other core before the linux was booted. The reason the omapdrm doesn't do a reset is that the PM features on some of the DSS registers were set and controlled outside dss driver, so the dss driver could not do a reset just like that. That design was carried to the tidss driver, although I'm not sure if the reason is valid on AM6 and J7 platforms. If that reasoning is not valid, this patch is ok and: Reviewed-by: Tomi Valkeinen Tomi > Signed-off-by: Devarsh Thakkar > --- > drivers/gpu/drm/tidss/tidss_dispc.c | 18 ++++++++++++++++++ > 1 file changed, 18 insertions(+) > > diff --git a/drivers/gpu/drm/tidss/tidss_dispc.c b/drivers/gpu/drm/tidss/tidss_dispc.c > index 60b92df615aa..dae47853b728 100644 > --- a/drivers/gpu/drm/tidss/tidss_dispc.c > +++ b/drivers/gpu/drm/tidss/tidss_dispc.c > @@ -2650,6 +2650,20 @@ static void dispc_init_errata(struct dispc_device *dispc) > } > } > > +static void dispc_softreset(struct dispc_device *dispc) > +{ > + u32 val; > + int ret = 0; > + > + /* Soft reset */ > + REG_FLD_MOD(dispc, DSS_SYSCONFIG, 1, 1, 1); > + /* Wait for reset to complete */ > + ret = readl_poll_timeout(dispc->base_common + DSS_SYSSTATUS, > + val, val & 1, 100, 5000); > + if (ret) > + dev_warn(dispc->dev, "failed to reset dispc\n"); > +} > + > int dispc_init(struct tidss_device *tidss) > { > struct device *dev = tidss->dev; > @@ -2709,6 +2723,10 @@ int dispc_init(struct tidss_device *tidss) > return r; > } > > + /* K2G display controller does not support soft reset */ > + if (feat->subrev != DISPC_K2G) > + dispc_softreset(dispc); > + > for (i = 0; i < dispc->feat->num_vps; i++) { > u32 gamma_size = dispc->feat->vp_feat.color.gamma_size; > u32 *gamma_table; From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 44CECC433EF for ; Tue, 12 Apr 2022 14:26:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=PKdo0a8YTddNm2TrVVdENcur9oUyFfoo3M9R9YeI8yc=; b=LecSO5kMXAb5nO 3Cy2ZsGotdlRx0weyqrxfAZ3KwUpiVtgsdFl0x9+wMqGyRNfDa2Wi/YXnDChdqPvu2k9o0/JH46yx 0kC20i9G27ijA3SBnC5WcAk+t4vvX8ax4OzzZAYcv6xljkl8yGZebDqt5WUrccBvNwrmkyBfEZptF PuifcM75FyBeiUP0VBkzbyOiG9PiTYYE7yL/1mJtLy4G1ijgRYijL/kRHW5V8TIFJK3vVwO17vEiN 8aNMrQPi7dDTd2YOLHk0v4NjsdHgwWtQRK5dYHSo/E/JplyNxdduKPh245vc/p0j+xSEItSyZII6o uvalDuxBRrNdYSRNy7UA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1neHSB-00ElpL-KF; Tue, 12 Apr 2022 14:25:11 +0000 Received: from perceval.ideasonboard.com ([213.167.242.64]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1neHS8-00Elno-Br for linux-arm-kernel@lists.infradead.org; Tue, 12 Apr 2022 14:25:09 +0000 Received: from [192.168.1.111] (91-156-85-209.elisa-laajakaista.fi [91.156.85.209]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 53F24486; Tue, 12 Apr 2022 16:25:01 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1649773502; bh=TD/bZV0n+8gOuaITuXISCNvKDTaVocldAK+mP8GfBLA=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=qWqtmbG+qDmmBC5ucGcMjlZotm5YfmGMe11bdqgwIAxkUhErnX5V1SOMFJ22CqFaN oybAlLuQC0/8TaltkrMd7+POolRP0MdihrnqljtTSoChK5/8v4nh6n4qKVu5R17Stq AwZSOW0KWK4kgTn0lwILUtQF6vdaIuB45sV8TBPI= Message-ID: <86a07099-1074-e8d1-6d0e-1ce68414b627@ideasonboard.com> Date: Tue, 12 Apr 2022 17:24:58 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: Re: [PATCH] drm/tidss: Soft Reset DISPC on startup Content-Language: en-US To: Devarsh Thakkar , linux-kernel@vger.kernel.org, jyri.sarha@iki.fi, tomba@kernel.org, airlied@linux.ie, daniel@ffwll.ch, dri-devel@lists.freedesktop.org Cc: nm@ti.com, a-bhatia1@ti.com, r-ravikumar@ti.com, nikhil.nd@ti.com, linux-arm-kernel@lists.infradead.org, vigneshr@ti.com, laurent.pinchart@ideasonboard.com References: <20220314113739.18000-1-devarsht@ti.com> From: Tomi Valkeinen In-Reply-To: <20220314113739.18000-1-devarsht@ti.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220412_072508_603351_2CC53520 X-CRM114-Status: GOOD ( 22.75 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi, On 14/03/2022 13:37, Devarsh Thakkar wrote: > Soft reset the display subsystem controller on startup and wait for > the reset to complete. This helps the scenario where display was > already in use by some other core before the linux was booted. The reason the omapdrm doesn't do a reset is that the PM features on some of the DSS registers were set and controlled outside dss driver, so the dss driver could not do a reset just like that. That design was carried to the tidss driver, although I'm not sure if the reason is valid on AM6 and J7 platforms. If that reasoning is not valid, this patch is ok and: Reviewed-by: Tomi Valkeinen Tomi > Signed-off-by: Devarsh Thakkar > --- > drivers/gpu/drm/tidss/tidss_dispc.c | 18 ++++++++++++++++++ > 1 file changed, 18 insertions(+) > > diff --git a/drivers/gpu/drm/tidss/tidss_dispc.c b/drivers/gpu/drm/tidss/tidss_dispc.c > index 60b92df615aa..dae47853b728 100644 > --- a/drivers/gpu/drm/tidss/tidss_dispc.c > +++ b/drivers/gpu/drm/tidss/tidss_dispc.c > @@ -2650,6 +2650,20 @@ static void dispc_init_errata(struct dispc_device *dispc) > } > } > > +static void dispc_softreset(struct dispc_device *dispc) > +{ > + u32 val; > + int ret = 0; > + > + /* Soft reset */ > + REG_FLD_MOD(dispc, DSS_SYSCONFIG, 1, 1, 1); > + /* Wait for reset to complete */ > + ret = readl_poll_timeout(dispc->base_common + DSS_SYSSTATUS, > + val, val & 1, 100, 5000); > + if (ret) > + dev_warn(dispc->dev, "failed to reset dispc\n"); > +} > + > int dispc_init(struct tidss_device *tidss) > { > struct device *dev = tidss->dev; > @@ -2709,6 +2723,10 @@ int dispc_init(struct tidss_device *tidss) > return r; > } > > + /* K2G display controller does not support soft reset */ > + if (feat->subrev != DISPC_K2G) > + dispc_softreset(dispc); > + > for (i = 0; i < dispc->feat->num_vps; i++) { > u32 gamma_size = dispc->feat->vp_feat.color.gamma_size; > u32 *gamma_table; _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel