From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1B825C433FE for ; Fri, 29 Oct 2021 18:34:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 04FDC60F38 for ; Fri, 29 Oct 2021 18:34:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230390AbhJ2Sgs (ORCPT ); Fri, 29 Oct 2021 14:36:48 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44698 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230319AbhJ2Sgq (ORCPT ); Fri, 29 Oct 2021 14:36:46 -0400 Received: from mail-pg1-x536.google.com (mail-pg1-x536.google.com [IPv6:2607:f8b0:4864:20::536]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9C4C4C061714; Fri, 29 Oct 2021 11:34:17 -0700 (PDT) Received: by mail-pg1-x536.google.com with SMTP id q187so10726350pgq.2; Fri, 29 Oct 2021 11:34:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=ciI5iryyruFov1T0ma2aKRdnaHtK3Ppb+7gVjUGLj28=; b=AREq5zTFR/pt9gCkQVxg5sOlLaxl0XHIJUGKleG/Cwp4upMFdakU7JXZRR0o6/ZTDj i6Z9UKBNFulIwXzoUxuF6gst6SUACJsmaK8/VlP0KQ+4PTZIBSs/1mE9ZpklS8PMn4Bc nY9gShxeDU2YcuGpf+Z2LO+Y5DYpDLtgj+pkebP4+ol2LiJaDc9Hjyf9u0P7YOOmlYyz 1QFUuVkz5X8BTxaypAMx2xeoYrUN4te8iPQjuticy37X6pv2PW2JdbG53CGAQbnHpu79 YSgxNBba7KBIyak1OfqfGEI+11G9+Sk0TWU666QzWyMzZize34yU19G3KIKqDSziOunF /Bwg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=ciI5iryyruFov1T0ma2aKRdnaHtK3Ppb+7gVjUGLj28=; b=rTGCEgWuTMIKcu9jM1XQQYYsSIJAqmMOKC9za/tDEsK2wtgWsKjdcTUhxHHOqTneHt FI843e9HomdG9TLX7wBzQzzp1s1iKb885oi+egY1tPjyEfNsY1Vv6N8NFAfZG4vBxbt2 QgRfKvMvAECr6pKZVGMfI3TpPtyr5U/q5iibYe6DRXxaRiBNn0iiQi2Ca9WhHHuwm2XG 47DvRSKWTTVxRUIBW1zw0asweAkuxO5zbwCEoo1RSldaDmf14TnTIbwb7xtM8tuIxdBu LS+TeJoZHzEykGv8ee8wvbTxLFP7aurTdLGuUOewsqQopsR1jYZ9YtyM+gdJQRFy5r5L tajQ== X-Gm-Message-State: AOAM531b0lDPQWm92e9Onww70Afg4OuOsbdrpmlPjl3tRyxg6r3EwUtu oAg+QNM5PcduokhTyyVlPI8= X-Google-Smtp-Source: ABdhPJwtqLisSULzrE1662JucFFODElh//nnqMxtL0Qwan9VieOf5qxal7nCe9DgQrrt6C/4eCBE4g== X-Received: by 2002:a63:3c50:: with SMTP id i16mr9414406pgn.304.1635532457143; Fri, 29 Oct 2021 11:34:17 -0700 (PDT) Received: from [10.67.48.245] ([192.19.223.252]) by smtp.googlemail.com with ESMTPSA id pi9sm7282864pjb.31.2021.10.29.11.34.16 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 29 Oct 2021 11:34:16 -0700 (PDT) Subject: Re: [PATCH 5/7] watchdog: bcm7038_wdt: Add platform device id for bcm63xx-wdt To: =?UTF-8?B?UmFmYcWCIE1pxYJlY2tp?= , Florian Fainelli Cc: linux-kernel@vger.kernel.org, Wim Van Sebroeck , Guenter Roeck , Rob Herring , Thomas Bogendoerfer , bcm-kernel-feedback-list@broadcom.com, Justin Chen , linux-watchdog@vger.kernel.org, devicetree@vger.kernel.org, linux-mips@vger.kernel.org, linux-arm-kernel@lists.infradead.org References: <20211028172322.4021440-1-f.fainelli@gmail.com> <20211028172322.4021440-6-f.fainelli@gmail.com> <02cb3c1a160854c92895d024e59a831b@milecki.pl> From: Florian Fainelli Message-ID: <86bee996-d9ea-ba85-d89f-64faf9a4a44a@gmail.com> Date: Fri, 29 Oct 2021 11:34:15 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: <02cb3c1a160854c92895d024e59a831b@milecki.pl> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/29/21 5:37 AM, Rafał Miłecki wrote: > On 2021-10-28 19:23, Florian Fainelli wrote: >> In order to phase out bcm63xx_wdt and use bcm7038_wdt instead, introduce >> a platform_device_id table that allows both names to be matched. >> >> Signed-off-by: Florian Fainelli >> --- >>  drivers/watchdog/bcm7038_wdt.c | 7 +++++++ >>  1 file changed, 7 insertions(+) >> >> diff --git a/drivers/watchdog/bcm7038_wdt.c >> b/drivers/watchdog/bcm7038_wdt.c >> index 506cd7ef9c77..2535f450e8a1 100644 >> --- a/drivers/watchdog/bcm7038_wdt.c >> +++ b/drivers/watchdog/bcm7038_wdt.c >> @@ -223,6 +223,13 @@ static const struct of_device_id >> bcm7038_wdt_match[] = { >>  }; >>  MODULE_DEVICE_TABLE(of, bcm7038_wdt_match); >> >> +static const struct platform_device_id bcm7038_wdt_devtype[] = { >> +    { .name = "bcm7038-wdt" }, >> +    { .name = "bcm63xx-wdt" }, >> +    { /* sentinel */ }, >> +}; >> +MODULE_DEVICE_TABLE(platform, bcm7038_wdt_devtype); > > Do we really want "bcm7038-wdt" here? I don't think it will ever be used > as apparently BCM7038 uses DT. Let me dig through the platform_device_id code, but I believe we somehow do. -- Florian From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 81ABEC433EF for ; Fri, 29 Oct 2021 19:41:17 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4A6C160F58 for ; Fri, 29 Oct 2021 19:41:17 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 4A6C160F58 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date: Message-ID:From:References:Cc:To:Subject:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=xMYCM3kAB1PTnmBpsq1vh4rAWHX/lrwY31Aslp4OGGU=; b=b0mLWiSwkXLDAPTrhzYK1FJZTT GskDsUTCEGAthLuPhaRxsqZET4Zhe3f0wcpOBr/0XCYaStumjk2fxip09MuhMhfmxZLaRvAYNACid wNM/gsIxZ/J/BSEV5bWgb6JmKm5mwOfeTubqe5nqX3vVP54XXzw7G+p1CRQslWoACf/EanqRUensK OWIgm9HZMS4wk7GufKFg021xfqeQsvp2KI+lD3NW3wHCHKp7/DDk1fV0vteomAgrhqBt770yOr6uH O9nh9lx5CMaD6Kmmyri4OeIIHUDFYW9B05qKbU4qfe5GWPSumxN66h8QNTCIMHw+NH5t63fkJZlSz yCQDmsjw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mgXiV-00C1xe-QY; Fri, 29 Oct 2021 19:39:09 +0000 Received: from mail-pf1-x432.google.com ([2607:f8b0:4864:20::432]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mgWhm-00BnpR-RS for linux-arm-kernel@lists.infradead.org; Fri, 29 Oct 2021 18:34:20 +0000 Received: by mail-pf1-x432.google.com with SMTP id b1so6485043pfm.6 for ; Fri, 29 Oct 2021 11:34:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=ciI5iryyruFov1T0ma2aKRdnaHtK3Ppb+7gVjUGLj28=; b=AREq5zTFR/pt9gCkQVxg5sOlLaxl0XHIJUGKleG/Cwp4upMFdakU7JXZRR0o6/ZTDj i6Z9UKBNFulIwXzoUxuF6gst6SUACJsmaK8/VlP0KQ+4PTZIBSs/1mE9ZpklS8PMn4Bc nY9gShxeDU2YcuGpf+Z2LO+Y5DYpDLtgj+pkebP4+ol2LiJaDc9Hjyf9u0P7YOOmlYyz 1QFUuVkz5X8BTxaypAMx2xeoYrUN4te8iPQjuticy37X6pv2PW2JdbG53CGAQbnHpu79 YSgxNBba7KBIyak1OfqfGEI+11G9+Sk0TWU666QzWyMzZize34yU19G3KIKqDSziOunF /Bwg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=ciI5iryyruFov1T0ma2aKRdnaHtK3Ppb+7gVjUGLj28=; b=srwQ7tUV2ymgUrKAnbmRLWlBdTwf0vt6LOGhwsC6t3inkWAhNY0Grq6xaULsSDApaA TFmWTiGUsq0W7hELsH6JeesoszKlxUEM2blYOUYX4HIPNUDBJY/Gpan1Zey0A/y+BfPo CRX/Zr9Y33xYf2+s+LzwfHZCVsZlEGpVEXaIEjAn6C16vNxxdpE1ED8ATLYP7ubrZRTp LxolYrvjGm09JxMgi298337cehppWdVsf0QAgyIGgtBEPtykOJcklHwvqcVhexLBdS94 IpihKjWmGBwuy+t5Bc4iyXtmr3Dotea8UZv+cNFivSaovd6sTSxuZhGamvVH2b/FTMx3 oYNw== X-Gm-Message-State: AOAM532oTfMQ9/7udoA7NmrF/bDF/8JcfwhtlK9fSLCLjmNECJo4OK89 l27d3DKn9tbjhnOR/lRhYJ53/oP2K/0= X-Google-Smtp-Source: ABdhPJwtqLisSULzrE1662JucFFODElh//nnqMxtL0Qwan9VieOf5qxal7nCe9DgQrrt6C/4eCBE4g== X-Received: by 2002:a63:3c50:: with SMTP id i16mr9414406pgn.304.1635532457143; Fri, 29 Oct 2021 11:34:17 -0700 (PDT) Received: from [10.67.48.245] ([192.19.223.252]) by smtp.googlemail.com with ESMTPSA id pi9sm7282864pjb.31.2021.10.29.11.34.16 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 29 Oct 2021 11:34:16 -0700 (PDT) Subject: Re: [PATCH 5/7] watchdog: bcm7038_wdt: Add platform device id for bcm63xx-wdt To: =?UTF-8?B?UmFmYcWCIE1pxYJlY2tp?= , Florian Fainelli Cc: linux-kernel@vger.kernel.org, Wim Van Sebroeck , Guenter Roeck , Rob Herring , Thomas Bogendoerfer , bcm-kernel-feedback-list@broadcom.com, Justin Chen , linux-watchdog@vger.kernel.org, devicetree@vger.kernel.org, linux-mips@vger.kernel.org, linux-arm-kernel@lists.infradead.org References: <20211028172322.4021440-1-f.fainelli@gmail.com> <20211028172322.4021440-6-f.fainelli@gmail.com> <02cb3c1a160854c92895d024e59a831b@milecki.pl> From: Florian Fainelli Message-ID: <86bee996-d9ea-ba85-d89f-64faf9a4a44a@gmail.com> Date: Fri, 29 Oct 2021 11:34:15 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: <02cb3c1a160854c92895d024e59a831b@milecki.pl> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211029_113418_932719_1C13E58B X-CRM114-Status: GOOD ( 16.67 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gMTAvMjkvMjEgNTozNyBBTSwgUmFmYcWCIE1pxYJlY2tpIHdyb3RlOgo+IE9uIDIwMjEtMTAt MjggMTk6MjMsIEZsb3JpYW4gRmFpbmVsbGkgd3JvdGU6Cj4+IEluIG9yZGVyIHRvIHBoYXNlIG91 dCBiY202M3h4X3dkdCBhbmQgdXNlIGJjbTcwMzhfd2R0IGluc3RlYWQsIGludHJvZHVjZQo+PiBh IHBsYXRmb3JtX2RldmljZV9pZCB0YWJsZSB0aGF0IGFsbG93cyBib3RoIG5hbWVzIHRvIGJlIG1h dGNoZWQuCj4+Cj4+IFNpZ25lZC1vZmYtYnk6IEZsb3JpYW4gRmFpbmVsbGkgPGYuZmFpbmVsbGlA Z21haWwuY29tPgo+PiAtLS0KPj4gwqBkcml2ZXJzL3dhdGNoZG9nL2JjbTcwMzhfd2R0LmMgfCA3 ICsrKysrKysKPj4gwqAxIGZpbGUgY2hhbmdlZCwgNyBpbnNlcnRpb25zKCspCj4+Cj4+IGRpZmYg LS1naXQgYS9kcml2ZXJzL3dhdGNoZG9nL2JjbTcwMzhfd2R0LmMKPj4gYi9kcml2ZXJzL3dhdGNo ZG9nL2JjbTcwMzhfd2R0LmMKPj4gaW5kZXggNTA2Y2Q3ZWY5Yzc3Li4yNTM1ZjQ1MGU4YTEgMTAw NjQ0Cj4+IC0tLSBhL2RyaXZlcnMvd2F0Y2hkb2cvYmNtNzAzOF93ZHQuYwo+PiArKysgYi9kcml2 ZXJzL3dhdGNoZG9nL2JjbTcwMzhfd2R0LmMKPj4gQEAgLTIyMyw2ICsyMjMsMTMgQEAgc3RhdGlj IGNvbnN0IHN0cnVjdCBvZl9kZXZpY2VfaWQKPj4gYmNtNzAzOF93ZHRfbWF0Y2hbXSA9IHsKPj4g wqB9Owo+PiDCoE1PRFVMRV9ERVZJQ0VfVEFCTEUob2YsIGJjbTcwMzhfd2R0X21hdGNoKTsKPj4K Pj4gK3N0YXRpYyBjb25zdCBzdHJ1Y3QgcGxhdGZvcm1fZGV2aWNlX2lkIGJjbTcwMzhfd2R0X2Rl dnR5cGVbXSA9IHsKPj4gK8KgwqDCoCB7IC5uYW1lID0gImJjbTcwMzgtd2R0IiB9LAo+PiArwqDC oMKgIHsgLm5hbWUgPSAiYmNtNjN4eC13ZHQiIH0sCj4+ICvCoMKgwqAgeyAvKiBzZW50aW5lbCAq LyB9LAo+PiArfTsKPj4gK01PRFVMRV9ERVZJQ0VfVEFCTEUocGxhdGZvcm0sIGJjbTcwMzhfd2R0 X2RldnR5cGUpOwo+IAo+IERvIHdlIHJlYWxseSB3YW50ICJiY203MDM4LXdkdCIgaGVyZT8gSSBk b24ndCB0aGluayBpdCB3aWxsIGV2ZXIgYmUgdXNlZAo+IGFzIGFwcGFyZW50bHkgQkNNNzAzOCB1 c2VzIERULgoKTGV0IG1lIGRpZyB0aHJvdWdoIHRoZSBwbGF0Zm9ybV9kZXZpY2VfaWQgY29kZSwg YnV0IEkgYmVsaWV2ZSB3ZSBzb21laG93IGRvLgotLSAKRmxvcmlhbgoKX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KbGludXgtYXJtLWtlcm5lbCBtYWlsaW5n IGxpc3QKbGludXgtYXJtLWtlcm5lbEBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5p bmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtYXJtLWtlcm5lbAo=