From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D43B2C6FD19 for ; Thu, 16 Mar 2023 09:12:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230341AbjCPJMF (ORCPT ); Thu, 16 Mar 2023 05:12:05 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51808 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229911AbjCPJMB (ORCPT ); Thu, 16 Mar 2023 05:12:01 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7C54930E84; Thu, 16 Mar 2023 02:11:41 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 0F1D061F89; Thu, 16 Mar 2023 09:11:41 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6F54DC433D2; Thu, 16 Mar 2023 09:11:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1678957900; bh=gC8YadVrhzdETkgpAGHmabIPSjLYNNY9gNWZEEvTaHs=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=gWYMalLwWfBMInNfDnmIUf4+CArc+AEfdbYAYXjU3svspBeV964mrz2X8rICj2l8z vWYx5jBY4XSLh9TJp0Tt9achD7SJB6wvHwo7xf/Q+xlCN8QikPsyYsNtlT84eVehXj Hw+7ymnYYv41K5/XzBRGnZw9L+I/TBeJk1xVonFv222PZD1n9dzmg8EvfOXT+ZSfK9 dOGZIfOycSswGpK/fM6jWckAzilYcpMcChk6bm4CMwi28n1SMy1C4mNUXGCu45HP7p J/dk3ftI1f548K/zldL38t1JAdeGbTSp0BhHNyXI++bTGVQWFRmQpQnaC/0K/Jjvj8 WLMDvnCIaZvBw== Received: from sofa.misterjones.org ([185.219.108.64] helo=goblin-girl.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1pcje6-000Wbd-5V; Thu, 16 Mar 2023 09:11:38 +0000 Date: Thu, 16 Mar 2023 09:11:37 +0000 Message-ID: <86bkktxdpy.wl-maz@kernel.org> From: Marc Zyngier To: D Scott Phillips Cc: linux-usb@vger.kernel.org, Mathias Nyman , Greg Kroah-Hartman , linux-kernel@vger.kernel.org Subject: Re: [PATCH RESEND] xhci: also avoid the XHCI_ZERO_64B_REGS quirk with a passthrough iommu In-Reply-To: <20230315181440.1478259-1-scott@os.amperecomputing.com> References: <20230315181440.1478259-1-scott@os.amperecomputing.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/28.2 (aarch64-unknown-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: scott@os.amperecomputing.com, linux-usb@vger.kernel.org, mathias.nyman@intel.com, gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 15 Mar 2023 18:14:40 +0000, D Scott Phillips wrote: > > Previously the quirk was skipped when no iommu was present. The same > rationale for skipping the quirk also applies in the iommu.passthrough=1 > case. > > Skip applying the XHCI_ZERO_64B_REGS quirk if the device's iommu domain is > passthrough. > > Fixes: 12de0a35c996 ("xhci: Add quirk to zero 64bit registers on Renesas PCIe controllers") > Signed-off-by: D Scott Phillips Acked-by: Marc Zyngier M. -- Without deviation from the norm, progress is not possible.