From mboxrd@z Thu Jan 1 00:00:00 1970 From: George Dunlap Subject: Re: [PATCH v2 3/7] x86/vm-event/monitor: don't compromise monitor_write_data on domain cleanup Date: Tue, 5 Jul 2016 15:45:46 +0100 Message-ID: <86db9af7-88b8-d2f2-e435-00346f563338@citrix.com> References: <1467728717-13592-1-git-send-email-czuzu@bitdefender.com> <1467728902-13725-1-git-send-email-czuzu@bitdefender.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <1467728902-13725-1-git-send-email-czuzu@bitdefender.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" To: Corneliu ZUZU , xen-devel@lists.xen.org Cc: Tamas K Lengyel , Razvan Cojocaru , George Dunlap , Andrew Cooper , Paul Durrant , Jan Beulich List-Id: xen-devel@lists.xenproject.org T24gMDUvMDcvMTYgMTU6MjgsIENvcm5lbGl1IFpVWlUgd3JvdGU6Cj4gVGhlIGFyY2hfdm1fZXZl bnQgc3RydWN0dXJlIGlzIGR5bmFtaWNhbGx5IGFsbG9jYXRlZCBhbmQgZnJlZWQgQAo+IHZtX2V2 ZW50X2NsZWFudXBfZG9tYWluLiBUaGlzIGNsZWFudXAgaXMgdHJpZ2dlcmVkIGUuZy4gd2hlbiB0 aGUgdG9vbHN0YWNrIHVzZXIKPiBkaXNhYmxlcyBkb21haW4gbW9uaXRvcmluZyAoeGNfbW9uaXRv cl9kaXNhYmxlKSwgd2hpY2ggaW4gdHVybiBlZmZlY3RpdmVseQo+IGRpc2NhcmRzIGFueSBpbmZv cm1hdGlvbiB0aGF0IHdhcyBpbiBhcmNoX3ZtX2V2ZW50LndyaXRlX2RhdGEuCj4gCj4gQnV0IHRo aXMgY2FuIHlpZWxkIHVuZXhwZWN0ZWQgYmVoYXZpb3Igc2luY2UgaWYgYSBDUi13cml0ZSB3YXMg YXdhaXRpbmcgdG8gYmUKPiBjb21taXR0ZWQgb24gdGhlIHNjaGVkdWxpbmcgdGFpbCAoaHZtX2Rv X3Jlc3VtZS0+YXJjaF9tb25pdG9yX3dyaXRlX2RhdGEpCj4gYmVmb3JlIHhjX21vbml0b3JfZGlz YWJsZSBpcyBjYWxsZWQsIHRoZW4gdGhlIGRvbWFpbiBDUiB3cml0ZSBpcyB3cm9uZ2Z1bGx5Cj4g aWdub3JlZCwgd2hpY2ggb2YgY291cnNlLCBpbiB0aGVzZSBjYXNlcywgY2FuIGVhc2lseSByZW5k ZXIgYSBkb21haW4gY3Jhc2guCj4gCj4gVG8gZml4IHRoZSBpc3N1ZSwgdGhpcyBwYXRjaCBtYWtl cyBhcmNoX3ZtX2V2ZW50LmVtdWxfcmVhZF9kYXRhIGR5bmFtaWNhbGx5Cj4gYWxsb2NhdGVkIGFu ZCBvbmx5IGZyZWVzIHRoYXQgaW4gdm1fZXZlbnRfY2xlYW51cF9kb21haW4sIGluc3RlYWQgb2Yg dGhlIHdob2xlCj4gYXJjaF92Y3B1LnZtX2V2ZW50IHN0cnVjdHVyZSwgd2hpY2ggd2l0aCB0aGlz IHBhdGNoIHdpbGwgb25seSBiZSBmcmVlZCBvbgo+IHZjcHUvZG9tYWluIGRlc3Ryb3lhbC4KPiAK PiBTaWduZWQtb2ZmLWJ5OiBDb3JuZWxpdSBaVVpVIDxjenV6dUBiaXRkZWZlbmRlci5jb20+Cj4g QWNrZWQtYnk6IFJhenZhbiBDb2pvY2FydSA8cmNvam9jYXJ1QGJpdGRlZmVuZGVyLmNvbT4KCltz bmlwXQoKPiBkaWZmIC0tZ2l0IGEveGVuL2FyY2gveDg2L21tL3AybS5jIGIveGVuL2FyY2gveDg2 L21tL3AybS5jCj4gaW5kZXggMTY3MzNhNC4uNjYxNjYyNiAxMDA2NDQKPiAtLS0gYS94ZW4vYXJj aC94ODYvbW0vcDJtLmMKPiArKysgYi94ZW4vYXJjaC94ODYvbW0vcDJtLmMKPiBAQCAtMTY0Miw3 ICsxNjQyLDcgQEAgdm9pZCBwMm1fbWVtX2FjY2Vzc19lbXVsYXRlX2NoZWNrKHN0cnVjdCB2Y3B1 ICp2LAo+ICAgICAgICAgIHYtPmFyY2gudm1fZXZlbnQtPmVtdWxhdGVfZmxhZ3MgPSB2aW9sYXRp b24gPyByc3AtPmZsYWdzIDogMDsKPiAgCj4gICAgICAgICAgaWYgKCAocnNwLT5mbGFncyAmIFZN X0VWRU5UX0ZMQUdfU0VUX0VNVUxfUkVBRF9EQVRBKSApCj4gLSAgICAgICAgICAgIHYtPmFyY2gu dm1fZXZlbnQtPmVtdWxfcmVhZF9kYXRhID0gcnNwLT5kYXRhLmVtdWxfcmVhZF9kYXRhOwo+ICsg ICAgICAgICAgICAqdi0+YXJjaC52bV9ldmVudC0+ZW11bF9yZWFkX2RhdGEgPSByc3AtPmRhdGEu ZW11bF9yZWFkX2RhdGE7Cj4gICAgICB9Cj4gIH0KPiAgCgpPbiB0aGUgYmFzaXMgb2YgUmF6dmFu J3MgYWNrOgoKQWNrZWQtYnk6IEdlb3JnZSBEdW5sYXAgPGdlb3JnZS5kdW5sYXBAY2l0cml4LmNv bT4KCj4gZGlmZiAtLWdpdCBhL3hlbi9hcmNoL3g4Ni92bV9ldmVudC5jIGIveGVuL2FyY2gveDg2 L3ZtX2V2ZW50LmMKPiBpbmRleCA4MGY4NGQ2Li4wZTI1ZTRkIDEwMDY0NAo+IC0tLSBhL3hlbi9h cmNoL3g4Ni92bV9ldmVudC5jCj4gKysrIGIveGVuL2FyY2gveDg2L3ZtX2V2ZW50LmMKPiBAQCAt MzAsMTIgKzMwLDE4IEBAIGludCB2bV9ldmVudF9pbml0X2RvbWFpbihzdHJ1Y3QgZG9tYWluICpk KQo+ICAKPiAgICAgIGZvcl9lYWNoX3ZjcHUgKCBkLCB2ICkKPiAgICAgIHsKPiAtICAgICAgICBp ZiAoIHYtPmFyY2gudm1fZXZlbnQgKQo+ICsgICAgICAgIGlmICggbGlrZWx5KCF2LT5hcmNoLnZt X2V2ZW50KSApCj4gKyAgICAgICAgewo+ICsgICAgICAgICAgICB2LT5hcmNoLnZtX2V2ZW50ID0g eHphbGxvYyhzdHJ1Y3QgYXJjaF92bV9ldmVudCk7Cj4gKyAgICAgICAgICAgIGlmICggIXYtPmFy Y2gudm1fZXZlbnQgKQo+ICsgICAgICAgICAgICAgICAgcmV0dXJuIC1FTk9NRU07Cj4gKyAgICAg ICAgfQo+ICsgICAgICAgIGVsc2UgaWYgKCB1bmxpa2VseSh2LT5hcmNoLnZtX2V2ZW50LT5lbXVs X3JlYWRfZGF0YSkgKQo+ICAgICAgICAgICAgICBjb250aW51ZTsKPiAgCj4gLSAgICAgICAgdi0+ YXJjaC52bV9ldmVudCA9IHh6YWxsb2Moc3RydWN0IGFyY2hfdm1fZXZlbnQpOwo+IC0KPiAtICAg ICAgICBpZiAoICF2LT5hcmNoLnZtX2V2ZW50ICkKPiArICAgICAgICB2LT5hcmNoLnZtX2V2ZW50 LT5lbXVsX3JlYWRfZGF0YSA9Cj4gKyAgICAgICAgICAgICAgICB4emFsbG9jKHN0cnVjdCB2bV9l dmVudF9lbXVsX3JlYWRfZGF0YSk7Cj4gKyAgICAgICAgaWYgKCAhdi0+YXJjaC52bV9ldmVudC0+ ZW11bF9yZWFkX2RhdGEgKQo+ICAgICAgICAgICAgICByZXR1cm4gLUVOT01FTTsKPiAgICAgIH0K PiAgCj4gQEAgLTUyLDggKzU4LDEyIEBAIHZvaWQgdm1fZXZlbnRfY2xlYW51cF9kb21haW4oc3Ry dWN0IGRvbWFpbiAqZCkKPiAgCj4gICAgICBmb3JfZWFjaF92Y3B1ICggZCwgdiApCj4gICAgICB7 Cj4gLSAgICAgICAgeGZyZWUodi0+YXJjaC52bV9ldmVudCk7Cj4gLSAgICAgICAgdi0+YXJjaC52 bV9ldmVudCA9IE5VTEw7Cj4gKyAgICAgICAgaWYgKCBsaWtlbHkoIXYtPmFyY2gudm1fZXZlbnQp ICkKPiArICAgICAgICAgICAgY29udGludWU7Cj4gKwo+ICsgICAgICAgIHYtPmFyY2gudm1fZXZl bnQtPmVtdWxhdGVfZmxhZ3MgPSAwOwo+ICsgICAgICAgIHhmcmVlKHYtPmFyY2gudm1fZXZlbnQt PmVtdWxfcmVhZF9kYXRhKTsKPiArICAgICAgICB2LT5hcmNoLnZtX2V2ZW50LT5lbXVsX3JlYWRf ZGF0YSA9IE5VTEw7Cj4gICAgICB9Cj4gIAo+ICAgICAgZC0+YXJjaC5tZW1fYWNjZXNzX2VtdWxh dGVfZWFjaF9yZXAgPSAwOwo+IGRpZmYgLS1naXQgYS94ZW4vY29tbW9uL3ZtX2V2ZW50LmMgYi94 ZW4vY29tbW9uL3ZtX2V2ZW50LmMKPiBpbmRleCAxN2QyNzE2Li43NWJiYmFiIDEwMDY0NAo+IC0t LSBhL3hlbi9jb21tb24vdm1fZXZlbnQuYwo+ICsrKyBiL3hlbi9jb21tb24vdm1fZXZlbnQuYwo+ IEBAIC01MzQsNiArNTM0LDggQEAgc3RhdGljIHZvaWQgbWVtX3NoYXJpbmdfbm90aWZpY2F0aW9u KHN0cnVjdCB2Y3B1ICp2LCB1bnNpZ25lZCBpbnQgcG9ydCkKPiAgLyogQ2xlYW4gdXAgb24gZG9t YWluIGRlc3RydWN0aW9uICovCj4gIHZvaWQgdm1fZXZlbnRfY2xlYW51cChzdHJ1Y3QgZG9tYWlu ICpkKQo+ICB7Cj4gKyAgICBzdHJ1Y3QgdmNwdSAqdjsKPiArCj4gICNpZmRlZiBDT05GSUdfSEFT X01FTV9QQUdJTkcKPiAgICAgIGlmICggZC0+dm1fZXZlbnQtPnBhZ2luZy5yaW5nX3BhZ2UgKQo+ ICAgICAgewo+IEBAIC01NjAsNiArNTYyLDE1IEBAIHZvaWQgdm1fZXZlbnRfY2xlYW51cChzdHJ1 Y3QgZG9tYWluICpkKQo+ICAgICAgICAgICh2b2lkKXZtX2V2ZW50X2Rpc2FibGUoZCwgJmQtPnZt X2V2ZW50LT5zaGFyZSk7Cj4gICAgICB9Cj4gICNlbmRpZgo+ICsKPiArICAgIGZvcl9lYWNoX3Zj cHUgKCBkLCB2ICkKPiArICAgIHsKPiArICAgICAgICBpZiAoIHVubGlrZWx5KHYtPmFyY2gudm1f ZXZlbnQpICkKPiArICAgICAgICB7Cj4gKyAgICAgICAgICAgIHhmcmVlKHYtPmFyY2gudm1fZXZl bnQpOwo+ICsgICAgICAgICAgICB2LT5hcmNoLnZtX2V2ZW50ID0gTlVMTDsKPiArICAgICAgICB9 Cj4gKyAgICB9Cj4gIH0KPiAgCj4gIGludCB2bV9ldmVudF9kb21jdGwoc3RydWN0IGRvbWFpbiAq ZCwgeGVuX2RvbWN0bF92bV9ldmVudF9vcF90ICp2ZWMsCj4gZGlmZiAtLWdpdCBhL3hlbi9pbmNs dWRlL2FzbS14ODYvbW9uaXRvci5oIGIveGVuL2luY2x1ZGUvYXNtLXg4Ni9tb25pdG9yLmgKPiBp bmRleCAwNjExNjgxLi5hMDk0YzBkIDEwMDY0NAo+IC0tLSBhL3hlbi9pbmNsdWRlL2FzbS14ODYv bW9uaXRvci5oCj4gKysrIGIveGVuL2luY2x1ZGUvYXNtLXg4Ni9tb25pdG9yLmgKPiBAQCAtMjYs NiArMjYsNyBAQAo+ICAjaW5jbHVkZSA8cHVibGljL2RvbWN0bC5oPgo+ICAjaW5jbHVkZSA8YXNt L2NwdWZlYXR1cmUuaD4KPiAgI2luY2x1ZGUgPGFzbS9odm0vaHZtLmg+Cj4gKyNpbmNsdWRlIDxh c20vdm1fZXZlbnQuaD4KPiAgCj4gICNkZWZpbmUgbW9uaXRvcl9jdHJscmVnX2JpdG1hc2soY3Ry bHJlZ19pbmRleCkgKDFVIDw8IChjdHJscmVnX2luZGV4KSkKPiAgCj4gQEAgLTQ4LDcgKzQ5LDgg QEAgaW50IGFyY2hfbW9uaXRvcl9kb21jdGxfb3Aoc3RydWN0IGRvbWFpbiAqZCwgc3RydWN0IHhl bl9kb21jdGxfbW9uaXRvcl9vcCAqbW9wKQo+ICAgICAgICAgICAqIEVuYWJsaW5nIG1lbV9hY2Nl c3NfZW11bGF0ZV9lYWNoX3JlcCB3aXRob3V0IGEgdm1fZXZlbnQgc3Vic2NyaWJlcgo+ICAgICAg ICAgICAqIGlzIG1lYW5pbmdsZXNzLgo+ICAgICAgICAgICAqLwo+IC0gICAgICAgIGlmICggZC0+ bWF4X3ZjcHVzICYmIGQtPnZjcHVbMF0gJiYgZC0+dmNwdVswXS0+YXJjaC52bV9ldmVudCApCj4g KyAgICAgICAgaWYgKCBkLT5tYXhfdmNwdXMgJiYgZC0+dmNwdVswXSAmJiBkLT52Y3B1WzBdLT5h cmNoLnZtX2V2ZW50ICYmCj4gKyAgICAgICAgICAgICBkLT52Y3B1WzBdLT5hcmNoLnZtX2V2ZW50 LT5lbXVsX3JlYWRfZGF0YSApCj4gICAgICAgICAgICAgIGQtPmFyY2gubWVtX2FjY2Vzc19lbXVs YXRlX2VhY2hfcmVwID0gISFtb3AtPmV2ZW50Owo+ICAgICAgICAgIGVsc2UKPiAgICAgICAgICAg ICAgcmMgPSAtRUlOVkFMOwo+IGRpZmYgLS1naXQgYS94ZW4vaW5jbHVkZS9hc20teDg2L3ZtX2V2 ZW50LmggYi94ZW4vaW5jbHVkZS9hc20teDg2L3ZtX2V2ZW50LmgKPiBpbmRleCAwMjZmNDJlLi41 NTdmMzUzIDEwMDY0NAo+IC0tLSBhL3hlbi9pbmNsdWRlL2FzbS14ODYvdm1fZXZlbnQuaAo+ICsr KyBiL3hlbi9pbmNsdWRlL2FzbS14ODYvdm1fZXZlbnQuaAo+IEBAIC0yOCw3ICsyOCw3IEBACj4g ICAqLwo+ICBzdHJ1Y3QgYXJjaF92bV9ldmVudCB7Cj4gICAgICB1aW50MzJfdCBlbXVsYXRlX2Zs YWdzOwo+IC0gICAgc3RydWN0IHZtX2V2ZW50X2VtdWxfcmVhZF9kYXRhIGVtdWxfcmVhZF9kYXRh Owo+ICsgICAgc3RydWN0IHZtX2V2ZW50X2VtdWxfcmVhZF9kYXRhICplbXVsX3JlYWRfZGF0YTsK PiAgICAgIHN0cnVjdCBtb25pdG9yX3dyaXRlX2RhdGEgd3JpdGVfZGF0YTsKPiAgfTsKPiAgCj4g CgoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KWGVuLWRl dmVsIG1haWxpbmcgbGlzdApYZW4tZGV2ZWxAbGlzdHMueGVuLm9yZwpodHRwczovL2xpc3RzLnhl bi5vcmcveGVuLWRldmVsCg==