All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jeff Johnson <quic_jjohnson@quicinc.com>
To: Randy Dunlap <rdunlap@infradead.org>,
	Johannes Berg <johannes@sipsolutions.net>,
	"David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>
Cc: <linux-wireless@vger.kernel.org>, <netdev@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] wifi: mac80222: Fix ieee80211_i.h kernel-doc issues
Date: Thu, 28 Mar 2024 16:07:39 -0700	[thread overview]
Message-ID: <86de9e81-7ac4-4609-bd18-d92e7244e2a5@quicinc.com> (raw)
In-Reply-To: <a009a21a-56d7-4a1a-aaf9-feefa5acc561@infradead.org>

On 3/28/2024 3:16 PM, Randy Dunlap wrote:
> Hi,
> 
> On 3/28/24 14:08, Jeff Johnson wrote:
>> kernel-doc flagged the following issues:
>>
>> net/mac80211/ieee80211_i.h:146: warning: expecting prototype for enum ieee80211_corrupt_data_flags. Prototype was for enum ieee80211_bss_corrupt_data_flags instead
>> net/mac80211/ieee80211_i.h:163: warning: expecting prototype for enum ieee80211_valid_data_flags. Prototype was for enum ieee80211_bss_valid_data_flags instead
>>
>> Correct the documentation to match the code.
>>
>> Signed-off-by: Jeff Johnson <quic_jjohnson@quicinc.com>
> 
> These seem to be corrected in linux-next already.

Looks like I fixed these two earlier -- not sure why they haven't reached
wireless-next yet which was the code I was looking at today.

I've flagged as N/A in patchwork

> However, I do still see this one:
> 
> ieee80211_i.h:689: warning: missing initial short description on line:
>  * struct mesh_table

Ah, I haven't been adding [-Wshort-desc[ription]]  (or some of the other -W
switches)

Yay, I can find even more issues.

I'll fix this one


      reply	other threads:[~2024-03-28 23:08 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-28 21:08 [PATCH] wifi: mac80222: Fix ieee80211_i.h kernel-doc issues Jeff Johnson
2024-03-28 22:16 ` Randy Dunlap
2024-03-28 23:07   ` Jeff Johnson [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=86de9e81-7ac4-4609-bd18-d92e7244e2a5@quicinc.com \
    --to=quic_jjohnson@quicinc.com \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=johannes@sipsolutions.net \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=rdunlap@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.