From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.9 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4C4C7C47083 for ; Wed, 2 Jun 2021 08:12:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 31197610C8 for ; Wed, 2 Jun 2021 08:12:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232418AbhFBINt (ORCPT ); Wed, 2 Jun 2021 04:13:49 -0400 Received: from szxga08-in.huawei.com ([45.249.212.255]:3342 "EHLO szxga08-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229882AbhFBINn (ORCPT ); Wed, 2 Jun 2021 04:13:43 -0400 Received: from dggemv703-chm.china.huawei.com (unknown [172.30.72.55]) by szxga08-in.huawei.com (SkyGuard) with ESMTP id 4Fw1pX0GhYz19S5g; Wed, 2 Jun 2021 16:07:16 +0800 (CST) Received: from dggema762-chm.china.huawei.com (10.1.198.204) by dggemv703-chm.china.huawei.com (10.3.19.46) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.2176.2; Wed, 2 Jun 2021 16:11:57 +0800 Received: from [10.174.179.129] (10.174.179.129) by dggema762-chm.china.huawei.com (10.1.198.204) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2176.2; Wed, 2 Jun 2021 16:11:57 +0800 Subject: Re: [PATCH] clk: socfpga: remove set but not used variable 'rc' To: Stephen Boyd , , , CC: , , References: <20210514062234.3534615-1-yukuai3@huawei.com> <162262008540.4130789.916741380026683860@swboyd.mtv.corp.google.com> From: "yukuai (C)" Message-ID: <86e34f50-ad3b-f34a-c5dd-0849496ffd67@huawei.com> Date: Wed, 2 Jun 2021 16:11:56 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: <162262008540.4130789.916741380026683860@swboyd.mtv.corp.google.com> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [10.174.179.129] X-ClientProxiedBy: dggems702-chm.china.huawei.com (10.3.19.179) To dggema762-chm.china.huawei.com (10.1.198.204) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2021/06/02 15:48, Stephen Boyd wrote: > Quoting Yu Kuai (2021-05-13 23:22:34) >> Fixes gcc '-Wunused-but-set-variable' warning: >> >> drivers/clk/socfpga/clk-pll.c:83:6: warning: variable ‘rc’ set but >> not used [-Wunused-but-set-variable] >> >> The returned value of of_clk_add_provider() is never used, and so >> can be removed. >> >> Fixes: 97259e99bdc9 ("clk: socfpga: split clk code") >> Signed-off-by: Yu Kuai >> --- >> drivers/clk/socfpga/clk-pll.c | 3 +-- >> 1 file changed, 1 insertion(+), 2 deletions(-) >> >> diff --git a/drivers/clk/socfpga/clk-pll.c b/drivers/clk/socfpga/clk-pll.c >> index dcb573d44034..127cc849c5ee 100644 >> --- a/drivers/clk/socfpga/clk-pll.c >> +++ b/drivers/clk/socfpga/clk-pll.c >> @@ -80,7 +80,6 @@ static __init struct clk_hw *__socfpga_pll_init(struct device_node *node, >> const char *parent_name[SOCFPGA_MAX_PARENTS]; >> struct clk_init_data init; >> struct device_node *clkmgr_np; >> - int rc; >> int err; >> >> of_property_read_u32(node, "reg", ®); >> @@ -114,7 +113,7 @@ static __init struct clk_hw *__socfpga_pll_init(struct device_node *node, >> kfree(pll_clk); >> return ERR_PTR(err); >> } >> - rc = of_clk_add_provider(node, of_clk_src_simple_get, hw_clk); >> + of_clk_add_provider(node, of_clk_src_simple_get, hw_clk); > > Shouldn't we fail if of_clk_add_provider() fails? So return some sort of > error pointer and unwind allocations, etc. Will send a v2 patch. By the way, do you think it's better to return error pointer instead of NULL pointer when kzalloc() failed? Thanks Yu Kuai > >> return hw_clk; >> } >> > . >