From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BAC19C4338F for ; Wed, 11 Aug 2021 03:29:03 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9301E60EC0 for ; Wed, 11 Aug 2021 03:29:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232927AbhHKD3Y (ORCPT ); Tue, 10 Aug 2021 23:29:24 -0400 Received: from mail-m17656.qiye.163.com ([59.111.176.56]:46338 "EHLO mail-m17656.qiye.163.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232625AbhHKD3X (ORCPT ); Tue, 10 Aug 2021 23:29:23 -0400 Received: from [172.25.45.51] (unknown [58.251.74.232]) by mail-m17656.qiye.163.com (Hmail) with ESMTPA id C2186C40260; Wed, 11 Aug 2021 11:28:57 +0800 (CST) Subject: Re: [f2fs-dev] f2fs do DIO write make file corruption To: Chao Yu , linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net References: <5b68208b-fd94-bf4e-fc4b-d79d13abf1c6@vivo.com> <6519b8b7-1eb0-f286-7593-5c5ebbfb5554@kernel.org> From: Wu Bo Message-ID: <86e53ee7-13b5-5e8e-7c81-acb1736ebc8b@vivo.com> Date: Wed, 11 Aug 2021 11:28:57 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.12.0 MIME-Version: 1.0 In-Reply-To: <6519b8b7-1eb0-f286-7593-5c5ebbfb5554@kernel.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit X-HM-Spam-Status: e1kfGhgUHx5ZQUtXWQgPGg8OCBgUHx5ZQUlOS1dZCBgUCR5ZQVlLVUtZV1 kWDxoPAgseWUFZKDYvK1lXWShZQUhPN1dZLVlBSVdZDwkaFQgSH1lBWRpKGk1WT05DGkkdTx5LHU MYVRMBExYaEhckFA4PWVdZFhoPEhUdFFlBWU9LSFVKSktITUpVS1kG X-HM-Sender-Digest: e1kMHhlZQR0aFwgeV1kSHx4VD1lBWUc6NBQ6Sww5FT9NTCMQEhYxQwgc NB0KCUtVSlVKTUlDTU5JTkhDSUJIVTMWGhIXVRkUVQwOOw0SDRRVGBQWRVlXWRILWUFZTkNVSU5K VUxPVUlISVlXWQgBWUFITEtCNwY+ X-HM-Tid: 0a7b33418820da02kuwsc2186c40260 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 在 2021/8/11 11:03, Chao Yu 写道: > On 2021/8/11 10:48, Wu Bo wrote: >> I use the following command to create a file, the file may got >> corruption: >>     f2fs_io write 2 0 512 inc_num dio $path >> >> And when I use bio or to set the chunk size to 1 block, the file is >> normal. The commands as following: >>     f2fs_io write 2 0 512 inc_num buffered $path >>     f2fs_io write 1 0 512 inc_num dio $path >> >> I find this bug on old kernel version 4.14.117, and not find on version >> 4.19.152. So this bug is fixed. Can anyone can tell me which patch fixed >> this bug? > > Not sure, > > https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/?h=linux-4.19.y&id=7bae8b6b73e46c307fa355ce086800b7ad6610f8 > This patch is applied. The issue occurs when f2fs dio try to preallocate multiple blocks and got scattered disk blocks. The log as following: my_f2fs_io-13425 [002] .... 395.583637: el0_irq_naked: 1:type:1,ino:40132,off:768,old_blk:0,new_blk:185764 my_f2fs_io-13425 [002] .... 395.583710: el0_irq_naked: 1:type:1,ino:40132,off:769,old_blk:0,new_blk:205824 my_f2fs_io-13425 [002] .... 395.583721: f2fs_map_blocks: dev = (259,23), ino = 40132, file offset = 768, start blkaddr = 0x2d5a4, len = 0x2, err = 0 my_f2fs_io-13425 [002] .... 395.583735: f2fs_map_blocks: dev = (259,23), ino = 40132, file offset = 768, start blkaddr = 0x2d5a4, len = 0x1, err = 0 my_f2fs_io-13425 [002] .... 395.583741: f2fs_map_blocks: dev = (259,23), ino = 40132, file offset = 769, start blkaddr = 0x32400, len = 0x1, err = 0 And if the blocks are continuously, the file data is normal: my_f2fs_io-13425 [002] .... 395.584037: el0_irq_naked: 1:type:1,ino:40132,off:770,old_blk:0,new_blk:205825 my_f2fs_io-13425 [002] .... 395.584066: el0_irq_naked: 1:type:1,ino:40132,off:771,old_blk:0,new_blk:205826 my_f2fs_io-13425 [002] .... 395.584077: f2fs_map_blocks: dev = (259,23), ino = 40132, file offset = 770, start blkaddr = 0x32401, len = 0x2, err = 0 my_f2fs_io-13425 [002] .... 395.584091: f2fs_map_blocks: dev = (259,23), ino = 40132, file offset = 770, start blkaddr = 0x32401, len = 0x2, err = 0 > > Thanks, > >> >> >> _______________________________________________ >> Linux-f2fs-devel mailing list >> Linux-f2fs-devel@lists.sourceforge.net >> https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel >> > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5BA35C4338F for ; Wed, 11 Aug 2021 03:29:14 +0000 (UTC) Received: from lists.sourceforge.net (lists.sourceforge.net [216.105.38.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CA82D60EB7 for ; Wed, 11 Aug 2021 03:29:13 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org CA82D60EB7 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=vivo.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.sourceforge.net Received: from [127.0.0.1] (helo=sfs-ml-4.v29.lw.sourceforge.com) by sfs-ml-4.v29.lw.sourceforge.com with esmtp (Exim 4.90_1) (envelope-from ) id 1mDevY-0005ZI-Lb; Wed, 11 Aug 2021 03:29:12 +0000 Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-4.v29.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mDevW-0005ZB-O2 for linux-f2fs-devel@lists.sourceforge.net; Wed, 11 Aug 2021 03:29:10 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: MIME-Version:Date:Message-ID:From:References:To:Subject:Sender:Reply-To:Cc: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=h6eT7zjAyvfxGWJLaWVfFewxb2qLTbMrNEf3kj8Ej3c=; b=byhjViw0llqMdjraXl3ll2zjL5 2sFueZx3xw2O5ko5RB98HwRhUtzcMP5O87lgXNHI8VS4WyoKnfzSk/I+5oOpEY5VbcnOa8S4vaYvg bkTFmlng1AO8jRi0l7LbCUzDGSlwGvAtGAZJOOlWIfeJZbu9APer+SvpgOcTKnw8T+k4=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:MIME-Version:Date: Message-ID:From:References:To:Subject:Sender:Reply-To:Cc:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=h6eT7zjAyvfxGWJLaWVfFewxb2qLTbMrNEf3kj8Ej3c=; b=RmqLhdIc/GDSHn6uuY4foM2cXs BndRpdmETp/GbbtMaydi9fA5jiKQjwK4p7OnC/0+SDXL2vn4A0uA1q+CvX+P0oVDmFRpd/CfKgfO6 KQ7qR7cnQGYghyQ3To5g+9yLhx6xE5/6yLGwckZ7J5W4MjppnEY6/WYGn55NCkAAoveA=; Received: from mail-m17656.qiye.163.com ([59.111.176.56]) by sfi-mx-2.v28.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92.3) id 1mDevR-0002EW-Dh for linux-f2fs-devel@lists.sourceforge.net; Wed, 11 Aug 2021 03:29:10 +0000 Received: from [172.25.45.51] (unknown [58.251.74.232]) by mail-m17656.qiye.163.com (Hmail) with ESMTPA id C2186C40260; Wed, 11 Aug 2021 11:28:57 +0800 (CST) To: Chao Yu , linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net References: <5b68208b-fd94-bf4e-fc4b-d79d13abf1c6@vivo.com> <6519b8b7-1eb0-f286-7593-5c5ebbfb5554@kernel.org> From: Wu Bo Message-ID: <86e53ee7-13b5-5e8e-7c81-acb1736ebc8b@vivo.com> Date: Wed, 11 Aug 2021 11:28:57 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.12.0 MIME-Version: 1.0 In-Reply-To: <6519b8b7-1eb0-f286-7593-5c5ebbfb5554@kernel.org> X-HM-Spam-Status: e1kfGhgUHx5ZQUtXWQgPGg8OCBgUHx5ZQUlOS1dZCBgUCR5ZQVlLVUtZV1 kWDxoPAgseWUFZKDYvK1lXWShZQUhPN1dZLVlBSVdZDwkaFQgSH1lBWRpKGk1WT05DGkkdTx5LHU MYVRMBExYaEhckFA4PWVdZFhoPEhUdFFlBWU9LSFVKSktITUpVS1kG X-HM-Sender-Digest: e1kMHhlZQR0aFwgeV1kSHx4VD1lBWUc6NBQ6Sww5FT9NTCMQEhYxQwgc NB0KCUtVSlVKTUlDTU5JTkhDSUJIVTMWGhIXVRkUVQwOOw0SDRRVGBQWRVlXWRILWUFZTkNVSU5K VUxPVUlISVlXWQgBWUFITEtCNwY+ X-HM-Tid: 0a7b33418820da02kuwsc2186c40260 X-Headers-End: 1mDevR-0002EW-Dh Subject: Re: [f2fs-dev] f2fs do DIO write make file corruption X-BeenThere: linux-f2fs-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net CuWcqCAyMDIxLzgvMTEgMTE6MDMsIENoYW8gWXUg5YaZ6YGTOgo+IE9uIDIwMjEvOC8xMSAxMDo0 OCwgV3UgQm8gd3JvdGU6Cj4+IEkgdXNlIHRoZSBmb2xsb3dpbmcgY29tbWFuZCB0byBjcmVhdGUg YSBmaWxlLCB0aGUgZmlsZSBtYXkgZ290IAo+PiBjb3JydXB0aW9uOgo+PiDCoMKgwqDCoGYyZnNf aW8gd3JpdGUgMiAwIDUxMiBpbmNfbnVtIGRpbyAkcGF0aAo+Pgo+PiBBbmQgd2hlbiBJIHVzZSBi aW8gb3IgdG8gc2V0IHRoZSBjaHVuayBzaXplIHRvIDEgYmxvY2ssIHRoZSBmaWxlIGlzCj4+IG5v cm1hbC4gVGhlIGNvbW1hbmRzIGFzIGZvbGxvd2luZzoKPj4gwqDCoMKgwqBmMmZzX2lvIHdyaXRl IDIgMCA1MTIgaW5jX251bSBidWZmZXJlZCAkcGF0aAo+PiDCoMKgwqDCoGYyZnNfaW8gd3JpdGUg MSAwIDUxMiBpbmNfbnVtIGRpbyAkcGF0aAo+Pgo+PiBJIGZpbmQgdGhpcyBidWcgb24gb2xkIGtl cm5lbCB2ZXJzaW9uIDQuMTQuMTE3LCBhbmQgbm90IGZpbmQgb24gdmVyc2lvbgo+PiA0LjE5LjE1 Mi4gU28gdGhpcyBidWcgaXMgZml4ZWQuIENhbiBhbnlvbmUgY2FuIHRlbGwgbWUgd2hpY2ggcGF0 Y2ggZml4ZWQKPj4gdGhpcyBidWc/Cj4gCj4gTm90IHN1cmUsCj4gCj4gaHR0cHM6Ly9naXQua2Vy bmVsLm9yZy9wdWIvc2NtL2xpbnV4L2tlcm5lbC9naXQvc3RhYmxlL2xpbnV4LmdpdC9jb21taXQv P2g9bGludXgtNC4xOS55JmlkPTdiYWU4YjZiNzNlNDZjMzA3ZmEzNTVjZTA4NjgwMGI3YWQ2NjEw ZjggCj4gCgpUaGlzIHBhdGNoIGlzIGFwcGxpZWQuIFRoZSBpc3N1ZSBvY2N1cnMgd2hlbiBmMmZz IGRpbyB0cnkgdG8gcHJlYWxsb2NhdGUgCm11bHRpcGxlIGJsb2NrcyBhbmQgZ290IHNjYXR0ZXJl ZCBkaXNrIGJsb2Nrcy4gVGhlIGxvZyBhcyBmb2xsb3dpbmc6CiAgICAgICBteV9mMmZzX2lvLTEz NDI1IFswMDJdIC4uLi4gICAzOTUuNTgzNjM3OiBlbDBfaXJxX25ha2VkOiAKMTp0eXBlOjEsaW5v OjQwMTMyLG9mZjo3Njgsb2xkX2JsazowLG5ld19ibGs6MTg1NzY0CiAgICAgICBteV9mMmZzX2lv LTEzNDI1IFswMDJdIC4uLi4gICAzOTUuNTgzNzEwOiBlbDBfaXJxX25ha2VkOiAKMTp0eXBlOjEs aW5vOjQwMTMyLG9mZjo3Njksb2xkX2JsazowLG5ld19ibGs6MjA1ODI0CiAgICAgICBteV9mMmZz X2lvLTEzNDI1IFswMDJdIC4uLi4gICAzOTUuNTgzNzIxOiBmMmZzX21hcF9ibG9ja3M6IGRldiA9 IAooMjU5LDIzKSwgaW5vID0gNDAxMzIsIGZpbGUgb2Zmc2V0ID0gNzY4LCBzdGFydCBibGthZGRy ID0gMHgyZDVhNCwgbGVuID0gCjB4MiwgZXJyID0gMAogICAgICAgbXlfZjJmc19pby0xMzQyNSBb MDAyXSAuLi4uICAgMzk1LjU4MzczNTogZjJmc19tYXBfYmxvY2tzOiBkZXYgPSAKKDI1OSwyMyks IGlubyA9IDQwMTMyLCBmaWxlIG9mZnNldCA9IDc2OCwgc3RhcnQgYmxrYWRkciA9IDB4MmQ1YTQs IGxlbiA9IAoweDEsIGVyciA9IDAKICAgICAgIG15X2YyZnNfaW8tMTM0MjUgWzAwMl0gLi4uLiAg IDM5NS41ODM3NDE6IGYyZnNfbWFwX2Jsb2NrczogZGV2ID0gCigyNTksMjMpLCBpbm8gPSA0MDEz MiwgZmlsZSBvZmZzZXQgPSA3NjksIHN0YXJ0IGJsa2FkZHIgPSAweDMyNDAwLCBsZW4gPSAKMHgx LCBlcnIgPSAwCgpBbmQgaWYgdGhlIGJsb2NrcyBhcmUgY29udGludW91c2x5LCB0aGUgZmlsZSBk YXRhIGlzIG5vcm1hbDoKCSAgbXlfZjJmc19pby0xMzQyNSBbMDAyXSAuLi4uICAgMzk1LjU4NDAz NzogZWwwX2lycV9uYWtlZDogCjE6dHlwZToxLGlubzo0MDEzMixvZmY6NzcwLG9sZF9ibGs6MCxu ZXdfYmxrOjIwNTgyNQogICAgICAgbXlfZjJmc19pby0xMzQyNSBbMDAyXSAuLi4uICAgMzk1LjU4 NDA2NjogZWwwX2lycV9uYWtlZDogCjE6dHlwZToxLGlubzo0MDEzMixvZmY6NzcxLG9sZF9ibGs6 MCxuZXdfYmxrOjIwNTgyNgogICAgICAgbXlfZjJmc19pby0xMzQyNSBbMDAyXSAuLi4uICAgMzk1 LjU4NDA3NzogZjJmc19tYXBfYmxvY2tzOiBkZXYgPSAKKDI1OSwyMyksIGlubyA9IDQwMTMyLCBm aWxlIG9mZnNldCA9IDc3MCwgc3RhcnQgYmxrYWRkciA9IDB4MzI0MDEsIGxlbiA9IAoweDIsIGVy ciA9IDAKICAgICAgIG15X2YyZnNfaW8tMTM0MjUgWzAwMl0gLi4uLiAgIDM5NS41ODQwOTE6IGYy ZnNfbWFwX2Jsb2NrczogZGV2ID0gCigyNTksMjMpLCBpbm8gPSA0MDEzMiwgZmlsZSBvZmZzZXQg PSA3NzAsIHN0YXJ0IGJsa2FkZHIgPSAweDMyNDAxLCBsZW4gPSAKMHgyLCBlcnIgPSAwCgo+IAo+ IFRoYW5rcywKPiAKPj4KPj4KPj4gX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX18KPj4gTGludXgtZjJmcy1kZXZlbCBtYWlsaW5nIGxpc3QKPj4gTGludXgtZjJm cy1kZXZlbEBsaXN0cy5zb3VyY2Vmb3JnZS5uZXQKPj4gaHR0cHM6Ly9saXN0cy5zb3VyY2Vmb3Jn ZS5uZXQvbGlzdHMvbGlzdGluZm8vbGludXgtZjJmcy1kZXZlbAo+Pgo+IAoKCl9fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCkxpbnV4LWYyZnMtZGV2ZWwgbWFp bGluZyBsaXN0CkxpbnV4LWYyZnMtZGV2ZWxAbGlzdHMuc291cmNlZm9yZ2UubmV0Cmh0dHBzOi8v bGlzdHMuc291cmNlZm9yZ2UubmV0L2xpc3RzL2xpc3RpbmZvL2xpbnV4LWYyZnMtZGV2ZWwK