From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S944172AbdEZQRT (ORCPT ); Fri, 26 May 2017 12:17:19 -0400 Received: from huan3.mail.rambler.ru ([81.19.78.109]:43848 "EHLO huan3.mail.rambler.ru" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752407AbdEZQRO (ORCPT ); Fri, 26 May 2017 12:17:14 -0400 Subject: Re: [PATCH 1/4] Introduce regmap infrastructure over Maxim/Dalas OneWire (W1) bus To: Evgeniy Polyakov , Mark Brown Cc: Greg Kroah-Hartman , Sebastian Reichel , "linux-kernel@vger.kernel.org" , "linux-pm@vger.kernel.org" References: <20170525174639.3191-1-minimumlaw@rambler.ru> <20170525174639.3191-2-minimumlaw@rambler.ru> <404871495743279@web24o.yandex.ru> <20170526110602.jtvxf76abks4v3xf@sirena.org.uk> <3411811495806312@web49j.yandex.ru> From: "Alex A. Mihaylov" Message-ID: <86e846cd-95c2-621e-51ce-0da11f51b2c7@rambler.ru> Date: Fri, 26 May 2017 19:17:11 +0300 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.12; rv:52.0) Gecko/20100101 Thunderbird/52.1.1 MIME-Version: 1.0 In-Reply-To: <3411811495806312@web49j.yandex.ru> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-GB X-Rambler-User: minimumlaw@rambler.ru/178.66.246.97 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > Alex, it is up to you to decide whether you want to push your regmap version or not, > I will not object against, but in my personal opinion your first version version was much cleaner. I don't know. First edition (without regmap) was very simple. I think anyone could understand how this code works. On the other hand, there is already a lot of duplicate code in the kernel, which is responsible for accessing device registers on the bus. In this sense, using the regmap infrastructure should help. As for the complex description of registers of a simple device, I consciously went into this complication by describing all the holes in the register map. Since this driver is a pioneer, he must use the maximum of infrastructure capabilities. But I somehow do not really believe in the correctness of the realisation of regmap for W1. I have too few devices working with this bus. Theory, they all can work with my implementation of regmap. But not the fact that there will not be those who can not.