From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id DB7CDC6FD1D for ; Tue, 14 Mar 2023 10:20:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230215AbjCNKTw (ORCPT ); Tue, 14 Mar 2023 06:19:52 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40174 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230105AbjCNKTi (ORCPT ); Tue, 14 Mar 2023 06:19:38 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 66A8394 for ; Tue, 14 Mar 2023 03:19:02 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id CDBED616FB for ; Tue, 14 Mar 2023 10:18:11 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4197BC433EF; Tue, 14 Mar 2023 10:18:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1678789091; bh=bCtRPQv7hL+bF58dkg997VbbVXYl579kzeqhbRSP2b4=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=ODszmiBoQxpTOi9EMHIVmHNf2jTeV+UKLilm9lMIVNRKE1l00mgy7uRvjjYa/MaR/ wQhF365xrZLf9ag6Q3pa+8FYzQkkJ6U0B9ka0Lfm3ZbTFh5p+2WFH7g6p/xuznF3bZ epZQAXvr36fjPFZcEZC1BYdX3lVKmtA7aSBImHJEHOpzBgRPkRg/wCN8JTdpdl4Ze8 oMPPj2qcFkqiur1VIxcecybUAh9wKljZ6TObzCBslv0W47gXsL0AwK83czBqKzRPRU zsr8Ii+jm8hZWKmKxz4PB/L79EK3BcrgDYuIU6RBi1u4uPxPc/ooihn/JSTkq4QPvS 6NqLaVW864a0w== Received: from sofa.misterjones.org ([185.219.108.64] helo=goblin-girl.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1pc1jM-00HW40-Rg; Tue, 14 Mar 2023 10:18:09 +0000 Date: Tue, 14 Mar 2023 10:18:08 +0000 Message-ID: <86ilf3y6u7.wl-maz@kernel.org> From: Marc Zyngier To: Sean Christopherson Cc: Ricardo Koller , pbonzini@redhat.com, oupton@google.com, yuzenghui@huawei.com, dmatlack@google.com, kvm@vger.kernel.org, kvmarm@lists.linux.dev, qperret@google.com, catalin.marinas@arm.com, andrew.jones@linux.dev, alexandru.elisei@arm.com, suzuki.poulose@arm.com, eric.auger@redhat.com, gshan@redhat.com, reijiw@google.com, rananta@google.com, bgardon@google.com, ricarkol@gmail.com, Shaoqin Huang Subject: Re: [PATCH v6 07/12] KVM: arm64: Export kvm_are_all_memslots_empty() In-Reply-To: References: <20230307034555.39733-1-ricarkol@google.com> <20230307034555.39733-8-ricarkol@google.com> <878rg25hbq.wl-maz@kernel.org> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/28.2 (aarch64-unknown-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: seanjc@google.com, ricarkol@google.com, pbonzini@redhat.com, oupton@google.com, yuzenghui@huawei.com, dmatlack@google.com, kvm@vger.kernel.org, kvmarm@lists.linux.dev, qperret@google.com, catalin.marinas@arm.com, andrew.jones@linux.dev, alexandru.elisei@arm.com, suzuki.poulose@arm.com, eric.auger@redhat.com, gshan@redhat.com, reijiw@google.com, rananta@google.com, bgardon@google.com, ricarkol@gmail.com, shahuang@redhat.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On Mon, 13 Mar 2023 15:18:55 +0000, Sean Christopherson wrote: > > On Sun, Mar 12, 2023, Marc Zyngier wrote: > > On Tue, 07 Mar 2023 03:45:50 +0000, > > Ricardo Koller wrote: > > > No functional change intended. > > > > I wish people stopped adding this pointless sentence to commit > > messages. All changes have a functional change one way or another, > > unless you are only changing a comment. > > The implied context is that there is no change in runtime functionality, which > does hold true for many changes. I personally find the annotation helpful, both > for code review and when doing git archaeology. If a changelog states that the > author doesn't/didn't intend a functional change, then _any_ change in (runtime) > functionality becomes a red flag, and for me, prompts a closer look regardless of > whether or not I have other concerns with the patch/commit. And I think it lures the reviewer into a false sense of security. No intended change, must be fine. Except when it is not. More often than not, we end-up with seemingly innocent changes that break things. It is even worse when things get (for good or bad reasons) backported to -stable or an internal tree of some description. "No functional change" can become something very different in another context. How do you communicate this? Maybe I'll add a standard disclaimer to my own patches ("Here be dragons!"). M. -- Without deviation from the norm, progress is not possible.