From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A7A178BFB; Tue, 28 Mar 2023 15:42:44 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 573A7C4339C; Tue, 28 Mar 2023 15:42:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1680018164; bh=lFKB8KlOsjLpJE9IOHvF8y4b3kkppGWP231QD6wAv7M=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=dPuzTBE0hKJNYY6H+csW3AVkd95ZTIz8vyv4BE81fxd2cGP3Xos7oikGNbdUFFwwI xxUDig5Aaj8jej6EsoBvNhqgJnr9Dla9m3yb6olNVHxJDMbUp/ZGiC74tFOOLy9X3A OSAJ3il8piccGDhc59kxgqudVcQGpF0ldzGdZB08q7FVoHeZUA+p4MZVdvwUIOU+fT qSkWI6p6W3K0i4KBcZ08YQ4U7hqKPVXWINaiYNRIVsAhZp64fpyqztXmRJQ6WGoIg5 Ks1nkLJtI8FMeg53tEJfvAkiVBYgtQRqSj04BoBbLZgUD5kNQvpid+a1sj6QG+ma4G Pnnwb4bRShnCw== Received: from sofa.misterjones.org ([185.219.108.64] helo=goblin-girl.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1phBT7-003oy1-Vl; Tue, 28 Mar 2023 16:42:42 +0100 Date: Tue, 28 Mar 2023 16:42:41 +0100 Message-ID: <86mt3wx4pa.wl-maz@kernel.org> From: Marc Zyngier To: Will Deacon Cc: kernel test robot , llvm@lists.linux.dev, oe-kbuild-all@lists.linux.dev, Linux Memory Management List , Zaid Al-Bassam Subject: Re: [linux-next:master 6577/7309] drivers/perf/arm_pmuv3.c:44:2: error: use of undeclared identifier 'PERF_MAP_ALL_UNSUPPORTED' In-Reply-To: <20230328122138.GA1275@willie-the-truck> References: <202303281539.zzI4vpw1-lkp@intel.com> <20230328122138.GA1275@willie-the-truck> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/28.2 (aarch64-unknown-linux-gnu) MULE/6.0 (HANACHIRUSATO) Precedence: bulk X-Mailing-List: llvm@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: will@kernel.org, lkp@intel.com, llvm@lists.linux.dev, oe-kbuild-all@lists.linux.dev, linux-mm@kvack.org, zalbassam@google.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false On Tue, 28 Mar 2023 13:21:38 +0100, Will Deacon wrote: > > On Tue, Mar 28, 2023 at 04:01:49PM +0800, kernel test robot wrote: > > tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master > > head: a6faf7ea9fcb7267d06116d4188947f26e00e57e > > commit: 3b16f6268e660f15aed0bb97aefe87e893eb8882 [6577/7309] ARM: mach-virt: Select PMUv3 driver by default > > config: arm-randconfig-r024-20230326 (https://download.01.org/0day-ci/archive/20230328/202303281539.zzI4vpw1-lkp@intel.com/config) > > compiler: clang version 17.0.0 (https://github.com/llvm/llvm-project 67409911353323ca5edf2049ef0df54132fa1ca7) > > reproduce (this is a W=1 build): > > wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross > > chmod +x ~/bin/make.cross > > # install arm cross compiling tool for clang build > > # apt-get install binutils-arm-linux-gnueabi > > # https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=3b16f6268e660f15aed0bb97aefe87e893eb8882 > > git remote add linux-next https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git > > git fetch --no-tags linux-next master > > git checkout 3b16f6268e660f15aed0bb97aefe87e893eb8882 > > # save the config file > > mkdir build_dir && cp config build_dir/.config > > COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=arm olddefconfig > > COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=arm SHELL=/bin/bash drivers/perf/ > > > > If you fix the issue, kindly add following tag where applicable > > | Reported-by: kernel test robot > > | Link: https://lore.kernel.org/oe-kbuild-all/202303281539.zzI4vpw1-lkp@intel.com/ > > > > All errors (new ones prefixed by >>): > > > > >> drivers/perf/arm_pmuv3.c:44:2: error: use of undeclared identifier 'PERF_MAP_ALL_UNSUPPORTED' > > PERF_MAP_ALL_UNSUPPORTED, > > ^ > > >> drivers/perf/arm_pmuv3.c:59:2: error: use of undeclared identifier 'PERF_CACHE_MAP_ALL_UNSUPPORTED' > > PERF_CACHE_MAP_ALL_UNSUPPORTED, > > ^ > > I think the Kconfig warning is relevant here: > > > Kconfig warnings: (for reference only) > > WARNING: unmet direct dependencies detected for ARM_PMUV3 > > Depends on [n]: PERF_EVENTS [=y] && HW_PERF_EVENTS [=n] && (ARM [=y] && CPU_V7 [=y] || ARM64) > > Selected by [y]: > > - ARCH_VIRT [=y] && ARCH_MULTI_V7 [=y] && PERF_EVENTS [=y] > > Since we're selecting an option which has its own dependencies. I think > the easiest bet is to invert the linkage so that PMUV3 has a dependency > on ARCH_VIRT for 32-bit Arm (diff below). > > Marc, Zaid -- what do you think? As I said in another branch of the thread, I'd rather drop the ARCH_VIRT patch altogether. It is only of interest to the 3 people that care about it, most of which are already on Cc. Thanks, M. -- Without deviation from the norm, progress is not possible.