From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marc Zyngier Subject: Re: [PATCH v3 2/2] net: usb: asix88179_178a: de-duplicate code Date: Mon, 02 Apr 2018 10:45:40 +0100 Message-ID: <86woxqq6uz.wl-marc.zyngier@arm.com> References: <20180402074349.12010-1-akurz@blala.de> <20180402074349.12010-2-akurz@blala.de> Mime-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Cc: "David S . Miller" , "Andrew F . Davis" , , , Freddy Xin To: Alexander Kurz Return-path: Received: from foss.arm.com ([217.140.101.70]:48612 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754124AbeDBJpq (ORCPT ); Mon, 2 Apr 2018 05:45:46 -0400 In-Reply-To: <20180402074349.12010-2-akurz@blala.de> Sender: netdev-owner@vger.kernel.org List-ID: On Mon, 02 Apr 2018 08:43:49 +0100, Alexander Kurz wrote: Alexander, > > Remove the duplicated code for asix88179_178a bind and reset methods. > > Signed-off-by: Alexander Kurz > --- > drivers/net/usb/ax88179_178a.c | 137 ++++++++++------------------------------- > 1 file changed, 31 insertions(+), 106 deletions(-) What has changed between this patch and the previous one? Having a bit of a change-log would certainly help. Also, I would have appreciated a reply to the questions I had on v2 before you posted a third version. > > diff --git a/drivers/net/usb/ax88179_178a.c b/drivers/net/usb/ax88179_178a.c > index a6ef75907ae9..fea4c7b877cc 100644 > --- a/drivers/net/usb/ax88179_178a.c > +++ b/drivers/net/usb/ax88179_178a.c > @@ -1223,7 +1223,7 @@ static int ax88179_led_setting(struct usbnet *dev) > return 0; > } > > -static int ax88179_bind(struct usbnet *dev, struct usb_interface *intf) > +static int ax88179_bind_or_reset(struct usbnet *dev, bool do_reset) > { > u8 buf[5]; > u16 *tmp16; > @@ -1231,12 +1231,11 @@ static int ax88179_bind(struct usbnet *dev, struct usb_interface *intf) > struct ax88179_data *ax179_data = (struct ax88179_data *)dev->data; > struct ethtool_eee eee_data; > > - usbnet_get_endpoints(dev, intf); > - > tmp16 = (u16 *)buf; > tmp = (u8 *)buf; > > - memset(ax179_data, 0, sizeof(*ax179_data)); > + if (!do_reset) > + memset(ax179_data, 0, sizeof(*ax179_data)); > > /* Power up ethernet PHY */ > *tmp16 = 0; > @@ -1249,9 +1248,13 @@ static int ax88179_bind(struct usbnet *dev, struct usb_interface *intf) > ax88179_write_cmd(dev, AX_ACCESS_MAC, AX_CLK_SELECT, 1, 1, tmp); > msleep(100); > > + if (do_reset) > + ax88179_auto_detach(dev, 0); > + > ax88179_read_cmd(dev, AX_ACCESS_MAC, AX_NODE_ID, ETH_ALEN, > ETH_ALEN, dev->net->dev_addr); > - memcpy(dev->net->perm_addr, dev->net->dev_addr, ETH_ALEN); > + if (!do_reset) > + memcpy(dev->net->perm_addr, dev->net->dev_addr, ETH_ALEN); > > /* RX bulk configuration */ > memcpy(tmp, &AX88179_BULKIN_SIZE[0], 5); > @@ -1266,19 +1269,21 @@ static int ax88179_bind(struct usbnet *dev, struct usb_interface *intf) > ax88179_write_cmd(dev, AX_ACCESS_MAC, AX_PAUSE_WATERLVL_HIGH, > 1, 1, tmp); > > - dev->net->netdev_ops = &ax88179_netdev_ops; > - dev->net->ethtool_ops = &ax88179_ethtool_ops; > - dev->net->needed_headroom = 8; > - dev->net->max_mtu = 4088; > - > - /* Initialize MII structure */ > - dev->mii.dev = dev->net; > - dev->mii.mdio_read = ax88179_mdio_read; > - dev->mii.mdio_write = ax88179_mdio_write; > - dev->mii.phy_id_mask = 0xff; > - dev->mii.reg_num_mask = 0xff; > - dev->mii.phy_id = 0x03; > - dev->mii.supports_gmii = 1; > + if (!do_reset) { > + dev->net->netdev_ops = &ax88179_netdev_ops; > + dev->net->ethtool_ops = &ax88179_ethtool_ops; > + dev->net->needed_headroom = 8; > + dev->net->max_mtu = 4088; > + > + /* Initialize MII structure */ > + dev->mii.dev = dev->net; > + dev->mii.mdio_read = ax88179_mdio_read; > + dev->mii.mdio_write = ax88179_mdio_write; > + dev->mii.phy_id_mask = 0xff; > + dev->mii.reg_num_mask = 0xff; > + dev->mii.phy_id = 0x03; > + dev->mii.supports_gmii = 1; > + } > > dev->net->features |= NETIF_F_IP_CSUM | NETIF_F_IPV6_CSUM | > NETIF_F_RXCSUM; > @@ -1330,6 +1335,13 @@ static int ax88179_bind(struct usbnet *dev, struct usb_interface *intf) > return 0; > } > > +static int ax88179_bind(struct usbnet *dev, struct usb_interface *intf) > +{ > + usbnet_get_endpoints(dev, intf); > + > + return ax88179_bind_or_reset(dev, false); > +} > + > static void ax88179_unbind(struct usbnet *dev, struct usb_interface *intf) > { > u16 tmp16; > @@ -1530,94 +1542,7 @@ static int ax88179_link_reset(struct usbnet *dev) > > static int ax88179_reset(struct usbnet *dev) > { > - u8 buf[5]; > - u16 *tmp16; > - u8 *tmp; > - struct ax88179_data *ax179_data = (struct ax88179_data *)dev->data; > - struct ethtool_eee eee_data; > - > - tmp16 = (u16 *)buf; > - tmp = (u8 *)buf; > - > - /* Power up ethernet PHY */ > - *tmp16 = 0; > - ax88179_write_cmd(dev, AX_ACCESS_MAC, AX_PHYPWR_RSTCTL, 2, 2, tmp16); > - > - *tmp16 = AX_PHYPWR_RSTCTL_IPRL; > - ax88179_write_cmd(dev, AX_ACCESS_MAC, AX_PHYPWR_RSTCTL, 2, 2, tmp16); > - msleep(200); > - > - *tmp = AX_CLK_SELECT_ACS | AX_CLK_SELECT_BCS; > - ax88179_write_cmd(dev, AX_ACCESS_MAC, AX_CLK_SELECT, 1, 1, tmp); > - msleep(100); > - > - /* Ethernet PHY Auto Detach*/ > - ax88179_auto_detach(dev, 0); > - > - ax88179_read_cmd(dev, AX_ACCESS_MAC, AX_NODE_ID, ETH_ALEN, ETH_ALEN, > - dev->net->dev_addr); > - > - /* RX bulk configuration */ > - memcpy(tmp, &AX88179_BULKIN_SIZE[0], 5); > - ax88179_write_cmd(dev, AX_ACCESS_MAC, AX_RX_BULKIN_QCTRL, 5, 5, tmp); > - > - dev->rx_urb_size = 1024 * 20; > - > - *tmp = 0x34; > - ax88179_write_cmd(dev, AX_ACCESS_MAC, AX_PAUSE_WATERLVL_LOW, 1, 1, tmp); > - > - *tmp = 0x52; > - ax88179_write_cmd(dev, AX_ACCESS_MAC, AX_PAUSE_WATERLVL_HIGH, > - 1, 1, tmp); > - > - dev->net->features |= NETIF_F_IP_CSUM | NETIF_F_IPV6_CSUM | > - NETIF_F_RXCSUM; > - > - dev->net->hw_features |= NETIF_F_IP_CSUM | NETIF_F_IPV6_CSUM | > - NETIF_F_RXCSUM; > - > - /* Enable checksum offload */ > - *tmp = AX_RXCOE_IP | AX_RXCOE_TCP | AX_RXCOE_UDP | > - AX_RXCOE_TCPV6 | AX_RXCOE_UDPV6; > - ax88179_write_cmd(dev, AX_ACCESS_MAC, AX_RXCOE_CTL, 1, 1, tmp); > - > - *tmp = AX_TXCOE_IP | AX_TXCOE_TCP | AX_TXCOE_UDP | > - AX_TXCOE_TCPV6 | AX_TXCOE_UDPV6; > - ax88179_write_cmd(dev, AX_ACCESS_MAC, AX_TXCOE_CTL, 1, 1, tmp); > - > - /* Configure RX control register => start operation */ > - *tmp16 = AX_RX_CTL_DROPCRCERR | AX_RX_CTL_IPE | AX_RX_CTL_START | > - AX_RX_CTL_AP | AX_RX_CTL_AMALL | AX_RX_CTL_AB; > - ax88179_write_cmd(dev, AX_ACCESS_MAC, AX_RX_CTL, 2, 2, tmp16); > - > - *tmp = AX_MONITOR_MODE_PMETYPE | AX_MONITOR_MODE_PMEPOL | > - AX_MONITOR_MODE_RWMP; > - ax88179_write_cmd(dev, AX_ACCESS_MAC, AX_MONITOR_MOD, 1, 1, tmp); > - > - /* Configure default medium type => giga */ > - *tmp16 = AX_MEDIUM_RECEIVE_EN | AX_MEDIUM_TXFLOW_CTRLEN | > - AX_MEDIUM_RXFLOW_CTRLEN | AX_MEDIUM_FULL_DUPLEX | > - AX_MEDIUM_GIGAMODE; > - ax88179_write_cmd(dev, AX_ACCESS_MAC, AX_MEDIUM_STATUS_MODE, > - 2, 2, tmp16); > - > - ax88179_led_setting(dev); > - > - ax179_data->eee_enabled = 0; > - ax179_data->eee_active = 0; > - > - ax88179_disable_eee(dev); > - > - ax88179_ethtool_get_eee(dev, &eee_data); > - eee_data.advertised = 0; > - ax88179_ethtool_set_eee(dev, &eee_data); > - > - /* Restart autoneg */ > - mii_nway_restart(&dev->mii); > - > - usbnet_link_change(dev, 0, 0); > - > - return 0; > + return ax88179_bind_or_reset(dev, true); > } > > static int ax88179_stop(struct usbnet *dev) Overall, this patch makes much more sense than the previous one (I can actually see duplicated code being removed). I'll give it a go later today. Thanks, M. -- Jazz is not dead, it just smell funny. From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: [v3,2/2] net: usb: asix88179_178a: de-duplicate code From: Marc Zyngier Message-Id: <86woxqq6uz.wl-marc.zyngier@arm.com> Date: Mon, 02 Apr 2018 10:45:40 +0100 To: Alexander Kurz Cc: "David S . Miller" , "Andrew F . Davis" , linux-usb@vger.kernel.org, netdev@vger.kernel.org, Freddy Xin List-ID: T24gTW9uLCAwMiBBcHIgMjAxOCAwODo0Mzo0OSArMDEwMCwKQWxleGFuZGVyIEt1cnogd3JvdGU6 CgpBbGV4YW5kZXIsCgo+IAo+IFJlbW92ZSB0aGUgZHVwbGljYXRlZCBjb2RlIGZvciBhc2l4ODgx NzlfMTc4YSBiaW5kIGFuZCByZXNldCBtZXRob2RzLgo+IAo+IFNpZ25lZC1vZmYtYnk6IEFsZXhh bmRlciBLdXJ6IDxha3VyekBibGFsYS5kZT4KPiAtLS0KPiAgZHJpdmVycy9uZXQvdXNiL2F4ODgx NzlfMTc4YS5jIHwgMTM3ICsrKysrKysrKystLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t Cj4gIDEgZmlsZSBjaGFuZ2VkLCAzMSBpbnNlcnRpb25zKCspLCAxMDYgZGVsZXRpb25zKC0pCgpX aGF0IGhhcyBjaGFuZ2VkIGJldHdlZW4gdGhpcyBwYXRjaCBhbmQgdGhlIHByZXZpb3VzIG9uZT8g SGF2aW5nIGEgYml0Cm9mIGEgY2hhbmdlLWxvZyB3b3VsZCBjZXJ0YWlubHkgaGVscC4gQWxzbywg SSB3b3VsZCBoYXZlIGFwcHJlY2lhdGVkIGEKcmVwbHkgdG8gdGhlIHF1ZXN0aW9ucyBJIGhhZCBv biB2MiBiZWZvcmUgeW91IHBvc3RlZCBhIHRoaXJkIHZlcnNpb24uCgo+IAo+IGRpZmYgLS1naXQg YS9kcml2ZXJzL25ldC91c2IvYXg4ODE3OV8xNzhhLmMgYi9kcml2ZXJzL25ldC91c2IvYXg4ODE3 OV8xNzhhLmMKPiBpbmRleCBhNmVmNzU5MDdhZTkuLmZlYTRjN2I4NzdjYyAxMDA2NDQKPiAtLS0g YS9kcml2ZXJzL25ldC91c2IvYXg4ODE3OV8xNzhhLmMKPiArKysgYi9kcml2ZXJzL25ldC91c2Iv YXg4ODE3OV8xNzhhLmMKPiBAQCAtMTIyMyw3ICsxMjIzLDcgQEAgc3RhdGljIGludCBheDg4MTc5 X2xlZF9zZXR0aW5nKHN0cnVjdCB1c2JuZXQgKmRldikKPiAgCXJldHVybiAwOwo+ICB9Cj4gIAo+ IC1zdGF0aWMgaW50IGF4ODgxNzlfYmluZChzdHJ1Y3QgdXNibmV0ICpkZXYsIHN0cnVjdCB1c2Jf aW50ZXJmYWNlICppbnRmKQo+ICtzdGF0aWMgaW50IGF4ODgxNzlfYmluZF9vcl9yZXNldChzdHJ1 Y3QgdXNibmV0ICpkZXYsIGJvb2wgZG9fcmVzZXQpCj4gIHsKPiAgCXU4IGJ1Zls1XTsKPiAgCXUx NiAqdG1wMTY7Cj4gQEAgLTEyMzEsMTIgKzEyMzEsMTEgQEAgc3RhdGljIGludCBheDg4MTc5X2Jp bmQoc3RydWN0IHVzYm5ldCAqZGV2LCBzdHJ1Y3QgdXNiX2ludGVyZmFjZSAqaW50ZikKPiAgCXN0 cnVjdCBheDg4MTc5X2RhdGEgKmF4MTc5X2RhdGEgPSAoc3RydWN0IGF4ODgxNzlfZGF0YSAqKWRl di0+ZGF0YTsKPiAgCXN0cnVjdCBldGh0b29sX2VlZSBlZWVfZGF0YTsKPiAgCj4gLQl1c2JuZXRf Z2V0X2VuZHBvaW50cyhkZXYsIGludGYpOwo+IC0KPiAgCXRtcDE2ID0gKHUxNiAqKWJ1ZjsKPiAg CXRtcCA9ICh1OCAqKWJ1ZjsKPiAgCj4gLQltZW1zZXQoYXgxNzlfZGF0YSwgMCwgc2l6ZW9mKCph eDE3OV9kYXRhKSk7Cj4gKwlpZiAoIWRvX3Jlc2V0KQo+ICsJCW1lbXNldChheDE3OV9kYXRhLCAw LCBzaXplb2YoKmF4MTc5X2RhdGEpKTsKPiAgCj4gIAkvKiBQb3dlciB1cCBldGhlcm5ldCBQSFkg Ki8KPiAgCSp0bXAxNiA9IDA7Cj4gQEAgLTEyNDksOSArMTI0OCwxMyBAQCBzdGF0aWMgaW50IGF4 ODgxNzlfYmluZChzdHJ1Y3QgdXNibmV0ICpkZXYsIHN0cnVjdCB1c2JfaW50ZXJmYWNlICppbnRm KQo+ICAJYXg4ODE3OV93cml0ZV9jbWQoZGV2LCBBWF9BQ0NFU1NfTUFDLCBBWF9DTEtfU0VMRUNU LCAxLCAxLCB0bXApOwo+ICAJbXNsZWVwKDEwMCk7Cj4gIAo+ICsJaWYgKGRvX3Jlc2V0KQo+ICsJ CWF4ODgxNzlfYXV0b19kZXRhY2goZGV2LCAwKTsKPiArCj4gIAlheDg4MTc5X3JlYWRfY21kKGRl diwgQVhfQUNDRVNTX01BQywgQVhfTk9ERV9JRCwgRVRIX0FMRU4sCj4gIAkJCSBFVEhfQUxFTiwg ZGV2LT5uZXQtPmRldl9hZGRyKTsKPiAtCW1lbWNweShkZXYtPm5ldC0+cGVybV9hZGRyLCBkZXYt Pm5ldC0+ZGV2X2FkZHIsIEVUSF9BTEVOKTsKPiArCWlmICghZG9fcmVzZXQpCj4gKwkJbWVtY3B5 KGRldi0+bmV0LT5wZXJtX2FkZHIsIGRldi0+bmV0LT5kZXZfYWRkciwgRVRIX0FMRU4pOwo+ICAK PiAgCS8qIFJYIGJ1bGsgY29uZmlndXJhdGlvbiAqLwo+ICAJbWVtY3B5KHRtcCwgJkFYODgxNzlf QlVMS0lOX1NJWkVbMF0sIDUpOwo+IEBAIC0xMjY2LDE5ICsxMjY5LDIxIEBAIHN0YXRpYyBpbnQg YXg4ODE3OV9iaW5kKHN0cnVjdCB1c2JuZXQgKmRldiwgc3RydWN0IHVzYl9pbnRlcmZhY2UgKmlu dGYpCj4gIAlheDg4MTc5X3dyaXRlX2NtZChkZXYsIEFYX0FDQ0VTU19NQUMsIEFYX1BBVVNFX1dB VEVSTFZMX0hJR0gsCj4gIAkJCSAgMSwgMSwgdG1wKTsKPiAgCj4gLQlkZXYtPm5ldC0+bmV0ZGV2 X29wcyA9ICZheDg4MTc5X25ldGRldl9vcHM7Cj4gLQlkZXYtPm5ldC0+ZXRodG9vbF9vcHMgPSAm YXg4ODE3OV9ldGh0b29sX29wczsKPiAtCWRldi0+bmV0LT5uZWVkZWRfaGVhZHJvb20gPSA4Owo+ IC0JZGV2LT5uZXQtPm1heF9tdHUgPSA0MDg4Owo+IC0KPiAtCS8qIEluaXRpYWxpemUgTUlJIHN0 cnVjdHVyZSAqLwo+IC0JZGV2LT5taWkuZGV2ID0gZGV2LT5uZXQ7Cj4gLQlkZXYtPm1paS5tZGlv X3JlYWQgPSBheDg4MTc5X21kaW9fcmVhZDsKPiAtCWRldi0+bWlpLm1kaW9fd3JpdGUgPSBheDg4 MTc5X21kaW9fd3JpdGU7Cj4gLQlkZXYtPm1paS5waHlfaWRfbWFzayA9IDB4ZmY7Cj4gLQlkZXYt Pm1paS5yZWdfbnVtX21hc2sgPSAweGZmOwo+IC0JZGV2LT5taWkucGh5X2lkID0gMHgwMzsKPiAt CWRldi0+bWlpLnN1cHBvcnRzX2dtaWkgPSAxOwo+ICsJaWYgKCFkb19yZXNldCkgewo+ICsJCWRl di0+bmV0LT5uZXRkZXZfb3BzID0gJmF4ODgxNzlfbmV0ZGV2X29wczsKPiArCQlkZXYtPm5ldC0+ ZXRodG9vbF9vcHMgPSAmYXg4ODE3OV9ldGh0b29sX29wczsKPiArCQlkZXYtPm5ldC0+bmVlZGVk X2hlYWRyb29tID0gODsKPiArCQlkZXYtPm5ldC0+bWF4X210dSA9IDQwODg7Cj4gKwo+ICsJCS8q IEluaXRpYWxpemUgTUlJIHN0cnVjdHVyZSAqLwo+ICsJCWRldi0+bWlpLmRldiA9IGRldi0+bmV0 Owo+ICsJCWRldi0+bWlpLm1kaW9fcmVhZCA9IGF4ODgxNzlfbWRpb19yZWFkOwo+ICsJCWRldi0+ bWlpLm1kaW9fd3JpdGUgPSBheDg4MTc5X21kaW9fd3JpdGU7Cj4gKwkJZGV2LT5taWkucGh5X2lk X21hc2sgPSAweGZmOwo+ICsJCWRldi0+bWlpLnJlZ19udW1fbWFzayA9IDB4ZmY7Cj4gKwkJZGV2 LT5taWkucGh5X2lkID0gMHgwMzsKPiArCQlkZXYtPm1paS5zdXBwb3J0c19nbWlpID0gMTsKPiAr CX0KPiAgCj4gIAlkZXYtPm5ldC0+ZmVhdHVyZXMgfD0gTkVUSUZfRl9JUF9DU1VNIHwgTkVUSUZf Rl9JUFY2X0NTVU0gfAo+ICAJCQkgICAgICBORVRJRl9GX1JYQ1NVTTsKPiBAQCAtMTMzMCw2ICsx MzM1LDEzIEBAIHN0YXRpYyBpbnQgYXg4ODE3OV9iaW5kKHN0cnVjdCB1c2JuZXQgKmRldiwgc3Ry dWN0IHVzYl9pbnRlcmZhY2UgKmludGYpCj4gIAlyZXR1cm4gMDsKPiAgfQo+ICAKPiArc3RhdGlj IGludCBheDg4MTc5X2JpbmQoc3RydWN0IHVzYm5ldCAqZGV2LCBzdHJ1Y3QgdXNiX2ludGVyZmFj ZSAqaW50ZikKPiArewo+ICsJdXNibmV0X2dldF9lbmRwb2ludHMoZGV2LCBpbnRmKTsKPiArCj4g KwlyZXR1cm4gYXg4ODE3OV9iaW5kX29yX3Jlc2V0KGRldiwgZmFsc2UpOwo+ICt9Cj4gKwo+ICBz dGF0aWMgdm9pZCBheDg4MTc5X3VuYmluZChzdHJ1Y3QgdXNibmV0ICpkZXYsIHN0cnVjdCB1c2Jf aW50ZXJmYWNlICppbnRmKQo+ICB7Cj4gIAl1MTYgdG1wMTY7Cj4gQEAgLTE1MzAsOTQgKzE1NDIs NyBAQCBzdGF0aWMgaW50IGF4ODgxNzlfbGlua19yZXNldChzdHJ1Y3QgdXNibmV0ICpkZXYpCj4g IAo+ICBzdGF0aWMgaW50IGF4ODgxNzlfcmVzZXQoc3RydWN0IHVzYm5ldCAqZGV2KQo+ICB7Cj4g LQl1OCBidWZbNV07Cj4gLQl1MTYgKnRtcDE2Owo+IC0JdTggKnRtcDsKPiAtCXN0cnVjdCBheDg4 MTc5X2RhdGEgKmF4MTc5X2RhdGEgPSAoc3RydWN0IGF4ODgxNzlfZGF0YSAqKWRldi0+ZGF0YTsK PiAtCXN0cnVjdCBldGh0b29sX2VlZSBlZWVfZGF0YTsKPiAtCj4gLQl0bXAxNiA9ICh1MTYgKili dWY7Cj4gLQl0bXAgPSAodTggKilidWY7Cj4gLQo+IC0JLyogUG93ZXIgdXAgZXRoZXJuZXQgUEhZ ICovCj4gLQkqdG1wMTYgPSAwOwo+IC0JYXg4ODE3OV93cml0ZV9jbWQoZGV2LCBBWF9BQ0NFU1Nf TUFDLCBBWF9QSFlQV1JfUlNUQ1RMLCAyLCAyLCB0bXAxNik7Cj4gLQo+IC0JKnRtcDE2ID0gQVhf UEhZUFdSX1JTVENUTF9JUFJMOwo+IC0JYXg4ODE3OV93cml0ZV9jbWQoZGV2LCBBWF9BQ0NFU1Nf TUFDLCBBWF9QSFlQV1JfUlNUQ1RMLCAyLCAyLCB0bXAxNik7Cj4gLQltc2xlZXAoMjAwKTsKPiAt Cj4gLQkqdG1wID0gQVhfQ0xLX1NFTEVDVF9BQ1MgfCBBWF9DTEtfU0VMRUNUX0JDUzsKPiAtCWF4 ODgxNzlfd3JpdGVfY21kKGRldiwgQVhfQUNDRVNTX01BQywgQVhfQ0xLX1NFTEVDVCwgMSwgMSwg dG1wKTsKPiAtCW1zbGVlcCgxMDApOwo+IC0KPiAtCS8qIEV0aGVybmV0IFBIWSBBdXRvIERldGFj aCovCj4gLQlheDg4MTc5X2F1dG9fZGV0YWNoKGRldiwgMCk7Cj4gLQo+IC0JYXg4ODE3OV9yZWFk X2NtZChkZXYsIEFYX0FDQ0VTU19NQUMsIEFYX05PREVfSUQsIEVUSF9BTEVOLCBFVEhfQUxFTiwK PiAtCQkJIGRldi0+bmV0LT5kZXZfYWRkcik7Cj4gLQo+IC0JLyogUlggYnVsayBjb25maWd1cmF0 aW9uICovCj4gLQltZW1jcHkodG1wLCAmQVg4ODE3OV9CVUxLSU5fU0laRVswXSwgNSk7Cj4gLQlh eDg4MTc5X3dyaXRlX2NtZChkZXYsIEFYX0FDQ0VTU19NQUMsIEFYX1JYX0JVTEtJTl9RQ1RSTCwg NSwgNSwgdG1wKTsKPiAtCj4gLQlkZXYtPnJ4X3VyYl9zaXplID0gMTAyNCAqIDIwOwo+IC0KPiAt CSp0bXAgPSAweDM0Owo+IC0JYXg4ODE3OV93cml0ZV9jbWQoZGV2LCBBWF9BQ0NFU1NfTUFDLCBB WF9QQVVTRV9XQVRFUkxWTF9MT1csIDEsIDEsIHRtcCk7Cj4gLQo+IC0JKnRtcCA9IDB4NTI7Cj4g LQlheDg4MTc5X3dyaXRlX2NtZChkZXYsIEFYX0FDQ0VTU19NQUMsIEFYX1BBVVNFX1dBVEVSTFZM X0hJR0gsCj4gLQkJCSAgMSwgMSwgdG1wKTsKPiAtCj4gLQlkZXYtPm5ldC0+ZmVhdHVyZXMgfD0g TkVUSUZfRl9JUF9DU1VNIHwgTkVUSUZfRl9JUFY2X0NTVU0gfAo+IC0JCQkgICAgICBORVRJRl9G X1JYQ1NVTTsKPiAtCj4gLQlkZXYtPm5ldC0+aHdfZmVhdHVyZXMgfD0gTkVUSUZfRl9JUF9DU1VN IHwgTkVUSUZfRl9JUFY2X0NTVU0gfAo+IC0JCQkJIE5FVElGX0ZfUlhDU1VNOwo+IC0KPiAtCS8q IEVuYWJsZSBjaGVja3N1bSBvZmZsb2FkICovCj4gLQkqdG1wID0gQVhfUlhDT0VfSVAgfCBBWF9S WENPRV9UQ1AgfCBBWF9SWENPRV9VRFAgfAo+IC0JICAgICAgIEFYX1JYQ09FX1RDUFY2IHwgQVhf UlhDT0VfVURQVjY7Cj4gLQlheDg4MTc5X3dyaXRlX2NtZChkZXYsIEFYX0FDQ0VTU19NQUMsIEFY X1JYQ09FX0NUTCwgMSwgMSwgdG1wKTsKPiAtCj4gLQkqdG1wID0gQVhfVFhDT0VfSVAgfCBBWF9U WENPRV9UQ1AgfCBBWF9UWENPRV9VRFAgfAo+IC0JICAgICAgIEFYX1RYQ09FX1RDUFY2IHwgQVhf VFhDT0VfVURQVjY7Cj4gLQlheDg4MTc5X3dyaXRlX2NtZChkZXYsIEFYX0FDQ0VTU19NQUMsIEFY X1RYQ09FX0NUTCwgMSwgMSwgdG1wKTsKPiAtCj4gLQkvKiBDb25maWd1cmUgUlggY29udHJvbCBy ZWdpc3RlciA9PiBzdGFydCBvcGVyYXRpb24gKi8KPiAtCSp0bXAxNiA9IEFYX1JYX0NUTF9EUk9Q Q1JDRVJSIHwgQVhfUlhfQ1RMX0lQRSB8IEFYX1JYX0NUTF9TVEFSVCB8Cj4gLQkJIEFYX1JYX0NU TF9BUCB8IEFYX1JYX0NUTF9BTUFMTCB8IEFYX1JYX0NUTF9BQjsKPiAtCWF4ODgxNzlfd3JpdGVf Y21kKGRldiwgQVhfQUNDRVNTX01BQywgQVhfUlhfQ1RMLCAyLCAyLCB0bXAxNik7Cj4gLQo+IC0J KnRtcCA9IEFYX01PTklUT1JfTU9ERV9QTUVUWVBFIHwgQVhfTU9OSVRPUl9NT0RFX1BNRVBPTCB8 Cj4gLQkgICAgICAgQVhfTU9OSVRPUl9NT0RFX1JXTVA7Cj4gLQlheDg4MTc5X3dyaXRlX2NtZChk ZXYsIEFYX0FDQ0VTU19NQUMsIEFYX01PTklUT1JfTU9ELCAxLCAxLCB0bXApOwo+IC0KPiAtCS8q IENvbmZpZ3VyZSBkZWZhdWx0IG1lZGl1bSB0eXBlID0+IGdpZ2EgKi8KPiAtCSp0bXAxNiA9IEFY X01FRElVTV9SRUNFSVZFX0VOIHwgQVhfTUVESVVNX1RYRkxPV19DVFJMRU4gfAo+IC0JCSBBWF9N RURJVU1fUlhGTE9XX0NUUkxFTiB8IEFYX01FRElVTV9GVUxMX0RVUExFWCB8Cj4gLQkJIEFYX01F RElVTV9HSUdBTU9ERTsKPiAtCWF4ODgxNzlfd3JpdGVfY21kKGRldiwgQVhfQUNDRVNTX01BQywg QVhfTUVESVVNX1NUQVRVU19NT0RFLAo+IC0JCQkgIDIsIDIsIHRtcDE2KTsKPiAtCj4gLQlheDg4 MTc5X2xlZF9zZXR0aW5nKGRldik7Cj4gLQo+IC0JYXgxNzlfZGF0YS0+ZWVlX2VuYWJsZWQgPSAw Owo+IC0JYXgxNzlfZGF0YS0+ZWVlX2FjdGl2ZSA9IDA7Cj4gLQo+IC0JYXg4ODE3OV9kaXNhYmxl X2VlZShkZXYpOwo+IC0KPiAtCWF4ODgxNzlfZXRodG9vbF9nZXRfZWVlKGRldiwgJmVlZV9kYXRh KTsKPiAtCWVlZV9kYXRhLmFkdmVydGlzZWQgPSAwOwo+IC0JYXg4ODE3OV9ldGh0b29sX3NldF9l ZWUoZGV2LCAmZWVlX2RhdGEpOwo+IC0KPiAtCS8qIFJlc3RhcnQgYXV0b25lZyAqLwo+IC0JbWlp X253YXlfcmVzdGFydCgmZGV2LT5taWkpOwo+IC0KPiAtCXVzYm5ldF9saW5rX2NoYW5nZShkZXYs IDAsIDApOwo+IC0KPiAtCXJldHVybiAwOwo+ICsJcmV0dXJuIGF4ODgxNzlfYmluZF9vcl9yZXNl dChkZXYsIHRydWUpOwo+ICB9Cj4gIAo+ICBzdGF0aWMgaW50IGF4ODgxNzlfc3RvcChzdHJ1Y3Qg dXNibmV0ICpkZXYpCgpPdmVyYWxsLCB0aGlzIHBhdGNoIG1ha2VzIG11Y2ggbW9yZSBzZW5zZSB0 aGFuIHRoZSBwcmV2aW91cyBvbmUgKEkgY2FuCmFjdHVhbGx5IHNlZSBkdXBsaWNhdGVkIGNvZGUg YmVpbmcgcmVtb3ZlZCkuIEknbGwgZ2l2ZSBpdCBhIGdvIGxhdGVyCnRvZGF5LgoKVGhhbmtzLAoK CU0uCg==