From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752867AbdGFDin (ORCPT ); Wed, 5 Jul 2017 23:38:43 -0400 Received: from home.keithp.com ([63.227.221.253]:49988 "EHLO elaine.keithp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752315AbdGFDim (ORCPT ); Wed, 5 Jul 2017 23:38:42 -0400 From: Keith Packard To: Dave Airlie Cc: LKML , Dave Airlie , Daniel Vetter , dri-devel Subject: Re: [PATCH 6/6] drm: Add four ioctls for managing drm mode object leases [v3] In-Reply-To: References: <20170705222406.28124-1-keithp@keithp.com> <20170705222406.28124-7-keithp@keithp.com> Date: Wed, 05 Jul 2017 20:38:40 -0700 Message-ID: <86wp7mtetb.fsf@keithp.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Dave Airlie writes: > I think this needs a pad ^. > And this. Yup. Thanks! >> +struct drm_mode_revoke_lease { >> + /** Unique ID of lessee >> + */ >> + __u32 lessee_id; > > And this. None of the other bare 32-bit ioctl structures are padded; I think that's probably fine as they'll be 4 bytes on both 64-bit and 32-bit machines. =2D-=20 =2Dkeith --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEw4O3eCVWE9/bQJ2R2yIaaQAAABEFAlldsMAACgkQ2yIaaQAA ABGRnQ//enZDaB9zE4D4Ow7kyxzxGTrqdHti5H0rZkrAV2yTvkV1C3mShVT/X5i1 4jjKR/lmfpo4nE9L79D5VabTZp+KqZGFcVopkLv9XU4NqOGrom5r0auJVs9aGZrg XU6CxTeFN1zjBpPC+nf6/vjydSR+Yj9u8+flcsm0MEQA+ADsEIx1NK8EYK7v4+Me 2WHxaPw/gJjUYZic47Fhx7es4EpBUVYx3FBQC24go3ZCffgwEXpu8awLl1CZt2B5 TwHnxF7K+c+PrOZsiLiTqWK5s+C7jqZfzH83M4DPGXoB/Mf7H2WNzZyoqezwUz8/ w1mxgxVRg/NQX+xHOR5pNodmg48+KJcOW1tExKJ+XUQvB6eph4A3ayOzaHlE83Z2 HVbcyd9TDK7Es7ZH972nIflr6AhPgb4SZtHnfobZC9zO8JEyC56j+kIuVKSBRVhx v+BsLYkdV4N4lqNz+qea11lVJxz6ulDrqbFL50v3MkQ8XWdaW2GUncxJwGsjHB9o wMMp9LaJPwynOY4tZA5a/mcthwnQ1+ytiJVSDRrOE4M++hP9k19nPPqHl9N9YMUT IY/KkGgOYk562XkbZbMCitpLA7CnVFYsgVPL2lD9GULpUP880QXleSNpJEzl1bFn W4lgXqZ2uipDmq6jB9EYr5syHMcQzMiSDx18cSPvWaNHFR8sOD8= =H+Sg -----END PGP SIGNATURE----- --=-=-=-- From mboxrd@z Thu Jan 1 00:00:00 1970 From: Keith Packard Subject: Re: [PATCH 6/6] drm: Add four ioctls for managing drm mode object leases [v3] Date: Wed, 05 Jul 2017 20:38:40 -0700 Message-ID: <86wp7mtetb.fsf@keithp.com> References: <20170705222406.28124-1-keithp@keithp.com> <20170705222406.28124-7-keithp@keithp.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1442072129==" Return-path: Received: from elaine.keithp.com (home.keithp.com [63.227.221.253]) by gabe.freedesktop.org (Postfix) with ESMTP id D5D0E6E578 for ; Thu, 6 Jul 2017 03:38:41 +0000 (UTC) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Dave Airlie Cc: Dave Airlie , dri-devel , LKML List-Id: dri-devel@lists.freedesktop.org --===============1442072129== Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Dave Airlie writes: > I think this needs a pad ^. > And this. Yup. Thanks! >> +struct drm_mode_revoke_lease { >> + /** Unique ID of lessee >> + */ >> + __u32 lessee_id; > > And this. None of the other bare 32-bit ioctl structures are padded; I think that's probably fine as they'll be 4 bytes on both 64-bit and 32-bit machines. =2D-=20 =2Dkeith --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEw4O3eCVWE9/bQJ2R2yIaaQAAABEFAlldsMAACgkQ2yIaaQAA ABGRnQ//enZDaB9zE4D4Ow7kyxzxGTrqdHti5H0rZkrAV2yTvkV1C3mShVT/X5i1 4jjKR/lmfpo4nE9L79D5VabTZp+KqZGFcVopkLv9XU4NqOGrom5r0auJVs9aGZrg XU6CxTeFN1zjBpPC+nf6/vjydSR+Yj9u8+flcsm0MEQA+ADsEIx1NK8EYK7v4+Me 2WHxaPw/gJjUYZic47Fhx7es4EpBUVYx3FBQC24go3ZCffgwEXpu8awLl1CZt2B5 TwHnxF7K+c+PrOZsiLiTqWK5s+C7jqZfzH83M4DPGXoB/Mf7H2WNzZyoqezwUz8/ w1mxgxVRg/NQX+xHOR5pNodmg48+KJcOW1tExKJ+XUQvB6eph4A3ayOzaHlE83Z2 HVbcyd9TDK7Es7ZH972nIflr6AhPgb4SZtHnfobZC9zO8JEyC56j+kIuVKSBRVhx v+BsLYkdV4N4lqNz+qea11lVJxz6ulDrqbFL50v3MkQ8XWdaW2GUncxJwGsjHB9o wMMp9LaJPwynOY4tZA5a/mcthwnQ1+ytiJVSDRrOE4M++hP9k19nPPqHl9N9YMUT IY/KkGgOYk562XkbZbMCitpLA7CnVFYsgVPL2lD9GULpUP880QXleSNpJEzl1bFn W4lgXqZ2uipDmq6jB9EYr5syHMcQzMiSDx18cSPvWaNHFR8sOD8= =H+Sg -----END PGP SIGNATURE----- --=-=-=-- --===============1442072129== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg== --===============1442072129==--