On Mon, 9 Jan 2012 21:17:17 +0800, Wu Fengguang <fengguang.wu@intel.com> wrote:

> +#define IBX_AUD_CONFIG_A		0xe2000
> +#define CPT_AUD_CONFIG_A		0xe5000

These register addresses match the docs.

> +		I915_WRITE(aud_config, 1 << 29); /* N value index, 0x1 = DP */

Please don't use constants here, instead add #defines for all of the
bits in this new register, in case someone else needs to use the
register later.

Do we also need to program the pixel clock values in this register?

-- 
keith.packard@intel.com