From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?UTF-8?Q?Noralf_Tr=c3=b8nnes?= Subject: Re: [PATCH v5 08/11] drm/fb-helper: Remove drm_fb_helper_connector Date: Thu, 16 May 2019 15:53:07 +0200 Message-ID: <8701457d-7240-cc5f-2370-ca4aea5efd1c@tronnes.org> References: <20190506180139.6913-1-noralf@tronnes.org> <20190506180139.6913-9-noralf@tronnes.org> <20190516130732.GA12435@ravnborg.org> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20190516130732.GA12435@ravnborg.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Sam Ravnborg Cc: intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org CgpEZW4gMTYuMDUuMjAxOSAxNS4wNywgc2tyZXYgU2FtIFJhdm5ib3JnOgo+IEhpIE5vcmFsZi4K PiAKPiBTZWUgZmV3IGNvbW1lbnRzIGluIHRoZSBmb2xsb3dpbmcuCj4gCj4gCVNhbQo+IAo+IE9u IE1vbiwgTWF5IDA2LCAyMDE5IGF0IDA4OjAxOjM2UE0gKzAyMDAsIE5vcmFsZiBUcsO4bm5lcyB3 cm90ZToKPj4gQWxsIGRyaXZlcnMgYWRkIGFsbCB0aGVpciBjb25uZWN0b3JzIHNvIHRoZXJlJ3Mg bm8gbmVlZCB0byBrZWVwIGFyb3VuZCBhbgo+PiBhcnJheSBvZiBhdmFpbGFibGUgY29ubmVjdG9y cy4KCkkgY291bGQgZXhwYW5kIG9uIHRoaXMgdGV4dCBhIGxpdHRsZToKCkFsbCBkcml2ZXJzIGFk ZCBhbGwgdGhlaXIgY29ubmVjdG9ycyBzbyB0aGVyZSdzIG5vIG5lZWQgdG8ga2VlcCBhcm91bmQg YW4KYXJyYXkgb2YgYXZhaWxhYmxlIGNvbm5lY3RvcnMuIEluc3RlYWQgd2UganVzdCBwdXQgdGhl IHVzZWFibGUgKG5vdAp3cml0ZWJhY2spIGNvbm5lY3RvcnMgaW4gYSB0ZW1wb3JhcnkgYXJyYXkg dXNpbmcKZHJtX2NsaWVudF9mb3JfZWFjaF9jb25uZWN0b3JfaXRlcigpIGV2ZXJ5dGltZSB3ZSBw cm9iZSB0aGUgb3V0cHV0cy4KT3RoZXIgcGxhY2VzIHdoZXJlIGl0J3MgbmVjZXNzYXJ5IHRvIGxv b2sgYXQgdGhlIGNvbm5lY3RvcnMsIHdlIGp1c3QKaXRlcmF0ZSBvdmVyIHRoZW0gdXNpbmcgdGhl IHNhbWUgaXRlcmF0b3IgZnVuY3Rpb24uCgo+Pgo+PiBSZW5hbWUgZnVuY3Rpb25zIHdoaWNoIHNp Z25hdHVyZSBpcyBjaGFuZ2VkIHNpbmNlIHRoZXkgd2lsbCBiZSBtb3ZlZCB0bwo+PiBkcm1fY2xp ZW50IGluIGEgbGF0ZXIgcGF0Y2guCj4+Cj4+IFNpZ25lZC1vZmYtYnk6IE5vcmFsZiBUcsO4bm5l cyA8bm9yYWxmQHRyb25uZXMub3JnPgo+PiAtLS0KPj4gQEAgLTE2NDUsOCArMTQ2MSw5IEBAIHN0 YXRpYyBpbnQgZHJtX2ZiX2hlbHBlcl9zaW5nbGVfZmJfcHJvYmUoc3RydWN0IGRybV9mYl9oZWxw ZXIgKmZiX2hlbHBlciwKPj4gIAlzdHJ1Y3QgZHJtX2NsaWVudF9kZXYgKmNsaWVudCA9ICZmYl9o ZWxwZXItPmNsaWVudDsKPj4gIAlpbnQgcmV0ID0gMDsKPj4gIAlpbnQgY3J0Y19jb3VudCA9IDA7 Cj4+IC0JaW50IGk7Cj4+ICsJc3RydWN0IGRybV9jb25uZWN0b3JfbGlzdF9pdGVyIGNvbm5faXRl cjsKPj4gIAlzdHJ1Y3QgZHJtX2ZiX2hlbHBlcl9zdXJmYWNlX3NpemUgc2l6ZXM7Cj4+ICsJc3Ry dWN0IGRybV9jb25uZWN0b3IgKmNvbm5lY3RvcjsKPj4gIAlzdHJ1Y3QgZHJtX21vZGVfc2V0ICpt b2RlX3NldDsKPj4gIAlpbnQgYmVzdF9kZXB0aCA9IDA7Cj4+ICAKPj4gQEAgLTE2NjMsMTEgKzE0 ODAsMTEgQEAgc3RhdGljIGludCBkcm1fZmJfaGVscGVyX3NpbmdsZV9mYl9wcm9iZShzdHJ1Y3Qg ZHJtX2ZiX2hlbHBlciAqZmJfaGVscGVyLAo+PiAgCWlmIChwcmVmZXJyZWRfYnBwICE9IHNpemVz LnN1cmZhY2VfYnBwKQo+PiAgCQlzaXplcy5zdXJmYWNlX2RlcHRoID0gc2l6ZXMuc3VyZmFjZV9i cHAgPSBwcmVmZXJyZWRfYnBwOwo+PiAgCj4+IC0JZHJtX2ZiX2hlbHBlcl9mb3JfZWFjaF9jb25u ZWN0b3IoZmJfaGVscGVyLCBpKSB7Cj4+IC0JCXN0cnVjdCBkcm1fZmJfaGVscGVyX2Nvbm5lY3Rv ciAqZmJfaGVscGVyX2Nvbm4gPSBmYl9oZWxwZXItPmNvbm5lY3Rvcl9pbmZvW2ldOwo+PiArCWRy bV9jb25uZWN0b3JfbGlzdF9pdGVyX2JlZ2luKGZiX2hlbHBlci0+ZGV2LCAmY29ubl9pdGVyKTsK Pj4gKwlkcm1fY2xpZW50X2Zvcl9lYWNoX2Nvbm5lY3Rvcl9pdGVyKGNvbm5lY3RvciwgJmNvbm5f aXRlcikgewo+PiAgCQlzdHJ1Y3QgZHJtX2NtZGxpbmVfbW9kZSAqY21kbGluZV9tb2RlOwo+IAo+ IEkgZmFpbCB0byBzZWUgd2hlbiB0byB1c2UgZHJtX2NsaWVudF9mb3JfZWFjaF9jb25uZWN0b3Jf aXRlcigpIGFuZCB3aGVuCj4gdG8gdXNlIGEgc2ltcGxlIGZvciBsb29wLgo+IEluIHRoaXMgcGF0 Y2ggZHJtX2ZiX2hlbHBlcl9mb3JfZWFjaF9jb25uZWN0b3IoKSBpcyBoZXJlIHJlcGxhY2VkIGJ5 IHRoZQo+IGl0ZXJhdG9yIHZhcmlhbnQgYW5kIGluIG1hbnkgb3RoZXIgcGxhY2VkIGEgc2ltcGxl IGZvciBsb29wLgo+IAoKV2hlbiBJIHVzZSBhIGZvciBsb29wIGl0J3MgaW4gdGhlICdwcm9iZSBm b3Igb3V0cHV0cycgcGF0aCB3aGVyZSB3ZSBhcmUKb3BlcmF0aW5nIG9uIGEgdGVtcG9yYXJ5IGNv bm5lY3RvciBhcnJheSB0aGF0IGlzIGNyZWF0ZWQgaW4KZHJtX3NldHVwX2NydGNzKCkuCgo+IFRo ZSBvbGQgY29kZSwgaW4gdGhpcyBwbGFjZSwgd291bGQgZ28gdGhyb3VnaCBhbGwgY29ubmVjdG9y cywgYnV0IHRoaXMKPiBjb2RlIHdpbGwgc2tpcCAJRFJNX01PREVfQ09OTkVDVE9SX1dSSVRFQkFD SyBjb25lY3RvcnMuCj4gU28gaXQgZG9lcyBub3QgbGlrZSBpZGVudGljYWwgY29kZS4KPiAKCklm IHlvdSBsb29rIGF0IHRoZSByZW1vdmVkIGRybV9mYl9oZWxwZXJfc2luZ2xlX2FkZF9hbGxfY29u bmVjdG9ycygpCnlvdSdsbCBzZWUgdGhhdCBpdCBza2lwcyB3cml0ZWJhY2sgY29ubmVjdG9ycy4K Cj4+ICAKPj4gLQkJY21kbGluZV9tb2RlID0gJmZiX2hlbHBlcl9jb25uLT5jb25uZWN0b3ItPmNt ZGxpbmVfbW9kZTsKPj4gKwkJY21kbGluZV9tb2RlID0gJmNvbm5lY3Rvci0+Y21kbGluZV9tb2Rl Owo+PiAgCj4+ICAJCWlmIChjbWRsaW5lX21vZGUtPmJwcF9zcGVjaWZpZWQpIHsKPj4gIAkJCXN3 aXRjaCAoY21kbGluZV9tb2RlLT5icHApIHsKPj4gQEAgLTE2OTIsNiArMTUwOSw3IEBAIHN0YXRp YyBpbnQgZHJtX2ZiX2hlbHBlcl9zaW5nbGVfZmJfcHJvYmUoc3RydWN0IGRybV9mYl9oZWxwZXIg KmZiX2hlbHBlciwKPj4gIAkJCWJyZWFrOwo+PiAgCQl9Cj4+ICAJfQo+PiArCWRybV9jb25uZWN0 b3JfbGlzdF9pdGVyX2VuZCgmY29ubl9pdGVyKTsKPj4gIAo+PiAgCS8qCj4+ICAJICogSWYgd2Ug cnVuIGludG8gYSBzaXR1YXRpb24gd2hlcmUsIGZvciBleGFtcGxlLCB0aGUgcHJpbWFyeSBwbGFu ZQo+PiBAQCAtMTg3NiwyNiArMTY5NCwxMiBAQCB2b2lkIGRybV9mYl9oZWxwZXJfZmlsbF9pbmZv KHN0cnVjdCBmYl9pbmZvICppbmZvLAo+PiAgfQo+PiAgRVhQT1JUX1NZTUJPTChkcm1fZmJfaGVs cGVyX2ZpbGxfaW5mbyk7Cj4+ICAKPj4gK3N0YXRpYyB2b2lkIGRybV9jbGllbnRfY29ubmVjdG9y c19lbmFibGVkKHN0cnVjdCBkcm1fY29ubmVjdG9yICoqY29ubmVjdG9ycywKPj4gKwkJCQkJICB1 bnNpZ25lZCBpbnQgY29ubmVjdG9yX2NvdW50LAo+PiArCQkJCQkgIGJvb2wgKmVuYWJsZWQpCj4+ ICB7Cj4+ICAJYm9vbCBhbnlfZW5hYmxlZCA9IGZhbHNlOwo+PiAgCXN0cnVjdCBkcm1fY29ubmVj dG9yICpjb25uZWN0b3I7Cj4+ICAJaW50IGkgPSAwOwo+PiAgCj4+IC0JZHJtX2ZiX2hlbHBlcl9m b3JfZWFjaF9jb25uZWN0b3IoZmJfaGVscGVyLCBpKSB7Cj4+IC0JCWNvbm5lY3RvciA9IGZiX2hl bHBlci0+Y29ubmVjdG9yX2luZm9baV0tPmNvbm5lY3RvcjsKPj4gKwlmb3IgKGkgPSAwOyBpIDwg Y29ubmVjdG9yX2NvdW50OyBpKyspIHsKPj4gKwkJY29ubmVjdG9yID0gY29ubmVjdG9yc1tpXTsK PiBUaGlzIGlzIGZvciBleGFtcGxlIGEgcGxhY2Ugd2hlcmUgdGhlIGRybV9mYl9oZWxwZXJfZm9y X2VhY2hfY29ubmVjdG9yKCkKPiBpcyByZXBsYWNlZCBieSBhIHNpbXBsZSBmb3IgbG9vcC4KClll YWgsIHRoaXMgaXMgZG93bnN0cmVhbSBmcm9tIGRybV9zZXR1cF9jcnRjcygpIGFuZCB3ZSdyZSBv cGVyYXRpbmcgb24KdGhlIHRlbXBvcmFyeSAnY29ubmVjdG9ycycgYXJyYXkuCgo+IFRoZSBzaW1w bGUgZm9yIGxvb3AgaXMgbmljZSBhbmQgcmVhZGFibGUgLSBqdXN0IGEgY29tbWVudCByZXBsYXRl ZCB0bwo+IHRoZSBhYm92ZSBjb21tZW50Lgo+IAo+PiAgCQlzdHJ1Y3QgZHJtX2Rpc3BsYXlfbW9k ZSAqbW9kZSA9IG1vZGVzW2ldOwo+PiAgCQlzdHJ1Y3QgZHJtX2NydGMgKmNydGMgPSBjcnRjc1tp XTsKPj4gIAkJc3RydWN0IGRybV9mYl9vZmZzZXQgKm9mZnNldCA9ICZvZmZzZXRzW2ldOwo+PiAg Cj4+ICAJCWlmIChtb2RlICYmIGNydGMpIHsKPj4gIAkJCXN0cnVjdCBkcm1fbW9kZV9zZXQgKm1v ZGVzZXQgPSBkcm1fY2xpZW50X2ZpbmRfbW9kZXNldChjbGllbnQsIGNydGMpOwo+PiAtCQkJc3Ry dWN0IGRybV9jb25uZWN0b3IgKmNvbm5lY3RvciA9Cj4+IC0JCQkJZmJfaGVscGVyLT5jb25uZWN0 b3JfaW5mb1tpXS0+Y29ubmVjdG9yOwo+PiArCQkJc3RydWN0IGRybV9jb25uZWN0b3IgKmNvbm5l Y3RvciA9IGNvbm5lY3RvcnNbaV07Cj4+ICAKPj4gIAkJCURSTV9ERUJVR19LTVMoImRlc2lyZWQg bW9kZSAlcyBzZXQgb24gY3J0YyAlZCAoJWQsJWQpXG4iLAo+PiAgCQkJCSAgICAgIG1vZGUtPm5h bWUsIGNydGMtPmJhc2UuaWQsIG9mZnNldC0+eCwgb2Zmc2V0LT55KTsKPj4gQEAgLTI1MzksNiAr MjM1NCwxMCBAQCBzdGF0aWMgdm9pZCBkcm1fc2V0dXBfY3J0Y3Moc3RydWN0IGRybV9mYl9oZWxw ZXIgKmZiX2hlbHBlciwKPj4gIAlrZnJlZShtb2Rlcyk7Cj4+ICAJa2ZyZWUob2Zmc2V0cyk7Cj4+ ICAJa2ZyZWUoZW5hYmxlZCk7Cj4+ICtmcmVlX2Nvbm5lY3RvcnM6Cj4+ICsJZm9yIChpID0gMDsg aSA8IGNvbm5lY3Rvcl9jb3VudDsgaSsrKQo+PiArCQlkcm1fY29ubmVjdG9yX3B1dChjb25uZWN0 b3JzW2ldKTsKPiBUaGlzIG1heSBjYWxsIGRybV9jb25uZWN0b3JfcHV0KE5VTEwpIGFzIG5vdCBh bGwgY29ubmVjdG9ycyBhcmUgaW5pdC4KPiAKCklmIHlvdSBsb29rIGZ1cnRoZXIgdXAgd2hlcmUg dGhlIGNvbm5lY3RvcnMgYXJyYXkgaXMgY3JlYXRlZCwgeW91J2xsIHNlZQp0aGF0IGNvbm5lY3Rv cl9jb3VudCBpcyBvbmx5IGluY3JlbWVudGVkIGlmIHdlIHN1Y2NlZWQgaW4ga3JlYWxsb2MnaW5n CnRoZSBhcnJheSBsZWFkaW5nIHRvIGdldHRpbmcgYSByZWYgb24gdGhlIGNvbm5lY3Rvci4KCj4+ ICsJa2ZyZWUoY29ubmVjdG9ycyk7Cj4+ICB9Cj4+ICAKPj4gIC8qCj4+IEBAIC0yNTUxLDEwICsy MzcwLDExIEBAIHN0YXRpYyB2b2lkIGRybV9zZXR1cF9jcnRjcyhzdHJ1Y3QgZHJtX2ZiX2hlbHBl ciAqZmJfaGVscGVyLAo+PiAgc3RhdGljIHZvaWQgZHJtX3NldHVwX2NydGNzX2ZiKHN0cnVjdCBk cm1fZmJfaGVscGVyICpmYl9oZWxwZXIpCj4+ICB7Cj4+ICAJc3RydWN0IGRybV9jbGllbnRfZGV2 ICpjbGllbnQgPSAmZmJfaGVscGVyLT5jbGllbnQ7Cj4+ICsJc3RydWN0IGRybV9jb25uZWN0b3Jf bGlzdF9pdGVyIGNvbm5faXRlcjsKPj4gIAlzdHJ1Y3QgZmJfaW5mbyAqaW5mbyA9IGZiX2hlbHBl ci0+ZmJkZXY7Cj4+ICAJdW5zaWduZWQgaW50IHJvdGF0aW9uLCBzd19yb3RhdGlvbnMgPSAwOwo+ PiArCXN0cnVjdCBkcm1fY29ubmVjdG9yICpjb25uZWN0b3I7Cj4+ICAJc3RydWN0IGRybV9tb2Rl X3NldCAqbW9kZXNldDsKPj4gLQlpbnQgaTsKPj4gIAo+PiAgCW11dGV4X2xvY2soJmNsaWVudC0+ bW9kZXNldF9tdXRleCk7Cj4+ICAJZHJtX2NsaWVudF9mb3JfZWFjaF9tb2Rlc2V0KG1vZGVzZXQs IGNsaWVudCkgewo+PiBAQCAtMjU3MSwxMCArMjM5MSw4IEBAIHN0YXRpYyB2b2lkIGRybV9zZXR1 cF9jcnRjc19mYihzdHJ1Y3QgZHJtX2ZiX2hlbHBlciAqZmJfaGVscGVyKQo+PiAgCX0KPj4gIAlt dXRleF91bmxvY2soJmNsaWVudC0+bW9kZXNldF9tdXRleCk7Cj4+ICAKPj4gLQltdXRleF9sb2Nr KCZmYl9oZWxwZXItPmRldi0+bW9kZV9jb25maWcubXV0ZXgpOwo+IFdoeSBpcyBpdCBPSyB0byBk cm9wIHRoaXMgbG9jaz8KPiBJbiBnZW5lcmFsIEkgZmFpbCB0byBzZWUgaG93IHRoZSBjb25uZWN0 b3IgZGF0YSBpcyBwcm90ZWN0ZWQgKGxvY2tpbmcKPiBydWxlcz8pIFRoaXMgaXMgbGlrZWx5IGp1 c3QgbWUgbWlzc2luZyB0aGUgYmlnZ2VyIHBpY3R1cmUgaGVyZS4uCj4gCgpUaGUgY29ubmVjdG9y IGl0ZXJhdG9yIHVzZXMgc29tZSBtYWdpYyB0byBhdm9pZCB0YWtpbmcgdGhlIG1vZGVfY29uZmln Cm11dGV4LiBTZWUgZHJtX2Nvbm5lY3Rvcl9saXN0X2l0ZXJfbmV4dCgpLgoKTm9yYWxmLgoKPj4g Kwlkcm1fY29ubmVjdG9yX2xpc3RfaXRlcl9lbmQoJmNvbm5faXRlcik7Cj4+ICAKPj4gIAlzd2l0 Y2ggKHN3X3JvdGF0aW9ucykgewo+PiAgCWNhc2UgRFJNX01PREVfUk9UQVRFXzA6Cj4gCl9fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCkludGVsLWdmeCBtYWls aW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZy ZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeA==