All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Matias Bjørling" <mb@lightnvm.io>
To: "Huaicheng Li" <huaicheng@cs.uchicago.edu>,
	"Javier González" <jg@lightnvm.io>
Cc: linux-block@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] lightnvm: fix memory leak in pblk_luns_init
Date: Fri, 23 Feb 2018 07:12:26 +0100	[thread overview]
Message-ID: <870ebf31-340a-1673-d4b3-e755dd2be493@lightnvm.io> (raw)
In-Reply-To: <CANr0WEcDSy3YuZ8kaNuB7Z0wFfiV6AwT=bg4W3MNq--2txX2xQ@mail.gmail.com>

On 02/23/2018 12:03 AM, Huaicheng Li wrote:
> Please ignore my previous email as I found the memory is free'ed at
> pblk_init()'s error handling logic.
> Sorry for the interruption.
> 
> On Thu, Feb 22, 2018 at 3:01 PM, Huaicheng Li <huaicheng@cs.uchicago.edu>
> wrote:
> 
>> Signed-off-by: Huaicheng Li <huaicheng@cs.uchicago.edu>
>> ---
>> drivers/lightnvm/pblk-init.c | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/lightnvm/pblk-init.c b/drivers/lightnvm/pblk-init.c
>> index 93d671ca518e..330665d91d8d 100644
>> --- a/drivers/lightnvm/pblk-init.c
>> +++ b/drivers/lightnvm/pblk-init.c
>> @@ -510,6 +510,7 @@ static int pblk_luns_init(struct pblk *pblk, struct
>> ppa_addr *luns)
>>                  if (ret) {
>>                          while (--i >= 0)
>>                                  kfree(pblk->luns[i].bb_list);
>> +                       kfree(pblk->luns);
>>                          return ret;
>>                  }
>>          }
>> --
>> 2.13.6
>>
>>
> 

No worries. The initialization part is pretty complex due to all the 
data structures being set up. I would love to have a clean 
initialization function, which cleans up after it self. But being able 
to share the "fail" bringup and tear-down code is very helpful and makes 
other parts easier.

  parent reply	other threads:[~2018-02-23  6:12 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-02-22 21:01 [PATCH] lightnvm: fix memory leak in pblk_luns_init Huaicheng Li
     [not found] ` <CANr0WEcDSy3YuZ8kaNuB7Z0wFfiV6AwT=bg4W3MNq--2txX2xQ@mail.gmail.com>
2018-02-23  6:12   ` Matias Bjørling [this message]
2018-02-23  8:56     ` Javier González

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=870ebf31-340a-1673-d4b3-e755dd2be493@lightnvm.io \
    --to=mb@lightnvm.io \
    --cc=huaicheng@cs.uchicago.edu \
    --cc=jg@lightnvm.io \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.