From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sameer Pujar Subject: Re: [PATCH 03/10] ASoC: audio-graph: Support Codec with multiple endpoints Date: Mon, 20 Jul 2020 09:44:02 +0530 Message-ID: <870feaf2-3aa2-dbb8-f883-9b6cfcb36d82@nvidia.com> References: <1595135417-16589-1-git-send-email-spujar@nvidia.com> <1595135417-16589-4-git-send-email-spujar@nvidia.com> <87365n2i2z.wl-kuninori.morimoto.gx@renesas.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <87365n2i2z.wl-kuninori.morimoto.gx-zM6kxYcvzFBBDgjK7y7TUQ@public.gmane.org> Content-Language: en-GB Sender: linux-tegra-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Kuninori Morimoto Cc: spujar-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org, broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, perex-/Fr2/VpizcU@public.gmane.org, tiwai-IBi9RG/b67k@public.gmane.org, robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, lgirdwood-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, jonathanh-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org, alsa-devel-K7yf7f+aM1XWsZ/bQMPhNw@public.gmane.org, linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, sharadg-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org, mkumard-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org, viswanathl-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org, rlokhande-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org, dramesh-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org, atalambedu-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org, nwartikar-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org, swarren-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org, nicoleotsuka-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org List-Id: linux-tegra@vger.kernel.org On 7/20/2020 5:07 AM, Kuninori Morimoto wrote: > External email: Use caution opening links or attachments > > > Hi Sameer > >> If a Codec port has multiple endpoints, only first endpoint gets parsed >> and remaining are ignored. This can be fixed by removing 'dup_codec' flag >> passed to graph_dai_link_of_dpcm() and thus it loops over all endpoints >> of Codec. Similarly graph_count_dpcm() is updated as well. >> >> Signed-off-by: Sameer Pujar >> --- >> sound/soc/generic/audio-graph-card.c | 28 +++++++++------------------- >> 1 file changed, 9 insertions(+), 19 deletions(-) >> >> diff --git a/sound/soc/generic/audio-graph-card.c b/sound/soc/generic/audio-graph-card.c >> index 1e20562..b1903f9 100644 >> --- a/sound/soc/generic/audio-graph-card.c >> +++ b/sound/soc/generic/audio-graph-card.c >> @@ -201,8 +201,7 @@ static void graph_parse_mclk_fs(struct device_node *top, >> static int graph_dai_link_of_dpcm(struct asoc_simple_priv *priv, >> struct device_node *cpu_ep, >> struct device_node *codec_ep, >> - struct link_info *li, >> - int dup_codec) >> + struct link_info *li) > This patch breaks DPCM connection which is used for MIXer Could you please elaborate a bit more as to what is broken with this? The problem I am trying to solve here is to have multiple endpoints for Codec port. > > Thank you for your help !! > > Best regards > --- > Kuninori Morimoto From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CA412C433E3 for ; Mon, 20 Jul 2020 04:14:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A8A9B20709 for ; Mon, 20 Jul 2020 04:14:15 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=nvidia.com header.i=@nvidia.com header.b="TZQQOzD1" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726463AbgGTEOO (ORCPT ); Mon, 20 Jul 2020 00:14:14 -0400 Received: from hqnvemgate25.nvidia.com ([216.228.121.64]:19719 "EHLO hqnvemgate25.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725263AbgGTEON (ORCPT ); Mon, 20 Jul 2020 00:14:13 -0400 Received: from hqpgpgate102.nvidia.com (Not Verified[216.228.121.13]) by hqnvemgate25.nvidia.com (using TLS: TLSv1.2, DES-CBC3-SHA) id ; Sun, 19 Jul 2020 21:13:11 -0700 Received: from hqmail.nvidia.com ([172.20.161.6]) by hqpgpgate102.nvidia.com (PGP Universal service); Sun, 19 Jul 2020 21:14:12 -0700 X-PGP-Universal: processed; by hqpgpgate102.nvidia.com on Sun, 19 Jul 2020 21:14:12 -0700 Received: from [10.25.99.163] (10.124.1.5) by HQMAIL107.nvidia.com (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Mon, 20 Jul 2020 04:14:05 +0000 CC: , , , , , , , , , , , , , , , , , , , Subject: Re: [PATCH 03/10] ASoC: audio-graph: Support Codec with multiple endpoints To: Kuninori Morimoto References: <1595135417-16589-1-git-send-email-spujar@nvidia.com> <1595135417-16589-4-git-send-email-spujar@nvidia.com> <87365n2i2z.wl-kuninori.morimoto.gx@renesas.com> From: Sameer Pujar Message-ID: <870feaf2-3aa2-dbb8-f883-9b6cfcb36d82@nvidia.com> Date: Mon, 20 Jul 2020 09:44:02 +0530 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <87365n2i2z.wl-kuninori.morimoto.gx@renesas.com> X-Originating-IP: [10.124.1.5] X-ClientProxiedBy: HQMAIL101.nvidia.com (172.20.187.10) To HQMAIL107.nvidia.com (172.20.187.13) Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-GB DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1; t=1595218391; bh=nx5lAIYmOjDB4BduiFhtKmLRJSU6RRYMWVlTJDi4E/g=; h=X-PGP-Universal:CC:Subject:To:References:From:Message-ID:Date: User-Agent:MIME-Version:In-Reply-To:X-Originating-IP: X-ClientProxiedBy:Content-Type:Content-Transfer-Encoding: Content-Language; b=TZQQOzD1ItvuulsVlIa1WUJnL2CkhNwOS7poO+6Z3JLe7mfSuyw4hSfeMpFQd21CS JJ3HoVHvh+iE6GRADC1p22/9vIGbMcunNC1+048hYcRz0J22zowoilNrZoxfNXZfd+ tbchL+aGMtAZ7Ju8oaNI3XV7rEEdiOiKWRzqk3qyuYSVvvq50KxqfvzHtQ1J62rbiD TWW/BTWpr8Jshg0aNzRe6UvMNcB+VjYF4BrD4WdoD2HgF0cY/xmSfjRqqo2l6DtDrX RwD6efyaI4vgy198gRaVOn68x1Qh4jzZsjGqZs6d4/x8ERbWFQbj8P4rMUiuqasSZi BBgS3IvXcCZJA== Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 7/20/2020 5:07 AM, Kuninori Morimoto wrote: > External email: Use caution opening links or attachments > > > Hi Sameer > >> If a Codec port has multiple endpoints, only first endpoint gets parsed >> and remaining are ignored. This can be fixed by removing 'dup_codec' flag >> passed to graph_dai_link_of_dpcm() and thus it loops over all endpoints >> of Codec. Similarly graph_count_dpcm() is updated as well. >> >> Signed-off-by: Sameer Pujar >> --- >> sound/soc/generic/audio-graph-card.c | 28 +++++++++------------------- >> 1 file changed, 9 insertions(+), 19 deletions(-) >> >> diff --git a/sound/soc/generic/audio-graph-card.c b/sound/soc/generic/audio-graph-card.c >> index 1e20562..b1903f9 100644 >> --- a/sound/soc/generic/audio-graph-card.c >> +++ b/sound/soc/generic/audio-graph-card.c >> @@ -201,8 +201,7 @@ static void graph_parse_mclk_fs(struct device_node *top, >> static int graph_dai_link_of_dpcm(struct asoc_simple_priv *priv, >> struct device_node *cpu_ep, >> struct device_node *codec_ep, >> - struct link_info *li, >> - int dup_codec) >> + struct link_info *li) > This patch breaks DPCM connection which is used for MIXer Could you please elaborate a bit more as to what is broken with this? The problem I am trying to solve here is to have multiple endpoints for Codec port. > > Thank you for your help !! > > Best regards > --- > Kuninori Morimoto From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.5 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, NICE_REPLY_A,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5A2A0C433E0 for ; Mon, 20 Jul 2020 04:15:18 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D936E20672 for ; Mon, 20 Jul 2020 04:15:17 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="MSXdVQD/"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=nvidia.com header.i=@nvidia.com header.b="TZQQOzD1" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D936E20672 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=nvidia.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 66B5483E; Mon, 20 Jul 2020 06:14:26 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 66B5483E DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1595218516; bh=D1W/TJBSRYNLqMmfHtigTPJ5uQo12q/u7w8uTwreA3M=; h=Subject:To:References:From:Date:In-Reply-To:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=MSXdVQD/hVftPFu08t6K5kAXfDwQ7HFjqFhWrPKRxs/ZBaxbyCdpeiniV4RwHt0Qe Un8EgZr0h18UUuN3VCoOcE36CTjdP0CgNPjw351OIxDC0WzTdpUkGSwP1j0wIOf/rP vBomBhbIsbW3IESDo9H5yv20dzcLLpbGNmVGuPGA= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id C8529F800E0; Mon, 20 Jul 2020 06:14:25 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 2BBF0F800F5; Mon, 20 Jul 2020 06:14:23 +0200 (CEST) Received: from hqnvemgate25.nvidia.com (hqnvemgate25.nvidia.com [216.228.121.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 98DD8F800C1 for ; Mon, 20 Jul 2020 06:14:15 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 98DD8F800C1 Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key) header.d=nvidia.com header.i=@nvidia.com header.b="TZQQOzD1" Received: from hqpgpgate102.nvidia.com (Not Verified[216.228.121.13]) by hqnvemgate25.nvidia.com (using TLS: TLSv1.2, DES-CBC3-SHA) id ; Sun, 19 Jul 2020 21:13:11 -0700 Received: from hqmail.nvidia.com ([172.20.161.6]) by hqpgpgate102.nvidia.com (PGP Universal service); Sun, 19 Jul 2020 21:14:12 -0700 X-PGP-Universal: processed; by hqpgpgate102.nvidia.com on Sun, 19 Jul 2020 21:14:12 -0700 Received: from [10.25.99.163] (10.124.1.5) by HQMAIL107.nvidia.com (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Mon, 20 Jul 2020 04:14:05 +0000 Subject: Re: [PATCH 03/10] ASoC: audio-graph: Support Codec with multiple endpoints To: Kuninori Morimoto References: <1595135417-16589-1-git-send-email-spujar@nvidia.com> <1595135417-16589-4-git-send-email-spujar@nvidia.com> <87365n2i2z.wl-kuninori.morimoto.gx@renesas.com> From: Sameer Pujar Message-ID: <870feaf2-3aa2-dbb8-f883-9b6cfcb36d82@nvidia.com> Date: Mon, 20 Jul 2020 09:44:02 +0530 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <87365n2i2z.wl-kuninori.morimoto.gx@renesas.com> X-Originating-IP: [10.124.1.5] X-ClientProxiedBy: HQMAIL101.nvidia.com (172.20.187.10) To HQMAIL107.nvidia.com (172.20.187.13) Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-GB DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1; t=1595218391; bh=nx5lAIYmOjDB4BduiFhtKmLRJSU6RRYMWVlTJDi4E/g=; h=X-PGP-Universal:CC:Subject:To:References:From:Message-ID:Date: User-Agent:MIME-Version:In-Reply-To:X-Originating-IP: X-ClientProxiedBy:Content-Type:Content-Transfer-Encoding: Content-Language; b=TZQQOzD1ItvuulsVlIa1WUJnL2CkhNwOS7poO+6Z3JLe7mfSuyw4hSfeMpFQd21CS JJ3HoVHvh+iE6GRADC1p22/9vIGbMcunNC1+048hYcRz0J22zowoilNrZoxfNXZfd+ tbchL+aGMtAZ7Ju8oaNI3XV7rEEdiOiKWRzqk3qyuYSVvvq50KxqfvzHtQ1J62rbiD TWW/BTWpr8Jshg0aNzRe6UvMNcB+VjYF4BrD4WdoD2HgF0cY/xmSfjRqqo2l6DtDrX RwD6efyaI4vgy198gRaVOn68x1Qh4jzZsjGqZs6d4/x8ERbWFQbj8P4rMUiuqasSZi BBgS3IvXcCZJA== Cc: jonathanh@nvidia.com, nicoleotsuka@gmail.com, alsa-devel@alsa-project.org, atalambedu@nvidia.com, swarren@nvidia.com, linux-kernel@vger.kernel.org, spujar@nvidia.com, nwartikar@nvidia.com, lgirdwood@gmail.com, robh+dt@kernel.org, tiwai@suse.com, viswanathl@nvidia.com, sharadg@nvidia.com, broonie@kernel.org, thierry.reding@gmail.com, linux-tegra@vger.kernel.org, rlokhande@nvidia.com, mkumard@nvidia.com, dramesh@nvidia.com X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On 7/20/2020 5:07 AM, Kuninori Morimoto wrote: > External email: Use caution opening links or attachments > > > Hi Sameer > >> If a Codec port has multiple endpoints, only first endpoint gets parsed >> and remaining are ignored. This can be fixed by removing 'dup_codec' flag >> passed to graph_dai_link_of_dpcm() and thus it loops over all endpoints >> of Codec. Similarly graph_count_dpcm() is updated as well. >> >> Signed-off-by: Sameer Pujar >> --- >> sound/soc/generic/audio-graph-card.c | 28 +++++++++------------------- >> 1 file changed, 9 insertions(+), 19 deletions(-) >> >> diff --git a/sound/soc/generic/audio-graph-card.c b/sound/soc/generic/audio-graph-card.c >> index 1e20562..b1903f9 100644 >> --- a/sound/soc/generic/audio-graph-card.c >> +++ b/sound/soc/generic/audio-graph-card.c >> @@ -201,8 +201,7 @@ static void graph_parse_mclk_fs(struct device_node *top, >> static int graph_dai_link_of_dpcm(struct asoc_simple_priv *priv, >> struct device_node *cpu_ep, >> struct device_node *codec_ep, >> - struct link_info *li, >> - int dup_codec) >> + struct link_info *li) > This patch breaks DPCM connection which is used for MIXer Could you please elaborate a bit more as to what is broken with this? The problem I am trying to solve here is to have multiple endpoints for Codec port. > > Thank you for your help !! > > Best regards > --- > Kuninori Morimoto