From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.6 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 25BC8C433E7 for ; Tue, 1 Sep 2020 14:35:39 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0306E206FA for ; Tue, 1 Sep 2020 14:35:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728358AbgIAOf2 (ORCPT ); Tue, 1 Sep 2020 10:35:28 -0400 Received: from www62.your-server.de ([213.133.104.62]:41788 "EHLO www62.your-server.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728355AbgIAOVL (ORCPT ); Tue, 1 Sep 2020 10:21:11 -0400 Received: from sslproxy02.your-server.de ([78.47.166.47]) by www62.your-server.de with esmtpsa (TLSv1.2:DHE-RSA-AES256-GCM-SHA384:256) (Exim 4.89_1) (envelope-from ) id 1kD79l-0001tM-TC; Tue, 01 Sep 2020 16:21:05 +0200 Received: from [178.196.57.75] (helo=pc-9.home) by sslproxy02.your-server.de with esmtpsa (TLSv1.3:TLS_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kD79l-000FYS-Lo; Tue, 01 Sep 2020 16:21:05 +0200 Subject: Re: [PATCH bpf-next v2] bpf: {cpu,dev}map: change various functions return type from int to void To: =?UTF-8?B?QmrDtnJuIFTDtnBlbA==?= , ast@kernel.org, bpf@vger.kernel.org Cc: =?UTF-8?B?QmrDtnJuIFTDtnBlbA==?= , magnus.karlsson@intel.com, netdev@vger.kernel.org, toke@redhat.com, brouer@redhat.com, dsahern@gmail.com References: <20200901083928.6199-1-bjorn.topel@gmail.com> From: Daniel Borkmann Message-ID: <871e61b9-b1f2-5ef1-6cb1-ecfd72ca4ea3@iogearbox.net> Date: Tue, 1 Sep 2020 16:21:04 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.2 MIME-Version: 1.0 In-Reply-To: <20200901083928.6199-1-bjorn.topel@gmail.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-Authenticated-Sender: daniel@iogearbox.net X-Virus-Scanned: Clear (ClamAV 0.102.4/25916/Mon Aug 31 15:26:49 2020) Sender: bpf-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: bpf@vger.kernel.org On 9/1/20 10:39 AM, Björn Töpel wrote: > From: Björn Töpel > > The functions bq_enqueue(), bq_flush_to_queue(), and bq_xmit_all() in > {cpu,dev}map.c always return zero. Changing the return type from int > to void makes the code easier to follow. > > Suggested-by: David Ahern > Signed-off-by: Björn Töpel Applied, thanks!