[Buildroot] [PATCH 1/1] package/xmrig: needs C++

[Buildroot] [PATCH 1/1] package/xmrig: needs C++

[Fabrice Fontaine]

xmrig needs C++ since its addition in commit
6f70990ccf6cb993fc31519337390e436d15493b:

CMake Error at CMakeLists.txt:2 (project):
  No CMAKE_CXX_COMPILER could be found.

Fixes:
 - http://autobuild.buildroot.org/results/48f4ff6dc8281ffa99a45401b5941b28f2c94bc2

Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
---
 package/xmrig/Config.in | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/package/xmrig/Config.in b/package/xmrig/Config.in
index 7024241017..c5c6b3e37b 100644
--- a/package/xmrig/Config.in
+++ b/package/xmrig/Config.in
@@ -8,15 +8,17 @@ config BR2_PACKAGE_XMRIG
 	# xmrig needs fenv.h which is not provided by uclibc
 	depends on !BR2_TOOLCHAIN_USES_UCLIBC
 	depends on !BR2_STATIC_LIBS # libuv
+	depends on BR2_INSTALL_LIBSTDCPP
 	select BR2_PACKAGE_LIBUV
 	help
 	  RandomX, CryptoNight, AstroBWT and Argon2 CPU/GPU miner.
 
 	  https://xmrig.com
 
-comment "xmrig needs a glibc or musl toolchain w/ NPTL, dynamic library"
+comment "xmrig needs a glibc or musl toolchain w/ NPTL, dynamic library, C++"
 	depends on BR2_aarch64 || BR2_x86_64 || BR2_i386
 	depends on BR2_USE_MMU
 	depends on BR2_TOOLCHAIN_HAS_SYNC_4
 	depends on !BR2_TOOLCHAIN_HAS_THREADS_NPTL || \
-		BR2_TOOLCHAIN_USES_UCLIBC || BR2_STATIC_LIBS
+		BR2_TOOLCHAIN_USES_UCLIBC || BR2_STATIC_LIBS || \
+		!BR2_INSTALL_LIBSTDCPP
-- 
2.35.1

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 1/1] package/xmrig: needs C++

[Yann E. MORIN]

Fabrice, All,

On 2022-04-03 18:17 +0200, Fabrice Fontaine spake thusly:
> xmrig needs C++ since its addition in commit
> 6f70990ccf6cb993fc31519337390e436d15493b:
> 
> CMake Error at CMakeLists.txt:2 (project):
>   No CMAKE_CXX_COMPILER could be found.
> 
> Fixes:
>  - http://autobuild.buildroot.org/results/48f4ff6dc8281ffa99a45401b5941b28f2c94bc2
> 
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>

Applied to master, thanks.

Regards,
Yann E. MORIN.

> ---
>  package/xmrig/Config.in | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/package/xmrig/Config.in b/package/xmrig/Config.in
> index 7024241017..c5c6b3e37b 100644
> --- a/package/xmrig/Config.in
> +++ b/package/xmrig/Config.in
> @@ -8,15 +8,17 @@ config BR2_PACKAGE_XMRIG
>  	# xmrig needs fenv.h which is not provided by uclibc
>  	depends on !BR2_TOOLCHAIN_USES_UCLIBC
>  	depends on !BR2_STATIC_LIBS # libuv
> +	depends on BR2_INSTALL_LIBSTDCPP
>  	select BR2_PACKAGE_LIBUV
>  	help
>  	  RandomX, CryptoNight, AstroBWT and Argon2 CPU/GPU miner.
>  
>  	  https://xmrig.com
>  
> -comment "xmrig needs a glibc or musl toolchain w/ NPTL, dynamic library"
> +comment "xmrig needs a glibc or musl toolchain w/ NPTL, dynamic library, C++"
>  	depends on BR2_aarch64 || BR2_x86_64 || BR2_i386
>  	depends on BR2_USE_MMU
>  	depends on BR2_TOOLCHAIN_HAS_SYNC_4
>  	depends on !BR2_TOOLCHAIN_HAS_THREADS_NPTL || \
> -		BR2_TOOLCHAIN_USES_UCLIBC || BR2_STATIC_LIBS
> +		BR2_TOOLCHAIN_USES_UCLIBC || BR2_STATIC_LIBS || \
> +		!BR2_INSTALL_LIBSTDCPP
> -- 
> 2.35.1
> 
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 1/1] package/xmrig: needs C++

[Peter Korsgaard]

>>>>> "Fabrice" == Fabrice Fontaine <fontaine.fabrice@gmail.com> writes:

 > xmrig needs C++ since its addition in commit
 > 6f70990ccf6cb993fc31519337390e436d15493b:

 > CMake Error at CMakeLists.txt:2 (project):
 >   No CMAKE_CXX_COMPILER could be found.

 > Fixes:
 >  - http://autobuild.buildroot.org/results/48f4ff6dc8281ffa99a45401b5941b28f2c94bc2

 > Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>

Committed to 2022.02.x, thanks.

-- 
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot