From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id CD17BC433EF for ; Tue, 22 Feb 2022 13:59:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232259AbiBVN7v (ORCPT ); Tue, 22 Feb 2022 08:59:51 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56774 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229801AbiBVN7v (ORCPT ); Tue, 22 Feb 2022 08:59:51 -0500 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 75D431275F3 for ; Tue, 22 Feb 2022 05:59:24 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 2C12DB819DC for ; Tue, 22 Feb 2022 13:59:23 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0E6CFC340F0; Tue, 22 Feb 2022 13:59:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1645538361; bh=rtz7aWSvmntqAWBV99EZHtfJhVdnAExUNXGQfA4GKoA=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=GcsBiMrQVdchgpJyrOwhjT5Zz/eOhcG2Vsyt9gIJIgwazPslkIoFtwzbqGp62HDnb LJALhRHpJ5QJMGQ9vay1m8HRMwCc4G9R1dwWALNmFYz59CqDf2CnhRA0cvP4Qoq0wb lViRMQ8zDqVg38JqzHDn/MM/ogv4jRzXRIltPvVp39Q+51ERW/OiOSpAduVg+Zuxfr 8ORNaW7hRcK2Yufpz5JMOMtkENduSUPgRESg2pw1XYvyW22FWJRgQoe/SO3em1kqhf 3R5OUOb1QosFAEzQs5k8tKwEEWMo4b8hlAmEieTVDqXlVMb+hkcHGSqkSRCPFGqQ6g fC/9F7vbl8KXA== From: Kalle Valo To: Carl Huang Cc: , Subject: Re: [PATCH v3 1/6] ath11k: Add basic WoW functionalities References: <1644308006-22784-2-git-send-email-quic_cjhuang@quicinc.com> <164553444424.23898.1586617399462118980.kvalo@kernel.org> Date: Tue, 22 Feb 2022 15:59:19 +0200 In-Reply-To: <164553444424.23898.1586617399462118980.kvalo@kernel.org> (Kalle Valo's message of "Tue, 22 Feb 2022 12:54:06 +0000 (UTC)") Message-ID: <871qzvvw7c.fsf@kernel.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Kalle Valo writes: > Carl Huang wrote: > >> Implement basic WoW functionalities such as magic-packet, disconnect >> and pattern. The logic is very similar to ath10k. >> >> When WoW is configured, ath11k_core_suspend and ath11k_core_resume >> are skipped as WoW configuration and hif suspend/resume are done in >> ath11k_wow_op_suspend() and ath11k_wow_op_resume(). >> >> Tested-on: QCA6390 hw2.0 PCI WLAN.HST.1.0.1-01740-QCAHSTSWPLZ_V2_TO_X86-1 >> >> Signed-off-by: Carl Huang >> Signed-off-by: Baochen Qiang >> Signed-off-by: Wen Gong > > This patchset adds new warnings: > > drivers/net/wireless/ath/ath11k/mac.c:7284:5: warning: no previous > prototype for 'ath11k_mac_flush_tx_complete' [-Wmissing-prototypes] > drivers/net/wireless/ath/ath11k/mac.c:7284:5: warning: symbol > 'ath11k_mac_flush_tx_complete' was not declared. Should it be static? > drivers/net/wireless/ath/ath11k/mac.c:8218:34: warning: cast to restricted __be64 > drivers/net/wireless/ath/ath11k/wow.c:409: line length of 98 exceeds 90 columns > drivers/net/wireless/ath/ath11k/wow.c:527: line length of 96 exceeds 90 columns > drivers/net/wireless/ath/ath11k/wow.c:528: line length of 92 exceeds 90 columns > drivers/net/wireless/ath/ath11k/mac.c:8111: line length of 96 exceeds 90 columns > drivers/net/wireless/ath/ath11k/mac.c:8168: line length of 92 exceeds 90 columns > drivers/net/wireless/ath/ath11k/mac.c:8188: line length of 92 exceeds 90 columns I fixed all these warnings in the pending branch. -- https://patchwork.kernel.org/project/linux-wireless/list/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 24CC1C433EF for ; Tue, 22 Feb 2022 13:59:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:In-Reply-To: Date:References:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=lB9o3adqy4ZskTZBvVfqCxjU5DdQArUWELi/I/aWYFU=; b=qV2y7pDDsbHzqi lJnn20e6EjQhabs2+w14BjOsnR09CBpPjClcSVWhSoqKtVsz2tz6bq5qfn/FdB65td9Qc3zBe0oAN k8jYNzLS4A4R5K0D0xxgCDtlpHf3y+3SdtyzMFhjKLciT2SVK83bmdNnmidcsLuj/S8uGVI9QlV0N +veJTe1WflcQTuWFY3i89xI45FzmxOSXOLDRpj9sNklRkRT0Nb5nVLqA0b/RNe6JEc5XcgTCBmPRy 3L0SOjSn67sZ81900HBlJwSsAgynUZEFjgyZ+dUpDIWk6RFQx5Wzw2wnrUf3K2Svv4K2VJqKj0efQ QuVpgku7s1lwInytptKw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nMVhP-009mic-Uc; Tue, 22 Feb 2022 13:59:27 +0000 Received: from ams.source.kernel.org ([2604:1380:4601:e00::1]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nMVhM-009mhv-Dz for ath11k@lists.infradead.org; Tue, 22 Feb 2022 13:59:26 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 28C7DB81995; Tue, 22 Feb 2022 13:59:23 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0E6CFC340F0; Tue, 22 Feb 2022 13:59:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1645538361; bh=rtz7aWSvmntqAWBV99EZHtfJhVdnAExUNXGQfA4GKoA=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=GcsBiMrQVdchgpJyrOwhjT5Zz/eOhcG2Vsyt9gIJIgwazPslkIoFtwzbqGp62HDnb LJALhRHpJ5QJMGQ9vay1m8HRMwCc4G9R1dwWALNmFYz59CqDf2CnhRA0cvP4Qoq0wb lViRMQ8zDqVg38JqzHDn/MM/ogv4jRzXRIltPvVp39Q+51ERW/OiOSpAduVg+Zuxfr 8ORNaW7hRcK2Yufpz5JMOMtkENduSUPgRESg2pw1XYvyW22FWJRgQoe/SO3em1kqhf 3R5OUOb1QosFAEzQs5k8tKwEEWMo4b8hlAmEieTVDqXlVMb+hkcHGSqkSRCPFGqQ6g fC/9F7vbl8KXA== From: Kalle Valo To: Carl Huang Cc: , Subject: Re: [PATCH v3 1/6] ath11k: Add basic WoW functionalities References: <1644308006-22784-2-git-send-email-quic_cjhuang@quicinc.com> <164553444424.23898.1586617399462118980.kvalo@kernel.org> Date: Tue, 22 Feb 2022 15:59:19 +0200 In-Reply-To: <164553444424.23898.1586617399462118980.kvalo@kernel.org> (Kalle Valo's message of "Tue, 22 Feb 2022 12:54:06 +0000 (UTC)") Message-ID: <871qzvvw7c.fsf@kernel.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220222_055924_638158_622C5E0E X-CRM114-Status: GOOD ( 11.98 ) X-BeenThere: ath11k@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "ath11k" Errors-To: ath11k-bounces+ath11k=archiver.kernel.org@lists.infradead.org Kalle Valo writes: > Carl Huang wrote: > >> Implement basic WoW functionalities such as magic-packet, disconnect >> and pattern. The logic is very similar to ath10k. >> >> When WoW is configured, ath11k_core_suspend and ath11k_core_resume >> are skipped as WoW configuration and hif suspend/resume are done in >> ath11k_wow_op_suspend() and ath11k_wow_op_resume(). >> >> Tested-on: QCA6390 hw2.0 PCI WLAN.HST.1.0.1-01740-QCAHSTSWPLZ_V2_TO_X86-1 >> >> Signed-off-by: Carl Huang >> Signed-off-by: Baochen Qiang >> Signed-off-by: Wen Gong > > This patchset adds new warnings: > > drivers/net/wireless/ath/ath11k/mac.c:7284:5: warning: no previous > prototype for 'ath11k_mac_flush_tx_complete' [-Wmissing-prototypes] > drivers/net/wireless/ath/ath11k/mac.c:7284:5: warning: symbol > 'ath11k_mac_flush_tx_complete' was not declared. Should it be static? > drivers/net/wireless/ath/ath11k/mac.c:8218:34: warning: cast to restricted __be64 > drivers/net/wireless/ath/ath11k/wow.c:409: line length of 98 exceeds 90 columns > drivers/net/wireless/ath/ath11k/wow.c:527: line length of 96 exceeds 90 columns > drivers/net/wireless/ath/ath11k/wow.c:528: line length of 92 exceeds 90 columns > drivers/net/wireless/ath/ath11k/mac.c:8111: line length of 96 exceeds 90 columns > drivers/net/wireless/ath/ath11k/mac.c:8168: line length of 92 exceeds 90 columns > drivers/net/wireless/ath/ath11k/mac.c:8188: line length of 92 exceeds 90 columns I fixed all these warnings in the pending branch. -- https://patchwork.kernel.org/project/linux-wireless/list/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches -- ath11k mailing list ath11k@lists.infradead.org http://lists.infradead.org/mailman/listinfo/ath11k