From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5B10FC4332F for ; Thu, 11 Nov 2021 10:57:10 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3B6D460FC3 for ; Thu, 11 Nov 2021 10:57:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232975AbhKKK75 (ORCPT ); Thu, 11 Nov 2021 05:59:57 -0500 Received: from foss.arm.com ([217.140.110.172]:37058 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229668AbhKKK74 (ORCPT ); Thu, 11 Nov 2021 05:59:56 -0500 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 41DEDD6E; Thu, 11 Nov 2021 02:57:07 -0800 (PST) Received: from e113632-lin (e113632-lin.cambridge.arm.com [10.1.196.57]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 292E93F70D; Thu, 11 Nov 2021 02:57:05 -0800 (PST) From: Valentin Schneider To: Marco Elver Cc: linux-kernel@vger.kernel.org, kasan-dev@googlegroups.com, linuxppc-dev@lists.ozlabs.org, linux-kbuild@vger.kernel.org, Peter Zijlstra , Ingo Molnar , Frederic Weisbecker , Mike Galbraith , Dmitry Vyukov , Michael Ellerman , Benjamin Herrenschmidt , Paul Mackerras , Steven Rostedt , Masahiro Yamada , Michal Marek , Nick Desaulniers Subject: Re: [PATCH v2 4/5] kscan: Use preemption model accessors In-Reply-To: References: <20211110202448.4054153-1-valentin.schneider@arm.com> <20211110202448.4054153-5-valentin.schneider@arm.com> Date: Thu, 11 Nov 2021 10:57:02 +0000 Message-ID: <871r3nrmdd.mognet@arm.com> MIME-Version: 1.0 Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/11/21 10:11, Marco Elver wrote: > Subject s/kscan/kcsan/ > Woops... > On Wed, Nov 10, 2021 at 08:24PM +0000, Valentin Schneider wrote: >> Per PREEMPT_DYNAMIC, checking CONFIG_PREEMPT doesn't tell you the actual >> preemption model of the live kernel. Use the newly-introduced accessors >> instead. >> >> Signed-off-by: Valentin Schneider > > Reviewed-by: Marco Elver > > Though it currently doesn't compile as a module due to missing > EXPORT_SYMBOL of is_preempt*(). > >> --- >> kernel/kcsan/kcsan_test.c | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/kernel/kcsan/kcsan_test.c b/kernel/kcsan/kcsan_test.c >> index dc55fd5a36fc..14d811eb9a21 100644 >> --- a/kernel/kcsan/kcsan_test.c >> +++ b/kernel/kcsan/kcsan_test.c >> @@ -1005,13 +1005,13 @@ static const void *nthreads_gen_params(const void *prev, char *desc) >> else >> nthreads *= 2; >> >> - if (!IS_ENABLED(CONFIG_PREEMPT) || !IS_ENABLED(CONFIG_KCSAN_INTERRUPT_WATCHER)) { >> + if (!is_preempt_full() || !IS_ENABLED(CONFIG_KCSAN_INTERRUPT_WATCHER)) { >> /* >> * Without any preemption, keep 2 CPUs free for other tasks, one >> * of which is the main test case function checking for >> * completion or failure. >> */ >> - const long min_unused_cpus = IS_ENABLED(CONFIG_PREEMPT_NONE) ? 2 : 0; >> + const long min_unused_cpus = is_preempt_none() ? 2 : 0; >> const long min_required_cpus = 2 + min_unused_cpus; >> >> if (num_online_cpus() < min_required_cpus) { >> -- >> 2.25.1 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0781CC433F5 for ; Thu, 11 Nov 2021 10:57:36 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5C10E6109D for ; Thu, 11 Nov 2021 10:57:35 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 5C10E6109D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.ozlabs.org Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4HqdwG0VqQz3cbt for ; Thu, 11 Nov 2021 21:57:34 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=arm.com (client-ip=217.140.110.172; helo=foss.arm.com; envelope-from=valentin.schneider@arm.com; receiver=) Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by lists.ozlabs.org (Postfix) with ESMTP id 4Hqdvn16V0z2ypB for ; Thu, 11 Nov 2021 21:57:08 +1100 (AEDT) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 41DEDD6E; Thu, 11 Nov 2021 02:57:07 -0800 (PST) Received: from e113632-lin (e113632-lin.cambridge.arm.com [10.1.196.57]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 292E93F70D; Thu, 11 Nov 2021 02:57:05 -0800 (PST) From: Valentin Schneider To: Marco Elver Subject: Re: [PATCH v2 4/5] kscan: Use preemption model accessors In-Reply-To: References: <20211110202448.4054153-1-valentin.schneider@arm.com> <20211110202448.4054153-5-valentin.schneider@arm.com> Date: Thu, 11 Nov 2021 10:57:02 +0000 Message-ID: <871r3nrmdd.mognet@arm.com> MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Michal Marek , linux-kbuild@vger.kernel.org, Peter Zijlstra , Frederic Weisbecker , Mike Galbraith , Nick Desaulniers , linux-kernel@vger.kernel.org, kasan-dev@googlegroups.com, Paul Mackerras , Steven Rostedt , Masahiro Yamada , linuxppc-dev@lists.ozlabs.org, Ingo Molnar , Dmitry Vyukov Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On 11/11/21 10:11, Marco Elver wrote: > Subject s/kscan/kcsan/ > Woops... > On Wed, Nov 10, 2021 at 08:24PM +0000, Valentin Schneider wrote: >> Per PREEMPT_DYNAMIC, checking CONFIG_PREEMPT doesn't tell you the actual >> preemption model of the live kernel. Use the newly-introduced accessors >> instead. >> >> Signed-off-by: Valentin Schneider > > Reviewed-by: Marco Elver > > Though it currently doesn't compile as a module due to missing > EXPORT_SYMBOL of is_preempt*(). > >> --- >> kernel/kcsan/kcsan_test.c | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/kernel/kcsan/kcsan_test.c b/kernel/kcsan/kcsan_test.c >> index dc55fd5a36fc..14d811eb9a21 100644 >> --- a/kernel/kcsan/kcsan_test.c >> +++ b/kernel/kcsan/kcsan_test.c >> @@ -1005,13 +1005,13 @@ static const void *nthreads_gen_params(const void *prev, char *desc) >> else >> nthreads *= 2; >> >> - if (!IS_ENABLED(CONFIG_PREEMPT) || !IS_ENABLED(CONFIG_KCSAN_INTERRUPT_WATCHER)) { >> + if (!is_preempt_full() || !IS_ENABLED(CONFIG_KCSAN_INTERRUPT_WATCHER)) { >> /* >> * Without any preemption, keep 2 CPUs free for other tasks, one >> * of which is the main test case function checking for >> * completion or failure. >> */ >> - const long min_unused_cpus = IS_ENABLED(CONFIG_PREEMPT_NONE) ? 2 : 0; >> + const long min_unused_cpus = is_preempt_none() ? 2 : 0; >> const long min_required_cpus = 2 + min_unused_cpus; >> >> if (num_online_cpus() < min_required_cpus) { >> -- >> 2.25.1