All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
To: Andrei Rybak <rybak.a.v@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH v1 1/3] *: spell Latin abbreviations correctly
Date: Sat, 02 Oct 2021 22:08:56 +0200	[thread overview]
Message-ID: <871r53p4oc.fsf@evledraar.gmail.com> (raw)
In-Reply-To: <20211002184407.117282-2-rybak.a.v@gmail.com>


On Sat, Oct 02 2021, Andrei Rybak wrote:

>  On the other hand, if you are fetching because you would want a
> diff --git a/compat/regex/regcomp.c b/compat/regex/regcomp.c
> index d1bc09e49b..fcf7b2daf6 100644
> --- a/compat/regex/regcomp.c
> +++ b/compat/regex/regcomp.c
> @@ -2370,7 +2370,7 @@ parse_expression (re_string_t *regexp, regex_t *preg, re_token_t *token,
>  	}
>        /* We must return here, since ANCHORs can't be followed
>  	 by repetition operators.
> -	 eg. RE"^*" is invalid or "<ANCHOR(^)><CHAR(*)>",
> +	 e.g. RE"^*" is invalid or "<ANCHOR(^)><CHAR(*)>",
>  	     it must not be "<ANCHOR(^)><REPEAT(*)>".  */
>        fetch_token (token, regexp, syntax);
>        return tree;

Let's leave externally imported code out of these sorts of changes
please.

The last time I tried (unsuccessfully) to send a series to update
compat/regex/ one of the frustrating things was the three-way diff
between base/ours/advanced upstream being cluttered by these sorts of
tree-wide typo/spelling etc. fixes.

  parent reply	other threads:[~2021-10-02 20:16 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-02 18:44 [PATCH v1 0/3] Typofixes Andrei Rybak
2021-10-02 18:44 ` [PATCH v1 1/3] *: spell Latin abbreviations correctly Andrei Rybak
2021-10-02 19:40   ` Elijah Newren
2021-10-02 20:08   ` Ævar Arnfjörð Bjarmason [this message]
2021-10-02 18:44 ` [PATCH v1 2/3] *: fix spelling typos Andrei Rybak
2021-10-02 19:34   ` Elijah Newren
2021-10-02 18:44 ` [PATCH v1 3/3] difftool: add space after full stop in comments Andrei Rybak
2021-10-02 19:36   ` Elijah Newren
2021-10-02 20:12     ` Carlo Arenas
2021-10-02 23:41       ` Elijah Newren
2021-10-11 15:42   ` David Aguilar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=871r53p4oc.fsf@evledraar.gmail.com \
    --to=avarab@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=rybak.a.v@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.