From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 293F4C433F5 for ; Fri, 17 Sep 2021 07:03:56 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 11C69611C0 for ; Fri, 17 Sep 2021 07:03:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237369AbhIQHFQ (ORCPT ); Fri, 17 Sep 2021 03:05:16 -0400 Received: from mga17.intel.com ([192.55.52.151]:55360 "EHLO mga17.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230051AbhIQHFO (ORCPT ); Fri, 17 Sep 2021 03:05:14 -0400 X-IronPort-AV: E=McAfee;i="6200,9189,10109"; a="202895715" X-IronPort-AV: E=Sophos;i="5.85,300,1624345200"; d="scan'208";a="202895715" Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Sep 2021 00:03:52 -0700 X-IronPort-AV: E=Sophos;i="5.85,300,1624345200"; d="scan'208";a="546223904" Received: from yhuang6-desk2.sh.intel.com (HELO yhuang6-desk2.ccr.corp.intel.com) ([10.239.159.119]) by fmsmga003-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Sep 2021 00:03:50 -0700 From: "Huang, Ying" To: Weizhao Ouyang Cc: Andrew Morton , John Hubbard , Pavel Tatashin , Oscar Salvador , Yang Shi , Zi Yan , Dave Hansen , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mm/debug: sync up latest migrate_reason to migrate_reason_names References: <20210917061432.323777-1-o451686892@gmail.com> Date: Fri, 17 Sep 2021 15:03:48 +0800 In-Reply-To: <20210917061432.323777-1-o451686892@gmail.com> (Weizhao Ouyang's message of "Fri, 17 Sep 2021 14:14:32 +0800") Message-ID: <871r5nptt7.fsf@yhuang6-desk2.ccr.corp.intel.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=ascii Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Weizhao Ouyang writes: > After related migrate page updates, sync up latest migrate_reason to > migrate_reason_names, page_owner use it to parse the page migrate > reason. > > Fixes: d1e153fea2a8 ("mm/gup: migrate pinned pages out of movable zone") > Fixes: 26aa2d199d6f ("mm/migrate: demote pages during reclaim") > Signed-off-by: Weizhao Ouyang > --- > mm/debug.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/mm/debug.c b/mm/debug.c > index e73fe0a8ec3d..733770b0ed0c 100644 > --- a/mm/debug.c > +++ b/mm/debug.c > @@ -25,6 +25,8 @@ const char *migrate_reason_names[MR_TYPES] = { > "mempolicy_mbind", > "numa_misplaced", > "cma", > + "longterm_pin", > + "demotion", > }; > > const struct trace_print_flags pageflag_names[] = { Good catch! Thanks! Reviewed-by: "Huang, Ying" It may be better to use BUILD_BUG_ON() to capture similar issue earlier? Best Regards, Huang, Ying From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5409CC433FE for ; Fri, 17 Sep 2021 07:03:56 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id CC5BD61130 for ; Fri, 17 Sep 2021 07:03:55 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org CC5BD61130 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id 626276B0071; Fri, 17 Sep 2021 03:03:55 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5D5F3900002; Fri, 17 Sep 2021 03:03:55 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 49D166B0073; Fri, 17 Sep 2021 03:03:55 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0192.hostedemail.com [216.40.44.192]) by kanga.kvack.org (Postfix) with ESMTP id 39D8B6B0071 for ; Fri, 17 Sep 2021 03:03:55 -0400 (EDT) Received: from smtpin19.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id E88F5824556B for ; Fri, 17 Sep 2021 07:03:54 +0000 (UTC) X-FDA: 78596175588.19.A089309 Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by imf14.hostedemail.com (Postfix) with ESMTP id D15256001982 for ; Fri, 17 Sep 2021 07:03:53 +0000 (UTC) X-IronPort-AV: E=McAfee;i="6200,9189,10109"; a="219549866" X-IronPort-AV: E=Sophos;i="5.85,300,1624345200"; d="scan'208";a="219549866" Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Sep 2021 00:03:52 -0700 X-IronPort-AV: E=Sophos;i="5.85,300,1624345200"; d="scan'208";a="546223904" Received: from yhuang6-desk2.sh.intel.com (HELO yhuang6-desk2.ccr.corp.intel.com) ([10.239.159.119]) by fmsmga003-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Sep 2021 00:03:50 -0700 From: "Huang, Ying" To: Weizhao Ouyang Cc: Andrew Morton , John Hubbard , Pavel Tatashin , Oscar Salvador , Yang Shi , Zi Yan , Dave Hansen , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mm/debug: sync up latest migrate_reason to migrate_reason_names References: <20210917061432.323777-1-o451686892@gmail.com> Date: Fri, 17 Sep 2021 15:03:48 +0800 In-Reply-To: <20210917061432.323777-1-o451686892@gmail.com> (Weizhao Ouyang's message of "Fri, 17 Sep 2021 14:14:32 +0800") Message-ID: <871r5nptt7.fsf@yhuang6-desk2.ccr.corp.intel.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=ascii Authentication-Results: imf14.hostedemail.com; dkim=none; dmarc=fail reason="No valid SPF, No valid DKIM" header.from=intel.com (policy=none); spf=none (imf14.hostedemail.com: domain of ying.huang@intel.com has no SPF policy when checking 192.55.52.93) smtp.mailfrom=ying.huang@intel.com X-Stat-Signature: tpe45f4rgkabkmpatsuk36p8se9epqja X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: D15256001982 X-HE-Tag: 1631862233-350679 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Weizhao Ouyang writes: > After related migrate page updates, sync up latest migrate_reason to > migrate_reason_names, page_owner use it to parse the page migrate > reason. > > Fixes: d1e153fea2a8 ("mm/gup: migrate pinned pages out of movable zone") > Fixes: 26aa2d199d6f ("mm/migrate: demote pages during reclaim") > Signed-off-by: Weizhao Ouyang > --- > mm/debug.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/mm/debug.c b/mm/debug.c > index e73fe0a8ec3d..733770b0ed0c 100644 > --- a/mm/debug.c > +++ b/mm/debug.c > @@ -25,6 +25,8 @@ const char *migrate_reason_names[MR_TYPES] = { > "mempolicy_mbind", > "numa_misplaced", > "cma", > + "longterm_pin", > + "demotion", > }; > > const struct trace_print_flags pageflag_names[] = { Good catch! Thanks! Reviewed-by: "Huang, Ying" It may be better to use BUILD_BUG_ON() to capture similar issue earlier? Best Regards, Huang, Ying