From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8737BC07E96 for ; Thu, 8 Jul 2021 18:03:46 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1E405613AE for ; Thu, 8 Jul 2021 18:03:46 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1E405613AE Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:33876 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1m1YNE-00005X-Ty for qemu-devel@archiver.kernel.org; Thu, 08 Jul 2021 14:03:44 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:50808) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m1XhN-0006mz-FF for qemu-devel@nongnu.org; Thu, 08 Jul 2021 13:20:29 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:23029) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m1XhL-0003wQ-Mw for qemu-devel@nongnu.org; Thu, 08 Jul 2021 13:20:29 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1625764826; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=ew3mbHVnxgIAWMV+TkMeptzZofZSFliO7XG/zNd3ASs=; b=Oul5pA5hYeAoyT68Hf4KovonCdT1ESmQwFtctFpfeLk1op1d6efdz1pIiB1Ha8GAppPIwU AbcbDzscAZocGUn2qKIT1X3kw4WXDXUUKTR09xYFRlEoZYIrp+j0wfIPQHL4eoW/p21fbL WMLzWfF+QzGMsx04K8Lx+AdzzUKIxPY= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-48-u9fnUXYSOaGq0xStc9Cgmw-1; Thu, 08 Jul 2021 13:20:23 -0400 X-MC-Unique: u9fnUXYSOaGq0xStc9Cgmw-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 19AAF1023F40; Thu, 8 Jul 2021 17:20:22 +0000 (UTC) Received: from localhost (ovpn-112-175.ams2.redhat.com [10.36.112.175]) by smtp.corp.redhat.com (Postfix) with ESMTPS id A80F95D6B1; Thu, 8 Jul 2021 17:20:21 +0000 (UTC) From: Cornelia Huck To: "Cho, Yu-Chen" , qemu-devel@nongnu.org, qemu-s390x@nongnu.org Subject: Re: [PATCH v7 01/14] target/s390x: meson: add target_user_arch In-Reply-To: <20210707105324.23400-2-acho@suse.com> Organization: Red Hat GmbH References: <20210707105324.23400-1-acho@suse.com> <20210707105324.23400-2-acho@suse.com> User-Agent: Notmuch/0.32.1 (https://notmuchmail.org) Date: Thu, 08 Jul 2021 19:20:09 +0200 Message-ID: <871r88g1ti.fsf@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=cohuck@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain Received-SPF: pass client-ip=170.10.133.124; envelope-from=cohuck@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -31 X-Spam_score: -3.2 X-Spam_bar: --- X-Spam_report: (-3.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.45, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: cfontana@suse.com, Claudio Fontana , Richard Henderson , acho@suse.com, jose.ziviani@suse.com Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Wed, Jul 07 2021, "Cho, Yu-Chen" wrote: > the lack of target_user_arch makes it hard to fully leverage the > build system in order to separate user code from sysemu code. > > Provide it, so that we can avoid the proliferation of #ifdef > in target code. > > Signed-off-by: Claudio Fontana > Signed-off-by: Cho, Yu-Chen Just noticed when I was sending a pull request: your unquoted name in the s-o-b confuses git send-email when it is doing its automatic cc:s (it adds a 'cc:Cho', which is obviously bogus and leads to the mail being rejected by the list server.) Not sure whether git send-email should add proper quoting itself, but putting quoting in the s-o-b line is probably a good idea (I'm wondering why git didn't add it in the first place.) Are you fine with me modifying your s-o-b lines in the commits to include quoting, if I need to resend the pull req? > Acked-by: Cornelia Huck > Reviewed-by: Richard Henderson > --- > target/s390x/meson.build | 3 +++ > 1 file changed, 3 insertions(+)