From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 335ACC47087 for ; Wed, 26 May 2021 01:02:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 14DCD613F1 for ; Wed, 26 May 2021 01:02:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232782AbhEZBEF (ORCPT ); Tue, 25 May 2021 21:04:05 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48806 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230499AbhEZBEB (ORCPT ); Tue, 25 May 2021 21:04:01 -0400 Received: from ozlabs.org (bilbo.ozlabs.org [IPv6:2401:3900:2:1::2]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 74EB4C061574; Tue, 25 May 2021 18:02:30 -0700 (PDT) Received: from authenticated.ozlabs.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mail.ozlabs.org (Postfix) with ESMTPSA id 4FqXjZ6tj2z9s1l; Wed, 26 May 2021 11:02:26 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ellerman.id.au; s=201909; t=1621990947; bh=ovmd0QF/+rpAnQrJvBUm7otUcw+qV5Ofv5ggDfLR6Xc=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=p6bYg521w6h6ZLZ4HKv4fMMUYE1um6gMHa4CCo11P+CNv8k3t4VY708RdlLJKQ7BN FfeoldeuFU+NKz8DfiDtrZACNYxwH/Fphp2P4M3Dv0SEsF2FBt5yoVuhO5NyIyCeLb zr0OEXpyVuZE7e0N072prtqci6KDWDLoPHU/ny4/BMheg+eBHayHSgyH7FaOEgrpQZ xSRSWkPHHjdY8TYncZj5Uk/w/0PGTiKUWoGsStN4qqqmAYVnT+7duEx84qjd+3V24V UGbofM4eKqRN8smR3tP/hNAtxcDKQLoD0BpfkkWMD1yn+M+89Kenc4jNSWwIWWg1q+ eFESgryfTEU8Q== From: Michael Ellerman To: Chris Packham , wsa@kernel.org, andriy.shevchenko@linux.intel.com, andy.shevchenko@gmail.com, robh+dt@kernel.org Cc: linux-i2c@vger.kernel.org, devicetree@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org, Chris Packham , Benjamin Herrenschmidt , Paul Mackerras Subject: Re: [PATCH v3 3/4] powerpc/fsl: set fsl,i2c-erratum-a004447 flag for P1010 i2c controllers In-Reply-To: <20210511212052.27242-4-chris.packham@alliedtelesis.co.nz> References: <20210511212052.27242-1-chris.packham@alliedtelesis.co.nz> <20210511212052.27242-4-chris.packham@alliedtelesis.co.nz> Date: Wed, 26 May 2021 11:02:26 +1000 Message-ID: <871r9ui9y5.fsf@mpe.ellerman.id.au> MIME-Version: 1.0 Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Chris Packham writes: > The i2c controllers on the P1010 have an erratum where the documented > scheme for i2c bus recovery will not work (A-004447). A different > mechanism is needed which is documented in the P1010 Chip Errata Rev L. > > Signed-off-by: Chris Packham > --- > > Notes: > Changes in v3: > - New > > arch/powerpc/boot/dts/fsl/p1010si-post.dtsi | 8 ++++++++ > 1 file changed, 8 insertions(+) Acked-by: Michael Ellerman cheers > diff --git a/arch/powerpc/boot/dts/fsl/p1010si-post.dtsi b/arch/powerpc/boot/dts/fsl/p1010si-post.dtsi > index c2717f31925a..ccda0a91abf0 100644 > --- a/arch/powerpc/boot/dts/fsl/p1010si-post.dtsi > +++ b/arch/powerpc/boot/dts/fsl/p1010si-post.dtsi > @@ -122,7 +122,15 @@ memory-controller@2000 { > }; > > /include/ "pq3-i2c-0.dtsi" > + i2c@3000 { > + fsl,i2c-erratum-a004447; > + }; > + > /include/ "pq3-i2c-1.dtsi" > + i2c@3100 { > + fsl,i2c-erratum-a004447; > + }; > + > /include/ "pq3-duart-0.dtsi" > /include/ "pq3-espi-0.dtsi" > spi0: spi@7000 { > -- > 2.31.1 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DF49AC4707F for ; Wed, 26 May 2021 01:03:09 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 498BC613F1 for ; Wed, 26 May 2021 01:03:09 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 498BC613F1 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ellerman.id.au Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4FqXkN0S6Wz2ykR for ; Wed, 26 May 2021 11:03:08 +1000 (AEST) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=ellerman.id.au header.i=@ellerman.id.au header.a=rsa-sha256 header.s=201909 header.b=p6bYg521; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=ellerman.id.au (client-ip=2401:3900:2:1::2; helo=ozlabs.org; envelope-from=mpe@ellerman.id.au; receiver=) Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=ellerman.id.au header.i=@ellerman.id.au header.a=rsa-sha256 header.s=201909 header.b=p6bYg521; dkim-atps=neutral Received: from ozlabs.org (bilbo.ozlabs.org [IPv6:2401:3900:2:1::2]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4FqXjb5fvvz304G for ; Wed, 26 May 2021 11:02:27 +1000 (AEST) Received: from authenticated.ozlabs.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mail.ozlabs.org (Postfix) with ESMTPSA id 4FqXjZ6tj2z9s1l; Wed, 26 May 2021 11:02:26 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ellerman.id.au; s=201909; t=1621990947; bh=ovmd0QF/+rpAnQrJvBUm7otUcw+qV5Ofv5ggDfLR6Xc=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=p6bYg521w6h6ZLZ4HKv4fMMUYE1um6gMHa4CCo11P+CNv8k3t4VY708RdlLJKQ7BN FfeoldeuFU+NKz8DfiDtrZACNYxwH/Fphp2P4M3Dv0SEsF2FBt5yoVuhO5NyIyCeLb zr0OEXpyVuZE7e0N072prtqci6KDWDLoPHU/ny4/BMheg+eBHayHSgyH7FaOEgrpQZ xSRSWkPHHjdY8TYncZj5Uk/w/0PGTiKUWoGsStN4qqqmAYVnT+7duEx84qjd+3V24V UGbofM4eKqRN8smR3tP/hNAtxcDKQLoD0BpfkkWMD1yn+M+89Kenc4jNSWwIWWg1q+ eFESgryfTEU8Q== From: Michael Ellerman To: Chris Packham , wsa@kernel.org, andriy.shevchenko@linux.intel.com, andy.shevchenko@gmail.com, robh+dt@kernel.org Subject: Re: [PATCH v3 3/4] powerpc/fsl: set fsl,i2c-erratum-a004447 flag for P1010 i2c controllers In-Reply-To: <20210511212052.27242-4-chris.packham@alliedtelesis.co.nz> References: <20210511212052.27242-1-chris.packham@alliedtelesis.co.nz> <20210511212052.27242-4-chris.packham@alliedtelesis.co.nz> Date: Wed, 26 May 2021 11:02:26 +1000 Message-ID: <871r9ui9y5.fsf@mpe.ellerman.id.au> MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Chris Packham , Paul Mackerras , linux-i2c@vger.kernel.org, linuxppc-dev@lists.ozlabs.org Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" Chris Packham writes: > The i2c controllers on the P1010 have an erratum where the documented > scheme for i2c bus recovery will not work (A-004447). A different > mechanism is needed which is documented in the P1010 Chip Errata Rev L. > > Signed-off-by: Chris Packham > --- > > Notes: > Changes in v3: > - New > > arch/powerpc/boot/dts/fsl/p1010si-post.dtsi | 8 ++++++++ > 1 file changed, 8 insertions(+) Acked-by: Michael Ellerman cheers > diff --git a/arch/powerpc/boot/dts/fsl/p1010si-post.dtsi b/arch/powerpc/boot/dts/fsl/p1010si-post.dtsi > index c2717f31925a..ccda0a91abf0 100644 > --- a/arch/powerpc/boot/dts/fsl/p1010si-post.dtsi > +++ b/arch/powerpc/boot/dts/fsl/p1010si-post.dtsi > @@ -122,7 +122,15 @@ memory-controller@2000 { > }; > > /include/ "pq3-i2c-0.dtsi" > + i2c@3000 { > + fsl,i2c-erratum-a004447; > + }; > + > /include/ "pq3-i2c-1.dtsi" > + i2c@3100 { > + fsl,i2c-erratum-a004447; > + }; > + > /include/ "pq3-duart-0.dtsi" > /include/ "pq3-espi-0.dtsi" > spi0: spi@7000 { > -- > 2.31.1