From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.0 required=3.0 tests=BAYES_00,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4E561C433C1 for ; Wed, 24 Mar 2021 16:17:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 230B861A0D for ; Wed, 24 Mar 2021 16:17:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233671AbhCXQQq (ORCPT ); Wed, 24 Mar 2021 12:16:46 -0400 Received: from mail.kernel.org ([198.145.29.99]:34336 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230128AbhCXQQW (ORCPT ); Wed, 24 Mar 2021 12:16:22 -0400 Received: from disco-boy.misterjones.org (disco-boy.misterjones.org [51.254.78.96]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 3FBE461A0D; Wed, 24 Mar 2021 16:16:22 +0000 (UTC) Received: from 78.163-31-62.static.virginmediabusiness.co.uk ([62.31.163.78] helo=why.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94) (envelope-from ) id 1lP6BA-003YSY-C4; Wed, 24 Mar 2021 16:16:20 +0000 Date: Wed, 24 Mar 2021 16:16:19 +0000 Message-ID: <871rc4jzn0.wl-maz@kernel.org> From: Marc Zyngier To: Suzuki K Poulose Cc: Catalin Marinas , Mathieu Poirier , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, coresight@lists.linaro.org, mike.leach@linaro.org, leo.yan@linaro.org, anshuman.khandual@arm.com, Will Deacon Subject: Re: [PATCH v5 05/19] arm64: Add support for trace synchronization barrier In-Reply-To: <1b5e5bb2-b89f-fa35-0a8b-8c5476cb9ff6@arm.com> References: <20210323120647.454211-1-suzuki.poulose@arm.com> <20210323120647.454211-6-suzuki.poulose@arm.com> <20210323182142.GA16080@arm.com> <7675ab71-c2ff-91e0-5728-fcb216ac1e0d@arm.com> <875z1gk6fo.wl-maz@kernel.org> <1b5e5bb2-b89f-fa35-0a8b-8c5476cb9ff6@arm.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/27.1 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-SA-Exim-Connect-IP: 62.31.163.78 X-SA-Exim-Rcpt-To: suzuki.poulose@arm.com, catalin.marinas@arm.com, mathieu.poirier@linaro.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, coresight@lists.linaro.org, mike.leach@linaro.org, leo.yan@linaro.org, anshuman.khandual@arm.com, will.deacon@arm.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 24 Mar 2021 15:51:14 +0000, Suzuki K Poulose wrote: > > On 24/03/2021 13:49, Marc Zyngier wrote: > > On Wed, 24 Mar 2021 09:39:13 +0000, > > Suzuki K Poulose wrote: > >> > >> On 23/03/2021 18:21, Catalin Marinas wrote: > >>> Hi Suzuki? > >>> > >>> On Tue, Mar 23, 2021 at 12:06:33PM +0000, Suzuki K Poulose wrote: > >>>> tsb csync synchronizes the trace operation of instructions. > >>>> The instruction is a nop when FEAT_TRF is not implemented. > >>>> > >>>> Cc: Mathieu Poirier > >>>> Cc: Mike Leach > >>>> Cc: Catalin Marinas > >>>> Cc: Will Deacon > >>>> Signed-off-by: Suzuki K Poulose > >>> > >>> How do you plan to merge these patches? If they go via the coresight > >>> tree: > >>> > >> > >> Ideally all of this should go via the CoreSight tree to have the > >> dependencies solved at one place. But there are some issues : > >> > >> If this makes to 5.13 queue for CoreSight, > >> > >> 1) CoreSight next is based on rc2 at the moment and we have fixes gone > >> into rc3 and later, which this series will depend on. (We could move > >> the next tree forward to a later rc to solve this). > >> > >> 2) There could be conflicts with the kvmarm tree for the KVM host > >> changes (That has dependency on the TRBE definitions patch). > >> > >> If it doesn't make to 5.13 queue, it would be good to have this patch, > >> the TRBE defintions and the KVM host patches queued for 5.13 (not sure > >> if this is acceptable) and we could rebase the CoreSight changes on 5.13 > >> and push it to next release. > >> > >> I am open for other suggestions. > >> > >> Marc, Mathieu, > >> > >> Thoughts ? > > > > I was planning to take the first two patches in 5.12 as fixes (they > > are queued already, and would hopefully land in -rc5). If that doesn't > > fit with the plan, please let me know ASAP. > > Marc, > > I think it would be better to hold on pushing those patches until we > have a clarity on how things will go. OK. I thought there was a need for these patches to prevent guest access to the v8.4 self hosted tracing feature that went in 5.12 though[1]... Did I get it wrong? Thanks, M. [1] https://lore.kernel.org/r/cbe4ef17-38f9-c555-d838-796be752d4a3@arm.com -- Without deviation from the norm, progress is not possible. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E416FC433C1 for ; Wed, 24 Mar 2021 16:18:07 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 883B261A0F for ; Wed, 24 Mar 2021 16:18:07 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 883B261A0F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Subject:Cc:To: From:Message-ID:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=AjL8nUEdm8y6k7SRqOq7In3p0HdoVamKO2NAYxhOb+Q=; b=nC5yJnyv5mZ5BcYI004pxmqFs muNEIbX35DLSnNvlFgyo5zIui4c+uVfrDNB/DXC47mPGKNhwRwaJ8nCcx/Ol8faugv3cCgAkgN9bo e4PwoBjXYRM8pO9aRPQj7fKxmFCwSC26Z1WAYFGuhCNgyQvwoh/A1/dy2ty5b0Z/o82PR+5eSwEwt Boq7FW6JvlGqF0rQa1k/VlfPJSMNym/ZcYuk5qiEsSwBCoDRWwfWX4JoAH++WAEAGddtIBNaWO9ZJ FTWCtslnKMErGhxTk1F5mAFmTAwuxdvL+xKg7a9Wuy/TsS3+qwjibbYakEV/0AASk7XcW2qfrnSHM K3j8GL/Gw==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lP6BI-00HMjt-Kw; Wed, 24 Mar 2021 16:16:28 +0000 Received: from mail.kernel.org ([198.145.29.99]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lP6BD-00HMim-N5 for linux-arm-kernel@lists.infradead.org; Wed, 24 Mar 2021 16:16:25 +0000 Received: from disco-boy.misterjones.org (disco-boy.misterjones.org [51.254.78.96]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 3FBE461A0D; Wed, 24 Mar 2021 16:16:22 +0000 (UTC) Received: from 78.163-31-62.static.virginmediabusiness.co.uk ([62.31.163.78] helo=why.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94) (envelope-from ) id 1lP6BA-003YSY-C4; Wed, 24 Mar 2021 16:16:20 +0000 Date: Wed, 24 Mar 2021 16:16:19 +0000 Message-ID: <871rc4jzn0.wl-maz@kernel.org> From: Marc Zyngier To: Suzuki K Poulose Cc: Catalin Marinas , Mathieu Poirier , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, coresight@lists.linaro.org, mike.leach@linaro.org, leo.yan@linaro.org, anshuman.khandual@arm.com, Will Deacon Subject: Re: [PATCH v5 05/19] arm64: Add support for trace synchronization barrier In-Reply-To: <1b5e5bb2-b89f-fa35-0a8b-8c5476cb9ff6@arm.com> References: <20210323120647.454211-1-suzuki.poulose@arm.com> <20210323120647.454211-6-suzuki.poulose@arm.com> <20210323182142.GA16080@arm.com> <7675ab71-c2ff-91e0-5728-fcb216ac1e0d@arm.com> <875z1gk6fo.wl-maz@kernel.org> <1b5e5bb2-b89f-fa35-0a8b-8c5476cb9ff6@arm.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/27.1 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") X-SA-Exim-Connect-IP: 62.31.163.78 X-SA-Exim-Rcpt-To: suzuki.poulose@arm.com, catalin.marinas@arm.com, mathieu.poirier@linaro.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, coresight@lists.linaro.org, mike.leach@linaro.org, leo.yan@linaro.org, anshuman.khandual@arm.com, will.deacon@arm.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210324_161624_115582_C0627A01 X-CRM114-Status: GOOD ( 35.12 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, 24 Mar 2021 15:51:14 +0000, Suzuki K Poulose wrote: > > On 24/03/2021 13:49, Marc Zyngier wrote: > > On Wed, 24 Mar 2021 09:39:13 +0000, > > Suzuki K Poulose wrote: > >> > >> On 23/03/2021 18:21, Catalin Marinas wrote: > >>> Hi Suzuki? > >>> > >>> On Tue, Mar 23, 2021 at 12:06:33PM +0000, Suzuki K Poulose wrote: > >>>> tsb csync synchronizes the trace operation of instructions. > >>>> The instruction is a nop when FEAT_TRF is not implemented. > >>>> > >>>> Cc: Mathieu Poirier > >>>> Cc: Mike Leach > >>>> Cc: Catalin Marinas > >>>> Cc: Will Deacon > >>>> Signed-off-by: Suzuki K Poulose > >>> > >>> How do you plan to merge these patches? If they go via the coresight > >>> tree: > >>> > >> > >> Ideally all of this should go via the CoreSight tree to have the > >> dependencies solved at one place. But there are some issues : > >> > >> If this makes to 5.13 queue for CoreSight, > >> > >> 1) CoreSight next is based on rc2 at the moment and we have fixes gone > >> into rc3 and later, which this series will depend on. (We could move > >> the next tree forward to a later rc to solve this). > >> > >> 2) There could be conflicts with the kvmarm tree for the KVM host > >> changes (That has dependency on the TRBE definitions patch). > >> > >> If it doesn't make to 5.13 queue, it would be good to have this patch, > >> the TRBE defintions and the KVM host patches queued for 5.13 (not sure > >> if this is acceptable) and we could rebase the CoreSight changes on 5.13 > >> and push it to next release. > >> > >> I am open for other suggestions. > >> > >> Marc, Mathieu, > >> > >> Thoughts ? > > > > I was planning to take the first two patches in 5.12 as fixes (they > > are queued already, and would hopefully land in -rc5). If that doesn't > > fit with the plan, please let me know ASAP. > > Marc, > > I think it would be better to hold on pushing those patches until we > have a clarity on how things will go. OK. I thought there was a need for these patches to prevent guest access to the v8.4 self hosted tracing feature that went in 5.12 though[1]... Did I get it wrong? Thanks, M. [1] https://lore.kernel.org/r/cbe4ef17-38f9-c555-d838-796be752d4a3@arm.com -- Without deviation from the norm, progress is not possible. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel