From: Jani Nikula <jani.nikula@linux.intel.com>
To: Thomas Zimmermann <tzimmermann@suse.de>,
Tian Tao <tiantao6@hisilicon.com>,
airlied@linux.ie, daniel@ffwll.ch, kraxel@redhat.com,
alexander.deucher@amd.com, tglx@linutronix.de,
dri-devel@lists.freedesktop.org, xinliang.liu@linaro.org
Subject: Re: [RFC] drm/connector: Set the default callback function for drm_connector_funcs
Date: Fri, 08 Jan 2021 15:07:41 +0200 [thread overview]
Message-ID: <871revziea.fsf@intel.com> (raw)
In-Reply-To: <d8e3cdca-79dd-2c41-27c1-b09a45670976@suse.de>
On Fri, 08 Jan 2021, Thomas Zimmermann <tzimmermann@suse.de> wrote:
> Drivers cannot legally declare the funcs instance as static const.
> Having static const allows for write protected pages.
This. I've done quite a bit of refactoring all over the place to be
ablet to move to the complete opposite direction. We want to keep all
callback structs static const.
If the idea here was good (on which I'm inclined to side with Thomas and
Daniel that it isn't), the way to go would be to add a small wrapper for
calling ->fill_modes(), with a different path for when it's NULL.
BR,
Jani.
--
Jani Nikula, Intel Open Source Graphics Center
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2021-01-08 13:07 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-08 7:54 [RFC] drm/connector: Set the default callback function for drm_connector_funcs Tian Tao
2021-01-08 8:12 ` Thomas Zimmermann
2021-01-08 8:58 ` Daniel Vetter
2021-01-08 13:07 ` Jani Nikula [this message]
2021-01-08 15:16 ` kernel test robot
2021-01-08 15:17 ` kernel test robot
2021-01-08 23:32 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=871revziea.fsf@intel.com \
--to=jani.nikula@linux.intel.com \
--cc=airlied@linux.ie \
--cc=alexander.deucher@amd.com \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=kraxel@redhat.com \
--cc=tglx@linutronix.de \
--cc=tiantao6@hisilicon.com \
--cc=tzimmermann@suse.de \
--cc=xinliang.liu@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.