From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Gleixner Date: Mon, 16 Nov 2020 17:42:19 +0000 Subject: Re: [patch 10/19] preempt: Cleanup the macro maze a bit Message-Id: <871rgtyz9g.fsf@nanos.tec.linutronix.de> List-Id: References: <20201113140207.499353218@linutronix.de> <20201113141733.864469886@linutronix.de> <20201116121748.GD3121378@hirez.programming.kicks-ass.net> In-Reply-To: <20201116121748.GD3121378@hirez.programming.kicks-ass.net> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Peter Zijlstra Cc: Marc Zyngier , Rich Felker , Catalin Marinas , Paul McKenney , Arnd Bergmann , linux-sh@vger.kernel.org, Richard Weinberger , Frederic Weisbecker , Valentin Schneider , Jeff Dike , LKML , Yoshinori Sato , "James E.J. Bottomley" , linux-parisc@vger.kernel.org, Helge Deller , Russell King , linux-um@lists.infradead.org, Will Deacon , Sebastian Andrzej Siewior , linux-arm-kernel@lists.infradead.org, Anton Ivanov On Mon, Nov 16 2020 at 13:17, Peter Zijlstra wrote: > On Fri, Nov 13, 2020 at 03:02:17PM +0100, Thomas Gleixner wrote: > >> -#define irq_count() (preempt_count() & (HARDIRQ_MASK | SOFTIRQ_MASK \ >> - | NMI_MASK)) >> +#define irq_count() (nmi_count() | hardirq_count() | softirq_count()) > > >> +#define in_task() (!(in_nmi() | in_hardirq() | in_serving_softirq())) >> -#define in_task() (!(preempt_count() & \ >> - (NMI_MASK | HARDIRQ_MASK | SOFTIRQ_OFFSET))) > > How horrible is the code-gen? Because preempt_count() is > raw_cpu_read_4() and at least some old compilers will refuse to CSE it > (consider the this_cpu_read_stable mess). I looked at gcc8 and 10 output and the compilers are smart enough to fold it for the !RT case. But yeah ... Thanks, tglx From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F2D8FC6379F for ; Mon, 16 Nov 2020 17:43:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id AB30622265 for ; Mon, 16 Nov 2020 17:43:27 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linutronix.de header.i=@linutronix.de header.b="ucTY/LVv"; dkim=permerror (0-bit key) header.d=linutronix.de header.i=@linutronix.de header.b="YP2D9OKy" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387978AbgKPRnE (ORCPT ); Mon, 16 Nov 2020 12:43:04 -0500 Received: from Galois.linutronix.de ([193.142.43.55]:42608 "EHLO galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2387829AbgKPRmV (ORCPT ); Mon, 16 Nov 2020 12:42:21 -0500 From: Thomas Gleixner DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1605548539; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=AFtB0Ip6R2EINkfby885/eXKxzn7nAYtOiaas7ShpD8=; b=ucTY/LVv679/wmtLVFj1aWd9sEHqvK298xZYswCwYCPhN8K6/VsSRE7jSBhfryBTJ6Xaec iWZ1KD8vwfG36MTBmhGHCbsUbS3UqdYPBCdHIrK4tFOGGv3o73NqScfF+IuVD7Lx5wNJ4E ct+pvkYNxgjuYfF6W+3H6JhdZW9rLmVSMnAqbJjz3eaXA1ppi8L0brIci6nAcqGV/SzjpO d55eUUUn6T/bNSl1Z/8Nge63sZYpmCqmJJI8znPpt3TuS881D+s7KtqNUyS/qzsi4xUqQ4 RlAO3412YsCCAu+hJz3yg2rDEig4KmlERzF8sx2R4lQkRAVmN9SJ/UqOp1+QOQ== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1605548539; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=AFtB0Ip6R2EINkfby885/eXKxzn7nAYtOiaas7ShpD8=; b=YP2D9OKyBiwGPh1cJ4lErNx/TU9tcJQ7nALdwz1XvcauQRzGOmay8UWLiYUNw+z1AHChep 2mQNtCDmrth6cPAA== To: Peter Zijlstra Cc: LKML , Frederic Weisbecker , Paul McKenney , Sebastian Andrzej Siewior , Arnd Bergmann , "James E.J. Bottomley" , Helge Deller , linux-parisc@vger.kernel.org, Yoshinori Sato , Rich Felker , linux-sh@vger.kernel.org, Jeff Dike , Richard Weinberger , Anton Ivanov , linux-um@lists.infradead.org, Russell King , Marc Zyngier , Valentin Schneider , linux-arm-kernel@lists.infradead.org, Catalin Marinas , Will Deacon Subject: Re: [patch 10/19] preempt: Cleanup the macro maze a bit In-Reply-To: <20201116121748.GD3121378@hirez.programming.kicks-ass.net> References: <20201113140207.499353218@linutronix.de> <20201113141733.864469886@linutronix.de> <20201116121748.GD3121378@hirez.programming.kicks-ass.net> Date: Mon, 16 Nov 2020 18:42:19 +0100 Message-ID: <871rgtyz9g.fsf@nanos.tec.linutronix.de> MIME-Version: 1.0 Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: linux-parisc@vger.kernel.org On Mon, Nov 16 2020 at 13:17, Peter Zijlstra wrote: > On Fri, Nov 13, 2020 at 03:02:17PM +0100, Thomas Gleixner wrote: > >> -#define irq_count() (preempt_count() & (HARDIRQ_MASK | SOFTIRQ_MASK \ >> - | NMI_MASK)) >> +#define irq_count() (nmi_count() | hardirq_count() | softirq_count()) > > >> +#define in_task() (!(in_nmi() | in_hardirq() | in_serving_softirq())) >> -#define in_task() (!(preempt_count() & \ >> - (NMI_MASK | HARDIRQ_MASK | SOFTIRQ_OFFSET))) > > How horrible is the code-gen? Because preempt_count() is > raw_cpu_read_4() and at least some old compilers will refuse to CSE it > (consider the this_cpu_read_stable mess). I looked at gcc8 and 10 output and the compilers are smart enough to fold it for the !RT case. But yeah ... Thanks, tglx From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 85353C61DD8 for ; Mon, 16 Nov 2020 17:49:13 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id EC4A320B80 for ; Mon, 16 Nov 2020 17:49:12 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="QKM1GRXl"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="PqcZ12uW"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linutronix.de header.i=@linutronix.de header.b="ucTY/LVv"; dkim=permerror (0-bit key) header.d=linutronix.de header.i=@linutronix.de header.b="YP2D9OKy" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org EC4A320B80 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linutronix.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:References:In-Reply-To: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=TvknMD8W57TAQbmFlq8tqvtEpDlrjFqKLgeDZaQ5OVo=; b=QKM1GRXlSXkYmTpkhcRE+BdoS Byo1oSxt+1FmGD2k6qhXq2UU5IS9yjxr2WNcwUTpguA/ElGuJaR/ckgDaCnDngxCKNg859cpoii+e eBQhhLAfkScNcjG69wrkg7o1pDqZx1fAL6Z+4ysKYUwxsX4amhZRcR+gUEHdBSDQrf2psOmDarypM qJ8FlukI1J2HjNlAiB7JlCVa/dJ896uZENtT+1ygrfUiC8EV800JePqLedJceC5y9uamruXQQsk1Y eg2CAV/Jmg28x3drLSYQPngdhxat0OqIjpZXOBvfmDXaiV67qfoOjKUkusD5e4uFnGMwb861+zE0O X8iPUlYPw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1keiai-0006yc-9r; Mon, 16 Nov 2020 17:47:00 +0000 Received: from casper.infradead.org ([2001:8b0:10b:1236::1]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1keiWW-0004ae-9m; Mon, 16 Nov 2020 17:42:40 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=Content-Type:MIME-Version:Message-ID: Date:References:In-Reply-To:Subject:Cc:To:From:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=AFtB0Ip6R2EINkfby885/eXKxzn7nAYtOiaas7ShpD8=; b=PqcZ12uW1wYubRTe/DBylU7qP2 AOCaSPD1X3ZpASJhWG95XdQdg+kEtTrxO1bOPT2c3nkz6PelKukdYuCTWGIJvbWxPuI1HHXc8Pj/r aOO8mHzO0vG/n1Bhl5fKoImAhk6dw9mUcwPdVMwE6i22wiWrveIAfO4lOCavfMhlQ6HupzvLRz3RO WEledEb1diIlkA+H3rQW44lwsDyBm135p/jdZH0hUCeopNWnkUH9QzVeHekffCmJpz28+jd0w5yiJ 7RA7735Q2pG5ZhWFG2Df7BKH+f0+yCTmsomHsf+s9j8CKYrZCDgYmdlkSSLabMdW14uVPTuXf3JdI X0/CliDw==; Received: from galois.linutronix.de ([2a0a:51c0:0:12e:550::1]) by casper.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1keiWQ-0001P8-CN; Mon, 16 Nov 2020 17:42:38 +0000 From: Thomas Gleixner DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1605548539; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=AFtB0Ip6R2EINkfby885/eXKxzn7nAYtOiaas7ShpD8=; b=ucTY/LVv679/wmtLVFj1aWd9sEHqvK298xZYswCwYCPhN8K6/VsSRE7jSBhfryBTJ6Xaec iWZ1KD8vwfG36MTBmhGHCbsUbS3UqdYPBCdHIrK4tFOGGv3o73NqScfF+IuVD7Lx5wNJ4E ct+pvkYNxgjuYfF6W+3H6JhdZW9rLmVSMnAqbJjz3eaXA1ppi8L0brIci6nAcqGV/SzjpO d55eUUUn6T/bNSl1Z/8Nge63sZYpmCqmJJI8znPpt3TuS881D+s7KtqNUyS/qzsi4xUqQ4 RlAO3412YsCCAu+hJz3yg2rDEig4KmlERzF8sx2R4lQkRAVmN9SJ/UqOp1+QOQ== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1605548539; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=AFtB0Ip6R2EINkfby885/eXKxzn7nAYtOiaas7ShpD8=; b=YP2D9OKyBiwGPh1cJ4lErNx/TU9tcJQ7nALdwz1XvcauQRzGOmay8UWLiYUNw+z1AHChep 2mQNtCDmrth6cPAA== To: Peter Zijlstra Subject: Re: [patch 10/19] preempt: Cleanup the macro maze a bit In-Reply-To: <20201116121748.GD3121378@hirez.programming.kicks-ass.net> References: <20201113140207.499353218@linutronix.de> <20201113141733.864469886@linutronix.de> <20201116121748.GD3121378@hirez.programming.kicks-ass.net> Date: Mon, 16 Nov 2020 18:42:19 +0100 Message-ID: <871rgtyz9g.fsf@nanos.tec.linutronix.de> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201116_174234_930929_D736C718 X-CRM114-Status: UNSURE ( 9.10 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Marc Zyngier , Rich Felker , Catalin Marinas , Paul McKenney , Arnd Bergmann , linux-sh@vger.kernel.org, Richard Weinberger , Frederic Weisbecker , Valentin Schneider , Jeff Dike , LKML , Yoshinori Sato , "James E.J. Bottomley" , linux-parisc@vger.kernel.org, Helge Deller , Russell King , linux-um@lists.infradead.org, Will Deacon , Sebastian Andrzej Siewior , linux-arm-kernel@lists.infradead.org, Anton Ivanov Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Nov 16 2020 at 13:17, Peter Zijlstra wrote: > On Fri, Nov 13, 2020 at 03:02:17PM +0100, Thomas Gleixner wrote: > >> -#define irq_count() (preempt_count() & (HARDIRQ_MASK | SOFTIRQ_MASK \ >> - | NMI_MASK)) >> +#define irq_count() (nmi_count() | hardirq_count() | softirq_count()) > > >> +#define in_task() (!(in_nmi() | in_hardirq() | in_serving_softirq())) >> -#define in_task() (!(preempt_count() & \ >> - (NMI_MASK | HARDIRQ_MASK | SOFTIRQ_OFFSET))) > > How horrible is the code-gen? Because preempt_count() is > raw_cpu_read_4() and at least some old compilers will refuse to CSE it > (consider the this_cpu_read_stable mess). I looked at gcc8 and 10 output and the compilers are smart enough to fold it for the !RT case. But yeah ... Thanks, tglx _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel