From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, UNPARSEABLE_RELAY,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1F562C433E0 for ; Thu, 16 Jul 2020 20:30:58 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E37EA207E8 for ; Thu, 16 Jul 2020 20:30:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726442AbgGPUa4 (ORCPT ); Thu, 16 Jul 2020 16:30:56 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47170 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725921AbgGPUax (ORCPT ); Thu, 16 Jul 2020 16:30:53 -0400 Received: from bhuna.collabora.co.uk (bhuna.collabora.co.uk [IPv6:2a00:1098:0:82:1000:25:2eeb:e3e3]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 951CFC061755; Thu, 16 Jul 2020 13:30:53 -0700 (PDT) Received: from [127.0.0.1] (localhost [127.0.0.1]) (Authenticated sender: krisman) with ESMTPSA id EA6E62A5A65 From: Gabriel Krisman Bertazi To: Christian Brauner Cc: Kees Cook , Andy Lutomirski , Matthew Wilcox , tglx@linutronix.de, linux-kernel@vger.kernel.org, kernel@collabora.com, gofmanp@gmail.com, linux-api@vger.kernel.org, x86@kernel.org, linux-kselftest@vger.kernel.org, shuah@kernel.org, jannh@google.com Subject: Re: [PATCH v4 0/2] Syscall User Redirection Organization: Collabora References: <20200716193141.4068476-1-krisman@collabora.com> <202007161300.7452A2C5@keescook> <20200716202234.wryj7pj7zmwcrxxx@wittgenstein> <202007161324.E75E01B@keescook> <20200716202935.yorxrz2om67r366x@wittgenstein> Date: Thu, 16 Jul 2020 16:30:48 -0400 In-Reply-To: <20200716202935.yorxrz2om67r366x@wittgenstein> (Christian Brauner's message of "Thu, 16 Jul 2020 22:29:35 +0200") Message-ID: <871rlbjj7r.fsf@collabora.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Christian Brauner writes: > On Thu, Jul 16, 2020 at 01:25:43PM -0700, Kees Cook wrote: >> On Thu, Jul 16, 2020 at 10:22:34PM +0200, Christian Brauner wrote: >> > On Thu, Jul 16, 2020 at 01:04:38PM -0700, Kees Cook wrote: >> > > On Thu, Jul 16, 2020 at 03:31:39PM -0400, Gabriel Krisman Bertazi wrote: >> > > > This is v4 of Syscall User Redirection. The implementation itself is >> > > > not modified from v3, it only applies the latest round of reviews to the >> > > > selftests. >> > > > >> > > > __NR_syscalls is not really exported in header files other than >> > > > asm-generic for every architecture, so it felt safer to optionally >> > > > expose it with a fallback to a high value. >> > > > >> > > > Also, I didn't expose tests for PR_GET as that is not currently >> > > > implemented. If possible, I'd have it supported by a future patchset, >> > > > since it is not immediately necessary to support this feature. >> > > >> > > Thanks! That all looks good to me. >> > >> > Don't have any problem with this but did this ever get exposure on >> > linux-api? This is the first time I see this pop up. >> >> I thought I'd added it to CC in the past, but that might have been other >> recent unrelated threads. Does this need a full repost there too, you >> think? > > Nah, wasn't my intention to force a repost. Seems that several people > have looked this over. :) Just curious why it didn't get to linux-api > and we know quite some people who only do look at linux-api (for sanity). :) That's my mistake. I didn't think about it when submitting :( If this get re-spinned again I will make sure to CC linux-api. -- Gabriel Krisman Bertazi