All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Alex Bennée" <alex.bennee@linaro.org>
To: Robert Foley <robert.foley@linaro.org>
Cc: "Peter Puhov" <peter.puhov@linaro.org>,
	"Philippe Mathieu-Daudé" <philmd@redhat.com>,
	qemu-devel@nongnu.org
Subject: Re: [PATCH v2 00/14] tests/vm: Add support for aarch64 VMs
Date: Tue, 03 Mar 2020 10:24:31 +0000	[thread overview]
Message-ID: <871rq991nk.fsf@linaro.org> (raw)
In-Reply-To: <CAEyhzFt=KsNn_rdJegbzJ_PgNVb6oAVL3aDvaO2VdkrFQ1-Gvw@mail.gmail.com>


Robert Foley <robert.foley@linaro.org> writes:

> On Mon, 2 Mar 2020 at 11:38, Alex Bennée <alex.bennee@linaro.org> wrote:
>>
>>
>> Robert Foley <robert.foley@linaro.org> writes:
>>
>> > This is version 2 of the patch series to
>> > add support for aarch64 VMs.
>> >  - Ubuntu 18.04 aarch64 VM
>> >  - CentOS 8 aarch64 VM
>>
>> For now I've pulled the first 5 patches into testing/next as they are
>> obvious clean-ups.
>>
>> >   tests/vm: Add workaround to consume console
>>
>> I still have concerns about this approach but I'm going to give it some
>> more testing.
>
> We are happy to make any adjustments here.  Our first set of
> refactoring here was
> aimed at making it more pythonic.  Is this where the concerns are?

I'm just worried about the fragility of multiple steps in the chain of
io we are snooping on. That said Phillipe made a reasonable point that
other tools could be used - QMP for example would be the way to check
the status of the network connection before we trigger ssh rather than
the current busy-timeout approach. However that would result in more
complexity so if what works is stable...*shrug*

>> However I ran into problems testing on my aarch64 box
>> because of a missing gen-iso-image which makes me think we need to add
>> some gating via configure for tools and libraries we need.
>
> Should we error out in configure if the tools and libraries needed to build the
> VMs are not there?
> Or maybe tolerate these dependencies not being there at configure time and
> provide an error later when someone tries to vm-build these VMs?

We currently do both ;-)

When we can detect at configure time and skip in make we do - see
tests/docker/Makefile.include and the compiler tests for tests/tcg.
However the acceptance tests current use runtime decorators in python to
detect as we go - but that test framework prints a summary and doesn't
exit -1 to the rest of make if it skips something. 

> Just curious which approach we should pursue here.

Have a look at:

  Subject: [PATCH  v1 00/10] testing/next updates (tweaks and re-greening)
  Date: Mon,  2 Mar 2020 18:18:57 +0000
  Message-Id: <20200302181907.32110-1-alex.bennee@linaro.org>

and see what you think.

>
>
> Thanks & Regards,
> -Rob


-- 
Alex Bennée


  reply	other threads:[~2020-03-03 10:30 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-19 16:35 [PATCH v2 00/14] tests/vm: Add support for aarch64 VMs Robert Foley
2020-02-19 16:35 ` [PATCH v2 01/14] tests/vm: use $(PYTHON) consistently Robert Foley
2020-02-19 16:35 ` [PATCH v2 02/14] tests/vm: Debug mode shows ssh output Robert Foley
2020-02-19 16:35 ` [PATCH v2 03/14] tests/vm: increased max timeout for vm boot Robert Foley
2020-02-19 16:35 ` [PATCH v2 04/14] tests/vm: give wait_ssh() option to wait for root Robert Foley
2020-02-19 16:35 ` [PATCH v2 05/14] tests/vm: Added gen_cloud_init_iso() to basevm.py Robert Foley
2020-02-19 16:35 ` [PATCH v2 06/14] tests/vm: Add workaround to consume console Robert Foley
2020-02-19 16:35 ` [PATCH v2 07/14] tests/vm: Add configuration to basevm.py Robert Foley
2020-02-19 16:35 ` [PATCH v2 08/14] tests/vm: Added configuration file support Robert Foley
2020-02-19 16:35 ` [PATCH v2 09/14] tests/vm: add --boot-console switch Robert Foley
2020-02-19 16:35 ` [PATCH v2 10/14] tests/vm: Add ability to select QEMU from current build Robert Foley
2020-02-19 16:35 ` [PATCH v2 11/14] tests/vm: allow wait_ssh() to specify command Robert Foley
2020-02-19 16:35 ` [PATCH v2 12/14] tests/vm: Added a new script for ubuntu.aarch64 Robert Foley
2020-02-19 16:35 ` [PATCH v2 13/14] tests/vm: Added a new script for centos.aarch64 Robert Foley
2020-02-19 16:35 ` [PATCH v2 14/14] tests/vm: change scripts to use self._config Robert Foley
2020-03-02 16:38 ` [PATCH v2 00/14] tests/vm: Add support for aarch64 VMs Alex Bennée
2020-03-02 21:23   ` Robert Foley
2020-03-03 10:24     ` Alex Bennée [this message]
2020-03-03 15:02       ` Robert Foley

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=871rq991nk.fsf@linaro.org \
    --to=alex.bennee@linaro.org \
    --cc=peter.puhov@linaro.org \
    --cc=philmd@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=robert.foley@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.