All of lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Korsgaard <peter@korsgaard.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 2/2] package/git: fix build failure due to gcc bug 93847
Date: Wed, 26 Feb 2020 23:22:08 +0100	[thread overview]
Message-ID: <871rqh56r3.fsf@dell.be.48ers.dk> (raw)
In-Reply-To: <20200220154004.126384-2-giulio.benetti@benettiengineering.com> (Giulio Benetti's message of "Thu, 20 Feb 2020 16:40:04 +0100")

>>>>> "Giulio" == Giulio Benetti <giulio.benetti@benettiengineering.com> writes:

 > The git package exhibits gcc bug 93847 when built for the Nios2
 > architecture with optimization enabled, which causes a build failure.

 > As done for other packages in Buildroot work around this gcc bug by
 > setting optimization to -O0 if BR2_TOOLCHAIN_HAS_GCC_BUG_93847=y.

 > Fixes:
 > http://autobuild.buildroot.net/results/e22/e225e62ea2d48660df4110790664f0c3306c1ea9/

 > Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
 > ---
 >  package/git/git.mk | 2 +-
 >  1 file changed, 1 insertion(+), 1 deletion(-)

 > diff --git a/package/git/git.mk b/package/git/git.mk
 > index a5c8669fc9..f32a2f8eb9 100644
 > --- a/package/git/git.mk
 > +++ b/package/git/git.mk
 > @@ -67,7 +67,7 @@ endif
 
 >  GIT_CFLAGS = $(TARGET_CFLAGS)
 
 > -ifeq ($(BR2_TOOLCHAIN_HAS_GCC_BUG_85180),y)
 > +ifeq ($(BR2_TOOLCHAIN_HAS_GCC_BUG_85180)$(BR2_TOOLCHAIN_HAS_GCC_BUG_93847),y)

This fails for a (hypothetical) toolchain affected by both issues,
perhaps something like this would be better?

ifneq ($(BR2_TOOLCHAIN_HAS_GCC_BUG_85180)$(BR2_TOOLCHAIN_HAS_GCC_BUG_93847),)

-- 
Bye, Peter Korsgaard

  parent reply	other threads:[~2020-02-26 22:22 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-20 15:40 [Buildroot] [PATCH 1/2] toolchain: introduce BR2_TOOLCHAIN_HAS_GCC_BUG_93847 Giulio Benetti
2020-02-20 15:40 ` [Buildroot] [PATCH 2/2] package/git: fix build failure due to gcc bug 93847 Giulio Benetti
2020-02-26 21:15   ` Thomas Petazzoni
2020-02-26 22:22   ` Peter Korsgaard [this message]
2020-02-27  8:17     ` Thomas Petazzoni
2020-02-27 11:20       ` Giulio Benetti
2020-02-27 21:15     ` Yann E. MORIN
2020-02-27 21:42       ` Peter Korsgaard
2020-02-26 21:15 ` [Buildroot] [PATCH 1/2] toolchain: introduce BR2_TOOLCHAIN_HAS_GCC_BUG_93847 Thomas Petazzoni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=871rqh56r3.fsf@dell.be.48ers.dk \
    --to=peter@korsgaard.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.