From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CEB56C2BCA1 for ; Fri, 7 Jun 2019 18:43:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A2B8B208C0 for ; Fri, 7 Jun 2019 18:43:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731926AbfFGSnP (ORCPT ); Fri, 7 Jun 2019 14:43:15 -0400 Received: from mx1.redhat.com ([209.132.183.28]:48226 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729449AbfFGSnP (ORCPT ); Fri, 7 Jun 2019 14:43:15 -0400 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 19B81308FC4E; Fri, 7 Jun 2019 18:43:15 +0000 (UTC) Received: from oldenburg2.str.redhat.com (ovpn-116-64.ams2.redhat.com [10.36.116.64]) by smtp.corp.redhat.com (Postfix) with ESMTPS id D2AD27856D; Fri, 7 Jun 2019 18:43:05 +0000 (UTC) From: Florian Weimer To: Linus Torvalds Cc: Joseph Myers , Arnd Bergmann , Linux API , linux-arch , Netdev , Laura Abbott , Paul Burton , Deepa Dinamani , Linux List Kernel Mailing Subject: Re: [PATCH] uapi: avoid namespace conflict in linux/posix_types.h References: <20190319165123.3967889-1-arnd@arndb.de> <87tvd2j9ye.fsf@oldenburg2.str.redhat.com> Date: Fri, 07 Jun 2019 20:43:03 +0200 In-Reply-To: (Linus Torvalds's message of "Fri, 7 Jun 2019 11:27:57 -0700") Message-ID: <871s05fd8o.fsf@oldenburg2.str.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.43]); Fri, 07 Jun 2019 18:43:15 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Linus Torvalds: > If we're changing kernel header files, it's easy enough to change the > kernel users. I'd be more worried about user space that *uses* that > thing, and currently accesses 'val[]' by name. > > So the patch looks a bit odd to me. How are people supposed to use > fsid_t if they can't look at it? The problem is that the header was previously not used pervasively in userspace headers. See commit a623a7a1a5670c25a16881f5078072d272d96b71 ("y2038: fix socket.h header inclusion"). Very little code needed it before. On the glibc side, we nowadays deal with this by splitting headers further. (We used to suppress definitions with macros, but that tended to become convoluted.) In this case, moving the definition of __kernel_long_t to its own header, so that include/uapi/asm-generic/socket.h can include that should fix it. > So now that I _do_ see the patch, there's no way I'll apply it. Fair enough. Thanks, Florian