From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 30A31C282CE for ; Tue, 4 Jun 2019 12:50:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 08415249A2 for ; Tue, 4 Jun 2019 12:50:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727842AbfFDMux (ORCPT ); Tue, 4 Jun 2019 08:50:53 -0400 Received: from mga17.intel.com ([192.55.52.151]:46426 "EHLO mga17.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727567AbfFDMux (ORCPT ); Tue, 4 Jun 2019 08:50:53 -0400 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 04 Jun 2019 05:50:53 -0700 X-ExtLoop1: 1 Received: from jnikula-mobl3.fi.intel.com (HELO localhost) ([10.237.66.150]) by fmsmga001.fm.intel.com with ESMTP; 04 Jun 2019 05:50:50 -0700 From: Jani Nikula To: Masahiro Yamada , linux-kbuild@vger.kernel.org Cc: Randy Dunlap , Arnd Bergmann , David Howells , Sam Ravnborg , Masahiro Yamada , Michal Marek , linux-kernel@vger.kernel.org Subject: Re: [PATCH 14/15] fixup: kbuild: add support for ensuring headers are self-contained In-Reply-To: <20190604101409.2078-15-yamada.masahiro@socionext.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: <20190604101409.2078-1-yamada.masahiro@socionext.com> <20190604101409.2078-15-yamada.masahiro@socionext.com> Date: Tue, 04 Jun 2019 15:53:57 +0300 Message-ID: <871s094il6.fsf@intel.com> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 04 Jun 2019, Masahiro Yamada wrote: > This is needed to avoid regeneration of header-test C files. > > This will go away when Jani send v2. Done, in reply to patch 13. Thanks, Jani. > > Signed-off-by: Masahiro Yamada > --- > > scripts/Makefile.build | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/scripts/Makefile.build b/scripts/Makefile.build > index 2b4d56483c2e..067e98628664 100644 > --- a/scripts/Makefile.build > +++ b/scripts/Makefile.build > @@ -298,10 +298,9 @@ $(obj)/%.lst: $(src)/%.c FORCE > # --------------------------------------------------------------------------- > > quiet_cmd_header_test = HDRTEST $@ > - cmd_header_test = echo "\#include \"$( $@ > + cmd_header_test = echo "\#include \"$*.h\"" > $@ > > -# FIXME: would be nice to be able to limit this implicit rule to header-test-y > -$(obj)/%.header_test.c: $(src)/%.h FORCE > +$(obj)/%.header_test.c: > $(call if_changed,header_test) > > # Compile assembler sources (.S) -- Jani Nikula, Intel Open Source Graphics Center From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga17.intel.com ([192.55.52.151]:46426 "EHLO mga17.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727567AbfFDMux (ORCPT ); Tue, 4 Jun 2019 08:50:53 -0400 From: Jani Nikula Subject: Re: [PATCH 14/15] fixup: kbuild: add support for ensuring headers are self-contained In-Reply-To: <20190604101409.2078-15-yamada.masahiro@socionext.com> References: <20190604101409.2078-1-yamada.masahiro@socionext.com> <20190604101409.2078-15-yamada.masahiro@socionext.com> Date: Tue, 04 Jun 2019 15:53:57 +0300 Message-ID: <871s094il6.fsf@intel.com> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kbuild-owner@vger.kernel.org List-ID: To: Masahiro Yamada , linux-kbuild@vger.kernel.org Cc: Randy Dunlap , Arnd Bergmann , David Howells , Sam Ravnborg , Michal Marek , linux-kernel@vger.kernel.org On Tue, 04 Jun 2019, Masahiro Yamada wrote: > This is needed to avoid regeneration of header-test C files. > > This will go away when Jani send v2. Done, in reply to patch 13. Thanks, Jani. > > Signed-off-by: Masahiro Yamada > --- > > scripts/Makefile.build | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/scripts/Makefile.build b/scripts/Makefile.build > index 2b4d56483c2e..067e98628664 100644 > --- a/scripts/Makefile.build > +++ b/scripts/Makefile.build > @@ -298,10 +298,9 @@ $(obj)/%.lst: $(src)/%.c FORCE > # --------------------------------------------------------------------------- > > quiet_cmd_header_test = HDRTEST $@ > - cmd_header_test = echo "\#include \"$( $@ > + cmd_header_test = echo "\#include \"$*.h\"" > $@ > > -# FIXME: would be nice to be able to limit this implicit rule to header-test-y > -$(obj)/%.header_test.c: $(src)/%.h FORCE > +$(obj)/%.header_test.c: > $(call if_changed,header_test) > > # Compile assembler sources (.S) -- Jani Nikula, Intel Open Source Graphics Center