From: Jani Nikula <jani.nikula@linux.intel.com>
To: Lucas De Marchi <lucas.demarchi@intel.com>,
intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 0/3] Do not re-read dpll registers
Date: Fri, 22 Mar 2019 11:25:43 +0200 [thread overview]
Message-ID: <871s2zclbc.fsf@intel.com> (raw)
In-Reply-To: <20190321220257.32638-1-lucas.demarchi@intel.com>
On Thu, 21 Mar 2019, Lucas De Marchi <lucas.demarchi@intel.com> wrote:
> Instead of re-reading the registers we just read on the hw state
> readout, use the values saved on intel_shared_dpll. Besides not doing
> the MMIO, this helps on sharing code since we don't have to
> differentiate e.g. ICL and CNL because they have different registers for
> the same thing.
>
> I'm a little hesitant wrt DSI. It seems we have completly different
> implementations for ICL and gen <= 11.
That's obviously a typo, ICL being gen 11 and introducing the new DSI
hardware and requiring a completely different implementation.
> BXT has another hook so is not affected, but I'm not sure if we have
> any other gens with DSI that share the skl hooks.
VLV/CHV/BXT/GLK all have their own DSI PLL stuff. ICL or gen 11 is the
divider.
BR,
Jani.
--
Jani Nikula, Intel Open Source Graphics Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2019-03-22 9:25 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-21 22:02 [PATCH 0/3] Do not re-read dpll registers Lucas De Marchi
2019-03-21 22:02 ` [PATCH 1/3] drm/i915/skl: use previous pll hw readout Lucas De Marchi
2019-03-22 13:05 ` Ville Syrjälä
2019-03-21 22:02 ` [PATCH 2/3] drm/i915/cnl: " Lucas De Marchi
2019-03-22 13:09 ` Ville Syrjälä
2019-03-21 22:02 ` [PATCH 3/3] drm/i915/icl: " Lucas De Marchi
2019-03-22 13:09 ` Ville Syrjälä
2019-03-22 19:50 ` Lucas De Marchi
2019-03-22 20:15 ` Ville Syrjälä
2019-03-22 20:42 ` Lucas De Marchi
2019-03-22 1:37 ` ✗ Fi.CI.CHECKPATCH: warning for Do not re-read dpll registers Patchwork
2019-03-22 2:05 ` ✓ Fi.CI.BAT: success " Patchwork
2019-03-22 9:25 ` Jani Nikula [this message]
2019-03-22 18:38 ` ✗ Fi.CI.IGT: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=871s2zclbc.fsf@intel.com \
--to=jani.nikula@linux.intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=lucas.demarchi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.