From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C8887C32788 for ; Thu, 11 Oct 2018 10:46:51 +0000 (UTC) Received: from lists.ozlabs.org (unknown [203.11.71.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4314120659 for ; Thu, 11 Oct 2018 10:46:51 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4314120659 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ellerman.id.au Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Received: from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 42W7206704zF3Fg for ; Thu, 11 Oct 2018 21:46:48 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; dmarc=none (p=none dis=none) header.from=ellerman.id.au Received: from ozlabs.org (bilbo.ozlabs.org [203.11.71.1]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 42W6zQ3Jq5zF35P for ; Thu, 11 Oct 2018 21:44:34 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; dmarc=none (p=none dis=none) header.from=ellerman.id.au Received: from authenticated.ozlabs.org (localhost [127.0.0.1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPSA id 42W6zP6gGzz9s4Z; Thu, 11 Oct 2018 21:44:33 +1100 (AEDT) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=ellerman.id.au From: Michael Ellerman To: Joel Stanley , linuxppc-dev@lists.ozlabs.org Subject: Re: [PATCH v3] powerpc/Makefile: Fix PPC_BOOK3S_64 ASFLAGS In-Reply-To: <20181011024303.23921-1-joel@jms.id.au> References: <20181011024303.23921-1-joel@jms.id.au> Date: Thu, 11 Oct 2018 21:44:29 +1100 Message-ID: <871s8w3gqa.fsf@concordia.ellerman.id.au> MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Nick Desaulniers , Nicholas Piggin Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" Joel Stanley writes: > Ever since commit 15a3204d24a3 ("powerpc/64s: Set assembler machine type > to POWER4") we force -mpower4 to be passed to the assembler irrespective > of the CFLAGS used. ... > > By explicitly setting -many we can build with Clang and GCC while > retaining the -mpower4 option. > > Signed-off-by: Joel Stanley > --- > Following up on: > https://lore.kernel.org/linuxppc-dev/20180914040649.1794-2-joel@jms.id.au/ > https://lore.kernel.org/linuxppc-dev/20180821010203.23213-1-anton@ozlabs.org/ > > mpe, please trim the commit message if you think it's a bit verbose I thought it was bit short :P > We could test for these flags in case -many is removed in the future, > but if an assembler does not support -many then -mpower4 will probably > break it anyway. Yeah that's OK, breaking hypothetical future toolchains is fine. cheers