From: Peter Korsgaard <peter@korsgaard.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] pkg-generic: error out with 'local' site method and no _SITE
Date: Tue, 22 May 2018 23:20:40 +0200 [thread overview]
Message-ID: <871se31j6f.fsf@dell.be.48ers.dk> (raw)
In-Reply-To: <9ba18873-320c-0296-e2be-94f00d180ac4@mind.be> (Arnout Vandecappelle's message of "Tue, 22 May 2018 12:41:33 +0200")
>>>>> "Arnout" == Arnout Vandecappelle <arnout@mind.be> writes:
> On 19-05-18 10:38, Thomas Petazzoni wrote:
>> Hello,
>>
>> On Fri, 18 May 2018 12:45:24 +0200, Arnout Vandecappelle
>> (Essensium/Mind) wrote:
>>
>>> +ifeq ($$($(2)_OVERRIDE_SRCDIR),)
>>> +$$(error $(1) has local site method, but `$(2)_SITE_METHOD` is not defined)
>>> +endif
>>
>> Are you sure it shouldn't be "$(2)_SITE" is not defined ?
> That was actually intentional. The idea is to allow 'local' packages to set
> either _SITE or _OVERRIDE_SRCDIR. The check comes after the assignment to
> _OVERRIDE_SRCDIR. The reason for this is: currently, 'local' packages work
> correctly if you set _OVERRIDE_SRCDIR instead of _SITE, and I don't see a reason
> to make them fail.
> I probably should have explained this in the commit log. It was a bit short :-)
Indeed! Will you send an update?
--
Bye, Peter Korsgaard
prev parent reply other threads:[~2018-05-22 21:20 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-18 10:45 [Buildroot] [PATCH] pkg-generic: error out with 'local' site method and no _SITE Arnout Vandecappelle
2018-05-19 8:38 ` Thomas Petazzoni
2018-05-22 10:41 ` Arnout Vandecappelle
2018-05-22 21:20 ` Peter Korsgaard [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=871se31j6f.fsf@dell.be.48ers.dk \
--to=peter@korsgaard.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.