From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jani Nikula Subject: Re: [RFC v2 2/2] drm/i915/gmbus: Enable burst read Date: Fri, 13 Apr 2018 15:55:56 +0300 Message-ID: <871sfjfeoz.fsf@intel.com> References: <1523546992-20762-3-git-send-email-ramalingam.c@intel.com> <1523548876-22449-1-git-send-email-ramalingam.c@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by gabe.freedesktop.org (Postfix) with ESMTPS id 89E366EAFB for ; Fri, 13 Apr 2018 12:55:11 +0000 (UTC) In-Reply-To: <1523548876-22449-1-git-send-email-ramalingam.c@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Ramalingam C , intel-gfx@lists.freedesktop.org, daniel@ffwll.ch, chris@chris-wilson.co.uk, rodrigo.vivi@intel.com, ville.syrjala@linux.intel.com List-Id: intel-gfx@lists.freedesktop.org T24gVGh1LCAxMiBBcHIgMjAxOCwgUmFtYWxpbmdhbSBDIDxyYW1hbGluZ2FtLmNAaW50ZWwuY29t PiB3cm90ZToKPiBTdXBwb3J0IGZvciBCdXJzdCByZWFkIGluIEhXIGlzIGFkZGVkIGZvciBIRENQ Mi4yIGNvbXBsaWFuY2UKPiByZXF1aXJlbWVudC4KPgo+IFRoaXMgcGF0Y2ggZW5hYmxlcyB0aGUg YnVyc3QgcmVhZCBmb3IgYWxsIHRoZSBnbWJ1cyByZWFkIG9mIG1vcmUgdGhhbgo+IDUxMUJ5dGVz LCBvbiBjYXBhYmxlIHBsYXRmb3Jtcy4KPgo+IHYyOgo+ICAgRXh0cmEgbGluZSBpcyByZW1vdmVk Lgo+Cj4gU2lnbmVkLW9mZi1ieTogUmFtYWxpbmdhbSBDIDxyYW1hbGluZ2FtLmNAaW50ZWwuY29t Pgo+IC0tLQo+ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X3JlZy5oICB8ICAxICsKPiAgZHJp dmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfaTJjLmMgfCAzOCArKysrKysrKysrKysrKysrKysrKysr KysrKysrKysrKysrLS0tLQo+ICAyIGZpbGVzIGNoYW5nZWQsIDM1IGluc2VydGlvbnMoKyksIDQg ZGVsZXRpb25zKC0pCj4KPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9y ZWcuaCBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfcmVnLmgKPiBpbmRleCA0ZjU4M2RhMGNl ZTkuLjBlZjE2MmVlOWNlMCAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1 X3JlZy5oCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9yZWcuaAo+IEBAIC0yOTg0 LDYgKzI5ODQsNyBAQCBlbnVtIGk5MTVfcG93ZXJfd2VsbF9pZCB7Cj4gICNkZWZpbmUgICBHTUJV U19SQVRFXzQwMEtIWgkoMjw8OCkgLyogcmVzZXJ2ZWQgb24gUGluZXZpZXcgKi8KPiAgI2RlZmlu ZSAgIEdNQlVTX1JBVEVfMU1IWgkoMzw8OCkgLyogcmVzZXJ2ZWQgb24gUGluZXZpZXcgKi8KPiAg I2RlZmluZSAgIEdNQlVTX0hPTERfRVhUCSgxPDw3KSAvKiAzMDBucyBob2xkIHRpbWUsIHJzdmQg b24gUGluZXZpZXcgKi8KPiArI2RlZmluZSAgIEdNQlVTX0JZVEVfQ05UX09WRVJSSURFICgxPDw2 KQo+ICAjZGVmaW5lICAgR01CVVNfUElOX0RJU0FCTEVECTAKPiAgI2RlZmluZSAgIEdNQlVTX1BJ Tl9TU0MJCTEKPiAgI2RlZmluZSAgIEdNQlVTX1BJTl9WR0FEREMJMgo+IGRpZmYgLS1naXQgYS9k cml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9pMmMuYyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2lu dGVsX2kyYy5jCj4gaW5kZXggN2U5MmM3OTM0NjU3Li4yZWU5Y2YyZWZmY2QgMTAwNjQ0Cj4gLS0t IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfaTJjLmMKPiArKysgYi9kcml2ZXJzL2dwdS9k cm0vaTkxNS9pbnRlbF9pMmMuYwo+IEBAIC0zNjQsMTIgKzM2NCwyNCBAQCBnbWJ1c193YWl0X2lk bGUoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2KQo+ICBzdGF0aWMgaW50Cj4gIGdt YnVzX3hmZXJfcmVhZF9jaHVuayhzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYsCj4g IAkJICAgICAgdW5zaWduZWQgc2hvcnQgYWRkciwgdTggKmJ1ZiwgdW5zaWduZWQgaW50IGxlbiwK PiAtCQkgICAgICB1MzIgZ21idXMxX2luZGV4KQo+ICsJCSAgICAgIHUzMiBnbWJ1czFfaW5kZXgs IGJvb2wgYnVyc3RfcmVhZCkKCkkgdGhpbmsgeW91IGNvdWxkIHRocm93IG91dCB0aGUgYnVyc3Rf cmVhZCBwYXJhbWV0ZXIuIFNlZSBiZWxvdy4KCj4gIHsKPiArCXVuc2lnbmVkIGludCBieXRlc19h Zl9vdmVycmlkZSwgc2l6ZTsKPiArCj4gKwlpZiAoYnVyc3RfcmVhZCkgewo+ICsJCWJ5dGVzX2Fm X292ZXJyaWRlID0gbGVuIC0gKCgobGVuIC8gMjU2KSAtIDEpICogMjU2KTsKPiArCQlzaXplID0g Ynl0ZXNfYWZfb3ZlcnJpZGU7Cj4gKwo+ICsJCUk5MTVfV1JJVEVfRlcoR01CVVMwLCAoSTkxNV9S RUFEX0ZXKEdNQlVTMCkgfAo+ICsJCQkgICAgICBHTUJVU19CWVRFX0NOVF9PVkVSUklERSkpOwo+ ICsJfSBlbHNlIHsKPiArCQlzaXplID0gbGVuOwo+ICsJfQo+ICsKPiAgCUk5MTVfV1JJVEVfRlco R01CVVMxLAo+ICAJCSAgICAgIGdtYnVzMV9pbmRleCB8Cj4gIAkJICAgICAgR01CVVNfQ1lDTEVf V0FJVCB8Cj4gLQkJICAgICAgKGxlbiA8PCBHTUJVU19CWVRFX0NPVU5UX1NISUZUKSB8Cj4gKwkJ ICAgICAgKHNpemUgPDwgR01CVVNfQllURV9DT1VOVF9TSElGVCkgfAo+ICAJCSAgICAgIChhZGRy IDw8IEdNQlVTX1NMQVZFX0FERFJfU0hJRlQpIHwKPiAgCQkgICAgICBHTUJVU19TTEFWRV9SRUFE IHwgR01CVVNfU1dfUkRZKTsKPiAgCXdoaWxlIChsZW4pIHsKPiBAQCAtMzg1LDExICszOTcsMjMg QEAgZ21idXNfeGZlcl9yZWFkX2NodW5rKHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJp diwKPiAgCQkJKmJ1ZisrID0gdmFsICYgMHhmZjsKPiAgCQkJdmFsID4+PSA4Owo+ICAJCX0gd2hp bGUgKC0tbGVuICYmICsrbG9vcCA8IDQpOwo+ICsKPiArCQlpZiAoYnVyc3RfcmVhZCAmJiBsZW4g PT0gKGJ5dGVzX2FmX292ZXJyaWRlIC0gNCkpCj4gKwkJCUk5MTVfV1JJVEVfRlcoR01CVVMwLCAo STkxNV9SRUFEX0ZXKEdNQlVTMCkgJgo+ICsJCQkJICAgICAgfkdNQlVTX0JZVEVfQ05UX09WRVJS SURFKSk7Cj4gIAl9Cj4gIAo+ICAJcmV0dXJuIDA7Cj4gIH0KPiAgCj4gK3N0YXRpYyBib29sIGdt YnVzX2J1cnN0X3JlYWRfc3VwcG9ydGVkKHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJp dikKPiArewo+ICsJaWYgKElOVEVMX0dFTihkZXZfcHJpdikgPj0gMTAgfHwgSVNfR0VNSU5JTEFL RShkZXZfcHJpdikgfHwKPiArCSAgICBJU19LQUJZTEFLRShkZXZfcHJpdikpCj4gKwkJcmV0dXJu IHRydWU7Cj4gKwlyZXR1cm4gZmFsc2U7Cj4gK30KCk5hbWUgdGhpcyBIQVNfR01CVVNfQlVSU1Rf UkVBRCgpIGFuZCBwdXQgYmVsb3cgSEFTX0dNQlVTX0lSUSgpIGluCmk5MTVfZHJ2LmguCgo+ICsK PiAgc3RhdGljIGludAo+ICBnbWJ1c194ZmVyX3JlYWQoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUg KmRldl9wcml2LCBzdHJ1Y3QgaTJjX21zZyAqbXNnLAo+ICAJCXUzMiBnbWJ1czFfaW5kZXgpCj4g QEAgLTM5OCwxNSArNDIyLDIxIEBAIGdtYnVzX3hmZXJfcmVhZChzdHJ1Y3QgZHJtX2k5MTVfcHJp dmF0ZSAqZGV2X3ByaXYsIHN0cnVjdCBpMmNfbXNnICptc2csCj4gIAl1bnNpZ25lZCBpbnQgcnhf c2l6ZSA9IG1zZy0+bGVuOwo+ICAJdW5zaWduZWQgaW50IGxlbjsKPiAgCWludCByZXQ7Cj4gKwli b29sIGJ1cnN0X3JlYWQgPSBmYWxzZTsKPiArCj4gKwlpZiAocnhfc2l6ZSA+IEJYVF9HTUJVU19C WVRFX0NPVU5UX01BWCkKPiArCQlidXJzdF9yZWFkID0gZ21idXNfYnVyc3RfcmVhZF9zdXBwb3J0 ZWQoZGV2X3ByaXYpOwo+ICAKPiAgCWRvIHsKPiAtCQlpZiAoSU5URUxfR0VOKGRldl9wcml2KSA+ PSA5KQo+ICsJCWlmIChidXJzdF9yZWFkKQo+ICsJCQlsZW4gPSByeF9zaXplOwo+ICsJCWVsc2Ug aWYgKElOVEVMX0dFTihkZXZfcHJpdikgPj0gOSkKPiAgCQkJbGVuID0gbWluKHJ4X3NpemUsIEJY VF9HTUJVU19CWVRFX0NPVU5UX01BWCk7Cj4gIAkJZWxzZQo+ICAJCQlsZW4gPSBtaW4ocnhfc2l6 ZSwgR01CVVNfQllURV9DT1VOVF9NQVgpOwoKSWYgeW91IGFic3RyYWN0ZWQgdGhlIG1heCB0cmFu c2ZlciBsZW5ndGggaW4gdGhlIHByZXZpb3VzIHBhdGNoLCBJIHRoaW5rCnlvdSBjb3VsZCBjb25k ZW5jZSB0aGlzIGludG8gc29tZXRoaW5nIGxpa2U6CgoJCWlmIChIQVNfR01CVVNfQlVSU1RfUkVB RChkZXZfcHJpdikpCiAgICAgICAgICAgICAgICAJbGVuID0gcnhfc2l6ZTsKICAgICAgICAgICAg ICAgIGVsc2UKICAgICAgICAgICAgICAgIAlsZW4gPSBtaW4ocnhfc2l6ZSwgZ21idXNfbWF4X3hm ZXJfc2l6ZShkZXZfcHJpdikpCgpZb3UgY291bGQgdGhyb3cgYXdheSB0aGUgYnVyc3RfcmVhZCB2 YXJpYWJsZSBhbmQgcGFyYW1ldGVyIGFsdG9nZXRoZXIsCmFuZCBoYXZlIGdtYnVzX3hmZXJfcmVh ZF9jaHVuaygpIGRlY2lkZSBpbnRlcm5hbGx5IGlmIGJ1cnN0IHJlYWQgaXMgdG8KYmUgdXNlZCBi eToKCglidXJzdF9yZWFkID0gbGVuID4gZ21idXNfbWF4X3hmZXJfc2l6ZShkZXZfcHJpdik7Cgoo UG90ZW50aWFsbHkgd2l0aCBhIFdBUk5fT04oYnVyc3RfcmVhZCAmJiAhSEFTX0dNQlVTX0JVUlNU X1JFQUQoKSkgaWYKeW91IHdhbnQgdG8gYmUgcGFyYW5vaWQuKQoKQlIsCkphbmkuCgo+ICAKPiAg CQlyZXQgPSBnbWJ1c194ZmVyX3JlYWRfY2h1bmsoZGV2X3ByaXYsIG1zZy0+YWRkciwKPiAtCQkJ CQkgICAgYnVmLCBsZW4sIGdtYnVzMV9pbmRleCk7Cj4gKwkJCQkJICAgIGJ1ZiwgbGVuLCBnbWJ1 czFfaW5kZXgsIGJ1cnN0X3JlYWQpOwo+ICAJCWlmIChyZXQpCj4gIAkJCXJldHVybiByZXQ7Cgot LSAKSmFuaSBOaWt1bGEsIEludGVsIE9wZW4gU291cmNlIFRlY2hub2xvZ3kgQ2VudGVyCl9fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCkludGVsLWdmeCBtYWls aW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZy ZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeAo=