From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1755440AbdKBJQL (ORCPT <rfc822;w@1wt.eu>);
        Thu, 2 Nov 2017 05:16:11 -0400
Received: from mga14.intel.com ([192.55.52.115]:6365 "EHLO mga14.intel.com"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1754971AbdKBJQJ (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 2 Nov 2017 05:16:09 -0400
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.44,333,1505804400"; 
   d="asc'?scan'208";a="916622547"
From: Felipe Balbi <felipe.balbi@linux.intel.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Lu Baolu <baolu.lu@linux.intel.com>
Cc: "'Mathias Nyman'" <mathias.nyman@linux.intel.com>,
        "linux-usb\@vger.kernel.org" <linux-usb@vger.kernel.org>,
        "linux-kernel\@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3 2/3] usb: xhci: Add DbC support in xHCI driver
In-Reply-To: <20171102081720.GA3298@kroah.com>
References: <1504576740-11689-1-git-send-email-baolu.lu@linux.intel.com> <1504576740-11689-3-git-send-email-baolu.lu@linux.intel.com> <59FA76AA.4060602@linux.intel.com> <20171102081720.GA3298@kroah.com>
Date: Thu, 02 Nov 2017 11:15:43 +0200
Message-ID: <871slhvy68.fsf@linux.intel.com>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="=-=-=";
        micalg=pgp-sha512; protocol="application/pgp-signature"
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

--=-=-=
Content-Type: text/plain
Content-Transfer-Encoding: quoted-printable


Hi,

Greg Kroah-Hartman <gregkh@linuxfoundation.org> writes:
>> > xHCI compatible USB host controllers(i.e. super-speed USB3 controllers)
>> > can be implemented with the Debug Capability(DbC). It presents a debug
>> > device which is fully compliant with the USB framework and provides the
>> > equivalent of a very high performance full-duplex serial link. The deb=
ug
>> > capability operation model and registers interface are defined in 7.6.8
>> > of the xHCI specification, revision 1.1.
>> >
>> > The DbC debug device shares a root port with the xHCI host. By default,
>> > the debug capability is disabled and the root port is assigned to xHCI.
>> > When the DbC is enabled, the root port will be assigned to the DbC deb=
ug
>> > device, and the xHCI sees nothing on this port. This implementation us=
es
>> > a sysfs node named <dbc> under the xHCI device to manage the enabling
>> > and disabling of the debug capability.
>> >
>> > When the debug capability is enabled, it will present a debug device
>> > through the debug port. This debug device is fully compliant with the
>> > USB3 framework, and it can be enumerated by a debug host on the other
>> > end of the USB link. As soon as the debug device is configured, a TTY
>> > serial device named /dev/ttyDBC0 will be created.
>> >
>> > One use of this link is running a login service on the debug target.
>> > Hence it can be remote accessed by a debug host. Another use case can
>> > probably be found in servers. It provides a peer-to-peer USB link
>> > between two host-only machines. This provides a reasonable out-of-band
>> > communication method between two servers.
>> >
>> > Signed-off-by: Lu Baolu <baolu.lu@linux.intel.com>
>> > ---
>> >  .../ABI/testing/sysfs-bus-pci-drivers-xhci_hcd     |   25 +
>> >  drivers/usb/host/Kconfig                           |    9 +
>> >  drivers/usb/host/Makefile                          |    5 +
>> >  drivers/usb/host/xhci-dbgcap.c                     | 1016 +++++++++++=
+++++++++
>> >  drivers/usb/host/xhci-dbgcap.h                     |  247 +++++
>> >  drivers/usb/host/xhci-dbgtty.c                     |  586 +++++++++++
>> >  drivers/usb/host/xhci-trace.h                      |   60 ++
>> >  drivers/usb/host/xhci.c                            |   10 +
>> >  drivers/usb/host/xhci.h                            |    1 +
>> >  9 files changed, 1959 insertions(+)
>> >  create mode 100644 Documentation/ABI/testing/sysfs-bus-pci-drivers-xh=
ci_hcd
>> >  create mode 100644 drivers/usb/host/xhci-dbgcap.c
>> >  create mode 100644 drivers/usb/host/xhci-dbgcap.h
>> >  create mode 100644 drivers/usb/host/xhci-dbgtty.c
>> >
>>=20
>> [snip]
>>=20
>> > +#define DBC_VENDOR_ID			0x1d6b	/* Linux Foundation 0x1d6b */
>> > +#define DBC_PRODUCT_ID			0x0004	/* device 0004 */
>> >
>>=20
>> The DbC (xHCI DeBug Capability) is an optional functionality in
>> some xHCI host controllers. It will present a super-speed debug
>> device through the debug port after it is enabled.
>>=20
>> The DbC register set defines an interface for system software
>> to specify the vendor id and product id of the debug device.
>> These two values will be presented by the debug device in its
>> device descriptor idVendor and idProduct fields.
>>=20
>> Microsoft Windows have a well established protocol for
>> debugging over DbC. And it assigns below values for its use.
>>=20
>> USB\VID_045E&PID_062D.DeviceDesc=3D"Microsoft USB Debug Target"
>>=20
>> I'm going to use 0x1d6b/0x0004 value pair for DbC use in
>> Linux. Do you approve me to do so?
>
> No.  Why can't you use the same ids as Windows?  This is implementing
> the same protocol, right?

the protocol running on top is 100% vendor specific. More than likely,
we would just run kgdb on top of this, right? We really don't support
microsoft's debug architecture.

=2D-=20
balbi

--=-=-=
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEElLzh7wn96CXwjh2IzL64meEamQYFAln64j8ACgkQzL64meEa
mQbP7g/+IAQDJ/7l+tjo9AAaZgTPf60/F3J7w8tzju61GeR9ArA0YzpvmINTzWWz
O5XSIH23nhNDWqIFcDFWulcL2UbcdA5FwS9yyzW2VEgaNXA876OwuUV7RZkCoPSW
pbZEeGvOquNfnLdR8jCHV5NIzUu+02qLgeHocMTB3/GCiLlSL3KcXSL6wkic0xuY
o+nLli1UVQx5n6FGZJEignQn34Nl3cEJncUBx7vR/qXmxGE6WELTrRqjonK8+TZW
R22kxbQs3ZPaa50rSJh6bYKMW5HvgL1JRgbewvm3eJaSJJeVhLZVN/hF1dwS2DfB
BUK81yiFFCYf7ReCIMGtTDqm5CKuM6OfN+YQr7tdbPk2JXBlpAtEXbTsUn2i7cf1
FynfHqOnXwwgQjYAElL0QvxvCq1yUrbZYldwSkpH1v5UHAYEHrIusRNhVbsnaVUV
/lTC7QXVrc6E1wywO+MQ8eSY6G93V505zCqVVyhP+mSKrFeqlCZAOsXG7atO82go
XI/yNsbpuepaxiEtX9EpLBlm6gouucbS6hzcgN4oPKgl+hrRNg9vWy8t3KmSZsYe
Pnw3UES4ErUv0Sv+YnRl8F4dhEjdxeFij5yfPGW877aKRwQBBS0ZsIXf0GliaGNq
CPRBcA1qo/anHBMbQ6UB2SeQVlOpRytm9sA5fyya6OXd6WcwHbM=
=yl+D
-----END PGP SIGNATURE-----
--=-=-=--