All of lore.kernel.org
 help / color / mirror / Atom feed
From: Vivien Didelot <vivien.didelot@savoirfairelinux.com>
To: Florian Fainelli <f.fainelli@gmail.com>, netdev@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, kernel@savoirfairelinux.com,
	"David S. Miller" <davem@davemloft.net>,
	Andrew Lunn <andrew@lunn.ch>
Subject: Re: [PATCH net-next] net: dsa: add CONFIG_NET_DSA_LEGACY
Date: Wed, 12 Apr 2017 10:22:34 -0400	[thread overview]
Message-ID: <871ssx1z9x.fsf@weeman.i-did-not-set--mail-host-address--so-tickle-me> (raw)
In-Reply-To: <edc488b1-8ea1-fc69-0700-68ffaf8f6742@gmail.com>

Hi Florian,

Florian Fainelli <f.fainelli@gmail.com> writes:

> On 04/11/2017 01:52 PM, Vivien Didelot wrote:
>> This patch moves as is the legacy DSA code from dsa.c to legacy.c,
>> except the few shared symbols which remain in dsa.c.
>> 
>> Compile legacy.o only if a new CONFIG_NET_DSA_LEGACY symbol is enabled,
>> which is true by default.
>> 
>> DSA drivers without legacy support don't need the probe function as well
>> as driver registration helpers anymore, so remove their definitions if
>> CONFIG_NET_DSA_LEGACY is disabled.
>> 
>> NET_DSA_MV88E6060 and NET_DSA_BCM_SF2 now depend on the legacy support.
>
> BCM_SF2 is not dependent on legacy support since it got converted to the
> new API in the past few months.

Oops, my bad. Fixing it.

> You may want to generate your patch with git format-patch -M to help
> detect renames/code movements.

I used --find-copies-harder -C for easier review but I can use -M.

Thanks,

        Vivien

  reply	other threads:[~2017-04-12 14:24 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-04-11 20:52 [PATCH net-next] net: dsa: add CONFIG_NET_DSA_LEGACY Vivien Didelot
2017-04-11 20:59 ` Florian Fainelli
2017-04-12 14:22   ` Vivien Didelot [this message]
2017-04-11 21:20 ` Andrew Lunn
2017-04-12 14:50   ` Vivien Didelot
  -- strict thread matches above, loose matches on Subject: below --
2016-07-20 22:26 Vivien Didelot
2016-07-21  0:35 ` Andrew Lunn
2016-07-21  2:15   ` Florian Fainelli
2016-07-21 14:46     ` Vivien Didelot
2016-07-21 14:52       ` Andrew Lunn
2016-07-21 14:44   ` Vivien Didelot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=871ssx1z9x.fsf@weeman.i-did-not-set--mail-host-address--so-tickle-me \
    --to=vivien.didelot@savoirfairelinux.com \
    --cc=andrew@lunn.ch \
    --cc=davem@davemloft.net \
    --cc=f.fainelli@gmail.com \
    --cc=kernel@savoirfairelinux.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.