From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965101AbcLVBYK (ORCPT ); Wed, 21 Dec 2016 20:24:10 -0500 Received: from anholt.net ([50.246.234.109]:58158 "EHLO anholt.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S938665AbcLVBYG (ORCPT ); Wed, 21 Dec 2016 20:24:06 -0500 From: Eric Anholt To: Stephen Boyd Cc: Florian Fainelli , Michael Turquette , Rob Herring , Mark Rutland , dri-devel@lists.freedesktop.org, Thierry Reding , linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Stephen Warren , Lee Jones , bcm-kernel-feedback-list@broadcom.com, linux-clk@vger.kernel.org Subject: Re: [PATCH 02/11] clk: bcm2835: Register the DSI0/DSI1 pixel clocks. In-Reply-To: <20161221231446.GA8288@codeaurora.org> References: <20161214194621.16499-1-eric@anholt.net> <20161214194621.16499-3-eric@anholt.net> <20161221231446.GA8288@codeaurora.org> User-Agent: Notmuch/0.22.2+1~gb0bcfaa (http://notmuchmail.org) Emacs/24.5.1 (x86_64-pc-linux-gnu) Date: Wed, 21 Dec 2016 17:23:18 -0800 Message-ID: <871sx069kp.fsf@eliezer.anholt.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Stephen Boyd writes: > On 12/14, Eric Anholt wrote: >>=20=20 >> /* the gates */ >>=20=20 >> @@ -1890,8 +1976,18 @@ static int bcm2835_clk_probe(struct platform_devi= ce *pdev) >> if (IS_ERR(cprman->regs)) >> return PTR_ERR(cprman->regs); >>=20=20 >> - cprman->osc_name =3D of_clk_get_parent_name(dev->of_node, 0); >> - if (!cprman->osc_name) >> + for (i =3D 0; i < ARRAY_SIZE(cprman_parent_names); i++) { >> + cprman->real_parent_names[i] =3D >> + of_clk_get_parent_name(dev->of_node, i); >> + } > > Can we use of_clk_parent_fill() here? Or do we need to support > holes in the parent array? If it's the latter please add a > comment so we don't mistakenly change this later. It looks like that will work fine. We'll only be missing parents from the end of the array. --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEE/JuuFDWp9/ZkuCBXtdYpNtH8nugFAlhbKwYACgkQtdYpNtH8 nujGORAAieBRc84uzJWcshq20Wy/Q77M6dVgqDhggs/J13l2Lx6LpgAo9VbwUPsk PWW7UeOvxp0nG0R8FZW4xFQcz5A9gR9PwG4h+o78fAh+57PQpS51uWZBxsFX6B7O 4J6Bo7OLD9+FMawWr6huLXoEL8c3w8Sno74DqvOlBo703QNRSgNqbIEZWRvJd8xy 2VnY+laB+HvBlRVCdlrNi/3ZpGhKuyVP0mVqD8+qdemV/iqJ85pw/G+5m6rS+0bG ilEJWOSlYjxPI1VWG08W+2D61y9CHQiiaWfhuySm1o7u30qeiTpEyVGpl55oln5U Pcu7lZNsLhdak7ZUqj1URkP3nzbpNhyOQKEMnBMYjsIOG/VuOZekKIVAWmfph3Ri jUDJYMOE5udOUWDaax86358UXbQIGg7HlJIitJPcJbPYxHyyBUDavYJVhHwNMEvs zZSbRyWUyxbXlzKv+gzze0bDyiG0L6XcSCk18n7bpzSS4fjouG0tqHRUFEoIeTag AQ546FIgNDE2Yk0IQxawE2HDRPBuo7WlN6Obo06km0p76aRczmL2Jtbx2XjE/VTt NPxkbNxaDK9qBUcfknqf+eWrc5WErPN1+DKjkJ5CNSA43nyZ1XvNQL/s5QwVgiAG ooPTs3GzfZoCEfuk17X2kXwt8Dxsbh27448qsbYVIIMyf+vEk1M= =rmEP -----END PGP SIGNATURE----- --=-=-=-- From mboxrd@z Thu Jan 1 00:00:00 1970 From: eric@anholt.net (Eric Anholt) Date: Wed, 21 Dec 2016 17:23:18 -0800 Subject: [PATCH 02/11] clk: bcm2835: Register the DSI0/DSI1 pixel clocks. In-Reply-To: <20161221231446.GA8288@codeaurora.org> References: <20161214194621.16499-1-eric@anholt.net> <20161214194621.16499-3-eric@anholt.net> <20161221231446.GA8288@codeaurora.org> Message-ID: <871sx069kp.fsf@eliezer.anholt.net> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Stephen Boyd writes: > On 12/14, Eric Anholt wrote: >> >> /* the gates */ >> >> @@ -1890,8 +1976,18 @@ static int bcm2835_clk_probe(struct platform_device *pdev) >> if (IS_ERR(cprman->regs)) >> return PTR_ERR(cprman->regs); >> >> - cprman->osc_name = of_clk_get_parent_name(dev->of_node, 0); >> - if (!cprman->osc_name) >> + for (i = 0; i < ARRAY_SIZE(cprman_parent_names); i++) { >> + cprman->real_parent_names[i] = >> + of_clk_get_parent_name(dev->of_node, i); >> + } > > Can we use of_clk_parent_fill() here? Or do we need to support > holes in the parent array? If it's the latter please add a > comment so we don't mistakenly change this later. It looks like that will work fine. We'll only be missing parents from the end of the array. -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 832 bytes Desc: not available URL: From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eric Anholt Subject: Re: [PATCH 02/11] clk: bcm2835: Register the DSI0/DSI1 pixel clocks. Date: Wed, 21 Dec 2016 17:23:18 -0800 Message-ID: <871sx069kp.fsf@eliezer.anholt.net> References: <20161214194621.16499-1-eric@anholt.net> <20161214194621.16499-3-eric@anholt.net> <20161221231446.GA8288@codeaurora.org> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1474869604==" Return-path: Received: from anholt.net (anholt.net [50.246.234.109]) by gabe.freedesktop.org (Postfix) with ESMTP id EE7E26E194 for ; Thu, 22 Dec 2016 01:23:21 +0000 (UTC) In-Reply-To: <20161221231446.GA8288@codeaurora.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Stephen Boyd Cc: Mark Rutland , Florian Fainelli , Stephen Warren , Michael Turquette , Lee Jones , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Rob Herring , bcm-kernel-feedback-list@broadcom.com, linux-rpi-kernel@lists.infradead.org, linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org List-Id: dri-devel@lists.freedesktop.org --===============1474869604== Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Stephen Boyd writes: > On 12/14, Eric Anholt wrote: >>=20=20 >> /* the gates */ >>=20=20 >> @@ -1890,8 +1976,18 @@ static int bcm2835_clk_probe(struct platform_devi= ce *pdev) >> if (IS_ERR(cprman->regs)) >> return PTR_ERR(cprman->regs); >>=20=20 >> - cprman->osc_name =3D of_clk_get_parent_name(dev->of_node, 0); >> - if (!cprman->osc_name) >> + for (i =3D 0; i < ARRAY_SIZE(cprman_parent_names); i++) { >> + cprman->real_parent_names[i] =3D >> + of_clk_get_parent_name(dev->of_node, i); >> + } > > Can we use of_clk_parent_fill() here? Or do we need to support > holes in the parent array? If it's the latter please add a > comment so we don't mistakenly change this later. It looks like that will work fine. We'll only be missing parents from the end of the array. --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEE/JuuFDWp9/ZkuCBXtdYpNtH8nugFAlhbKwYACgkQtdYpNtH8 nujGORAAieBRc84uzJWcshq20Wy/Q77M6dVgqDhggs/J13l2Lx6LpgAo9VbwUPsk PWW7UeOvxp0nG0R8FZW4xFQcz5A9gR9PwG4h+o78fAh+57PQpS51uWZBxsFX6B7O 4J6Bo7OLD9+FMawWr6huLXoEL8c3w8Sno74DqvOlBo703QNRSgNqbIEZWRvJd8xy 2VnY+laB+HvBlRVCdlrNi/3ZpGhKuyVP0mVqD8+qdemV/iqJ85pw/G+5m6rS+0bG ilEJWOSlYjxPI1VWG08W+2D61y9CHQiiaWfhuySm1o7u30qeiTpEyVGpl55oln5U Pcu7lZNsLhdak7ZUqj1URkP3nzbpNhyOQKEMnBMYjsIOG/VuOZekKIVAWmfph3Ri jUDJYMOE5udOUWDaax86358UXbQIGg7HlJIitJPcJbPYxHyyBUDavYJVhHwNMEvs zZSbRyWUyxbXlzKv+gzze0bDyiG0L6XcSCk18n7bpzSS4fjouG0tqHRUFEoIeTag AQ546FIgNDE2Yk0IQxawE2HDRPBuo7WlN6Obo06km0p76aRczmL2Jtbx2XjE/VTt NPxkbNxaDK9qBUcfknqf+eWrc5WErPN1+DKjkJ5CNSA43nyZ1XvNQL/s5QwVgiAG ooPTs3GzfZoCEfuk17X2kXwt8Dxsbh27448qsbYVIIMyf+vEk1M= =rmEP -----END PGP SIGNATURE----- --=-=-=-- --===============1474869604== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg== --===============1474869604==--