From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:33996)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <armbru@redhat.com>) id 1bIysP-0002Rh-Ax
	for qemu-devel@nongnu.org; Fri, 01 Jul 2016 09:53:02 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <armbru@redhat.com>) id 1bIysL-0000Zu-6o
	for qemu-devel@nongnu.org; Fri, 01 Jul 2016 09:53:00 -0400
Received: from mx1.redhat.com ([209.132.183.28]:55389)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <armbru@redhat.com>) id 1bIysL-0000ZT-1H
	for qemu-devel@nongnu.org; Fri, 01 Jul 2016 09:52:57 -0400
From: Markus Armbruster <armbru@redhat.com>
References: <1466777957-5126-3-git-send-email-armbru@redhat.com>
	<1467268211-11451-1-git-send-email-armbru@redhat.com>
	<874m8baqoh.fsf@oc4731375738.ibm.com>
	<874m8aan6o.fsf@dusky.pond.sub.org>
Date: Fri, 01 Jul 2016 15:52:53 +0200
In-Reply-To: <874m8aan6o.fsf@dusky.pond.sub.org> (Markus Armbruster's message
	of "Thu, 30 Jun 2016 14:14:23 +0200")
Message-ID: <871t3dtqh6.fsf@dusky.pond.sub.org>
MIME-Version: 1.0
Content-Type: text/plain
Subject: Re: [Qemu-devel] [PATCH RFC] fixup! tests: New make target
 check-source
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Sascha Silbe <silbe@linux.vnet.ibm.com>
Cc: qemu-devel@nongnu.org, peter.maydell@linaro.org, pbonzini@redhat.com

Markus Armbruster <armbru@redhat.com> writes:

> Sascha Silbe <silbe@linux.vnet.ibm.com> writes:
>
>> Dear Markus,
>>
>> Markus Armbruster <armbru@redhat.com> writes:
>>
>>> ---
>>>  tests/header-test-template.c | 16 ++++++++++++++++
>> [...]
>>
>> Thanks, that helped, I get a bit further now.
>>
>> Is "make header-check" supposed to work on a host that doesn't have all
>> optional dependencies installed? It fails for me because some OpenGL
>> related header is missing. configure correctly detected that and didn't
>> enable OpenGL support:
>>
>> $ make check-headers
>>   CC    tests/headers/include/ui/shader.o
>> In file included from tests/headers/include/ui/shader.c:14:0:
>> ./include/ui/shader.h:6:22: fatal error: epoxy/gl.h: No such file or directory
>>  #include <epoxy/gl.h>
>>                       ^
>> compilation terminated.
>> make: *** [tests/headers/include/ui/shader.o] Error 1
>> rm tests/headers/include/ui/shader.c
>> $ grep OPENGL config-host.*
>
> Hmm, this demonstrates some of our headers may only be included when
> certain CONFIG_* are defined.
>
> Actually, I ran into a related case myself: headers that don't compile
> with CONFIG_WIN32.
>
> We can either add suitable ifdeffery to make our headers work always, or
> mark headers so the test skips them when their requirements aren't met,
> similarly to how this patch skips certain headers when CONFIG_WIN32 is
> defined.
>
> Regardless, we need to find the problemtatic headers.  Perhaps you can
> find a few more with "make -k check-source".

I think I tracked them down.  Not too bad, just a dozen or so.  Now I
have to make up my mind whether I prefer to document their configuration
requirements with comments or with ifdefs.