From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:45261) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bHQ7d-0003tr-WF for qemu-devel@nongnu.org; Mon, 27 Jun 2016 02:34:21 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bHQ7Z-0001JH-Qg for qemu-devel@nongnu.org; Mon, 27 Jun 2016 02:34:16 -0400 Received: from mx1.redhat.com ([209.132.183.28]:43122) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bHQ7Z-0001J6-L8 for qemu-devel@nongnu.org; Mon, 27 Jun 2016 02:34:13 -0400 From: Markus Armbruster References: <1466777957-5126-1-git-send-email-armbru@redhat.com> <1466777957-5126-2-git-send-email-armbru@redhat.com> <576D49AA.30906@redhat.com> Date: Mon, 27 Jun 2016 08:34:10 +0200 In-Reply-To: <576D49AA.30906@redhat.com> (Eric Blake's message of "Fri, 24 Jun 2016 08:54:34 -0600") Message-ID: <871t3jcf8d.fsf@dusky.pond.sub.org> MIME-Version: 1.0 Content-Type: text/plain Subject: Re: [Qemu-devel] [PATCH RFC v2 1/5] Use #include "..." exactly for our own headers List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake Cc: qemu-devel@nongnu.org, peter.maydell@linaro.org, pbonzini@redhat.com Eric Blake writes: > On 06/24/2016 08:19 AM, Markus Armbruster wrote: >> Signed-off-by: Markus Armbruster >> Reviewed-by: Peter Maydell > > Worth mentioning how you found the culprits in the commit message, so > that someone could repeat the task when backporting this patch or > dealing with future cruft that inevitably creeps back in without an > automated checkin validation tool? > > >> +++ b/crypto/pbkdf-nettle.c >> @@ -19,9 +19,9 @@ >> */ >> >> #include "qemu/osdep.h" >> +#include >> #include "qapi/error.h" >> #include "crypto/pbkdf.h" >> -#include "nettle/pbkdf2.h" > > You're not just converting <> to "" (when the header is internal) or "" > to <> (when the header is 3rd-party), but also rearranging things to put > <> before "" (except for osdep.h which must be first). I like that > paradigm, but again, might be worth a mention in the commit message as > being intentional. Our ordering of #include directives looks and smells like an open garbage dump in August. Cleaning this up should become feasible once we manage to make our headers self-contained. If such a cleanup is wanted.