From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751480AbcFVUEI (ORCPT ); Wed, 22 Jun 2016 16:04:08 -0400 Received: from mail.savoirfairelinux.com ([208.88.110.44]:48248 "EHLO mail.savoirfairelinux.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750787AbcFVUEG (ORCPT ); Wed, 22 Jun 2016 16:04:06 -0400 From: Vivien Didelot To: Heiner Kallweit , Jiri Kosina Cc: Benjamin Tissoires , linux-input@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 4/4] HID: remove ThingM blink(1) driver In-Reply-To: References: <87twglqlfq.fsf@ketchup.mtl.sfl> User-Agent: Notmuch/0.22 (http://notmuchmail.org) Emacs/24.5.1 (x86_64-unknown-linux-gnu) Date: Wed, 22 Jun 2016 16:03:59 -0400 Message-ID: <871t3pkn2o.fsf@ketchup.mtl.sfl> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Heiner, Heiner Kallweit writes: >>> Also adding Vivien Didelot to CC, as the author of the original driver. >>> Vivien, the full set can be found in linux-input archives ( >>> http://marc.info/?l=linux-input&r=1&b=201606&w=2 ) >> >> Thanks a lot for the follow-up Jiri. >> >> If you guys decide to remove hid-thingm.c, you need to update the >> MAINTAINERS entry, checkpatch.pl should have warned about that. >> > Right, thanks for the hint. > >> I can hardly test the patchset now. Heiner, can you confirm me that with >> your patchset, we will still see 3 led_classdev in sysfs for the >> blink(1) mk1 (which has one RGB chip) and 6 for mk2 (which has 2 chips)? >> > Yes, this will still be the case. Looks good to me then! Please Cc' me in the v2 so I can hack the change. Thanks, Vivien