All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Bjørn Mork" <bjorn@mork.no>
To: Ingo Molnar <mingo@kernel.org>
Cc: "Steven Rostedt" <rostedt@goodmis.org>,
	"Linus Torvalds" <torvalds@linux-foundation.org>,
	"Peter Zijlstra" <peterz@infradead.org>,
	LKML <linux-kernel@vger.kernel.org>,
	"Borislav Petkov" <bp@alien8.de>,
	"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
	"Andrew Morton" <akpm@linux-foundation.org>,
	"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Subject: Re: [PATCH v2] printk: Add kernel parameter to disable writes to /dev/kmsg
Date: Tue, 26 Apr 2016 12:43:49 +0200	[thread overview]
Message-ID: <871t5svee2.fsf@nemi.mork.no> (raw)
In-Reply-To: <20160426053647.GA21680@gmail.com> (Ingo Molnar's message of "Tue, 26 Apr 2016 07:36:47 +0200")

Ingo Molnar <mingo@kernel.org> writes:

>  static int parse_proc_cmdline_item(const char *key, const char *value) {
>
>         /*
>          * The systemd.log_xyz= settings are parsed by all tools, and
>          * so is "debug".
>          *
>          * However, "quiet" is only parsed by PID 1, and only turns of
>          * status output to /dev/console, but does not alter the log
>          * level.
>          */
>
>         if (streq(key, "debug") && !value)
>                 log_set_max_level(LOG_DEBUG);
>
>         else if (streq(key, "systemd.log_target") && value) {
>
> Why systemd does this fully knowing that other software (such as the kernel) 
> already uses 'debug', while systemd already has the 'system.*' parameter namespace 
> is left up to the reader...

A couple of links to save that reader from making futile comments:
https://lkml.org/lkml/2014/4/2/415
https://bugs.freedesktop.org/show_bug.cgi?id=76935


Bjørn

  reply	other threads:[~2016-04-26 10:47 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-25 18:56 [PATCH v2] printk: Add kernel parameter to disable writes to /dev/kmsg Steven Rostedt
2016-04-25 19:06 ` Peter Zijlstra
2016-04-25 19:18   ` Greg Kroah-Hartman
2016-04-25 19:24     ` Peter Zijlstra
2016-04-25 19:44       ` Andrew Morton
2016-04-25 19:54       ` Greg Kroah-Hartman
2016-04-25 20:00         ` Steven Rostedt
2016-04-25 20:23           ` Linus Torvalds
2016-04-25 20:34             ` Steven Rostedt
2016-04-25 20:45               ` Linus Torvalds
2016-04-25 21:23                 ` Steven Rostedt
2016-04-26 11:01             ` Borislav Petkov
2016-04-26 11:12         ` Peter Zijlstra
2016-04-25 19:30     ` Steven Rostedt
2016-04-25 19:28   ` Linus Torvalds
2016-04-25 19:34     ` Linus Torvalds
2016-04-25 19:35     ` Steven Rostedt
2016-04-25 19:44     ` Steven Rostedt
2016-04-26  5:36       ` Ingo Molnar
2016-04-26 10:43         ` Bjørn Mork [this message]
2016-04-26 11:09           ` Peter Zijlstra
2016-04-25 19:46 ` Andi Kleen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=871t5svee2.fsf@nemi.mork.no \
    --to=bjorn@mork.no \
    --cc=akpm@linux-foundation.org \
    --cc=bp@alien8.de \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=peterz@infradead.org \
    --cc=rostedt@goodmis.org \
    --cc=torvalds@linux-foundation.org \
    --cc=u.kleine-koenig@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.