Re: [Qemu-devel] [PATCH v4 02/11] tcg: light re-factor and pass down TranslationBlock

From: "Alex Bennée" <alex.bennee@linaro.org>
To: Aurelien Jarno <aurelien@aurel32.net>
Cc: qemu-trivial@nongnu.org, pbonzini@redhat.com,
	crosthwaitepeter@gmail.com, qemu-devel@nongnu.org,
	rth@twiddle.net
Subject: Re: [Qemu-devel] [PATCH v4 02/11] tcg: light re-factor and pass down TranslationBlock
Date: Wed, 03 Feb 2016 18:38:24 +0000	[thread overview]
Message-ID: <871t8tprkv.fsf@linaro.org> (raw)
In-Reply-To: <20150804123628.GA6780@aurel32.net>

Aurelien Jarno <aurelien@aurel32.net> writes:

> On 2015-08-03 10:14, Alex Bennée wrote:
>> My later debugging patches need access to the origin PC. At the same
>> time we have a slightly clumsy pass-by-reference access to the size of
>> the translated block again for debugging purposes.
<snip>
>>      void *tc_ptr;    /* pointer to the translated code */
>> +    uint32_t tc_size;/* size of translated code */
>>      /* next matching tb for physical address. */
>>      struct TranslationBlock *phys_hash_next;
>>      /* first and second physical page containing code. The lower bit
>
> What's the impact on the memory here? Given the alignement, we add 8
> bytes to the structure on a 64-bit host.
<snip>

Well this has all got a lot simpler thanks to Richard's clean-up work
since this was last posted.

--
Alex Bennée