From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:43885)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <armbru@redhat.com>) id 1ZmGDi-0005JL-Nw
	for qemu-devel@nongnu.org; Wed, 14 Oct 2015 03:11:31 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <armbru@redhat.com>) id 1ZmGDd-0002kC-OD
	for qemu-devel@nongnu.org; Wed, 14 Oct 2015 03:11:30 -0400
Received: from mx1.redhat.com ([209.132.183.28]:54991)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <armbru@redhat.com>) id 1ZmGDd-0002jx-Iq
	for qemu-devel@nongnu.org; Wed, 14 Oct 2015 03:11:25 -0400
From: Markus Armbruster <armbru@redhat.com>
References: <1444710158-8723-1-git-send-email-eblake@redhat.com>
	<1444710158-8723-16-git-send-email-eblake@redhat.com>
	<87zizm6c67.fsf@blackfin.pond.sub.org> <561D24CA.7030804@redhat.com>
	<87mvvmvghf.fsf@blackfin.pond.sub.org> <561D42C3.1050207@redhat.com>
	<87wpuqmxex.fsf@blackfin.pond.sub.org> <561D66D3.5090500@redhat.com>
	<561D678A.5090600@redhat.com>
Date: Wed, 14 Oct 2015 09:11:22 +0200
In-Reply-To: <561D678A.5090600@redhat.com> (Eric Blake's message of "Tue, 13
	Oct 2015 14:20:26 -0600")
Message-ID: <871tcxapr9.fsf@blackfin.pond.sub.org>
MIME-Version: 1.0
Content-Type: text/plain
Subject: Re: [Qemu-devel] [PATCH v8 15/18] qapi: Move duplicate member
	checks to schema check()
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Eric Blake <eblake@redhat.com>
Cc: qemu-devel@nongnu.org, Michael Roth <mdroth@linux.vnet.ibm.com>

Eric Blake <eblake@redhat.com> writes:

> On 10/13/2015 02:17 PM, Eric Blake wrote:
>
>>>>> I can take PATCH 01-09,12 into my tree right away, with PATCH 07's two
>>>>> redundant is_implicit() methods dropped, and PATCH 12's comment touched
>>>>> up.
>>>>
>>>> Okay.
>>>
>>> Done & pushed to http://repo.or.cz/qemu/armbru.git branch qapi-next.
>> 
>> I didn't see any mentioned changes on patch 7, at least not in commit
>> 4ad5066.  Last paragraph of the commit message would also need a
>> massage, if you do want to squash it in:

I messed it up, fixing :)

> And of course, if you move the hunks out of 7, then they DO need to be
> added back into 12, since it is 12 that provides non-None info on
> implicit types (not seen in commit 20bfea1).

Yup.