From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:56707)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <armbru@redhat.com>) id 1ZMYCf-0000CE-J4
	for qemu-devel@nongnu.org; Tue, 04 Aug 2015 05:08:10 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <armbru@redhat.com>) id 1ZMYCc-0007uw-7X
	for qemu-devel@nongnu.org; Tue, 04 Aug 2015 05:08:09 -0400
Received: from mx1.redhat.com ([209.132.183.28]:60003)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <armbru@redhat.com>) id 1ZMYCc-0007uc-2Z
	for qemu-devel@nongnu.org; Tue, 04 Aug 2015 05:08:06 -0400
From: Markus Armbruster <armbru@redhat.com>
References: <1435782155-31412-1-git-send-email-armbru@redhat.com>
	<1435782155-31412-20-git-send-email-armbru@redhat.com>
	<55AE84BA.3070807@redhat.com> <874mkqt453.fsf@blackfin.pond.sub.org>
Date: Tue, 04 Aug 2015 11:08:02 +0200
In-Reply-To: <874mkqt453.fsf@blackfin.pond.sub.org> (Markus Armbruster's
	message of "Mon, 27 Jul 2015 10:07:36 +0200")
Message-ID: <871tfje80d.fsf@blackfin.pond.sub.org>
MIME-Version: 1.0
Content-Type: text/plain
Subject: Re: [Qemu-devel] [PATCH RFC v2 19/47] qapi: Generated code cleanup
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Eric Blake <eblake@redhat.com>
Cc: kwolf@redhat.com, berto@igalia.com, qemu-devel@nongnu.org, mdroth@linux.vnet.ibm.com

Markus Armbruster <armbru@redhat.com> writes:

> Eric Blake <eblake@redhat.com> writes:
>
>> On 07/01/2015 02:22 PM, Markus Armbruster wrote:
[...]
>>> @@ -105,7 +103,8 @@ struct %(name)s
>>>  
>>>  def generate_enum_lookup(name, values):
>>>      ret = mcgen('''
>>> -const char * const %(name)s_lookup[] = {
>>> +
>>> +const char *const %(name)s_lookup[] = {
>>
>> [2] generated diffs like this:
>>
>> qapi-types.c:
>> -const char * const OnOffAuto_lookup[] = {
>> +const char *const OnOffAuto_lookup[] = {
>>
>> Hmm - we already failed to update docs/qapi-code-gen.txt in the past; we
>> added a const in commit 2e4450ff that is missing from the documentation.
>
> Minor review fail.  Not the first time.

I take that back, it's actually not visible in qapi-code-gen.txt.

[...]