From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:34773) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YcVNE-0004kR-Ja for qemu-devel@nongnu.org; Mon, 30 Mar 2015 04:48:45 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YcVNB-0007Xc-Ec for qemu-devel@nongnu.org; Mon, 30 Mar 2015 04:48:44 -0400 From: Markus Armbruster References: <1425615506-1829-1-git-send-email-david@gibson.dropbear.id.au> <20150310151912-mutt-send-email-mst@redhat.com> <20150310105622.55505a1b@redhat.com> <20150330024123.GG9908@voom.fritz.box> Date: Mon, 30 Mar 2015 10:48:31 +0200 In-Reply-To: <20150330024123.GG9908@voom.fritz.box> (David Gibson's message of "Mon, 30 Mar 2015 13:41:23 +1100") Message-ID: <871tk6uazk.fsf@blackfin.pond.sub.org> MIME-Version: 1.0 Content-Type: text/plain Subject: Re: [Qemu-devel] [PATCH 0/6] Clean up ISA dependencies so we make ISA optional to build List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: David Gibson Cc: "Michael S. Tsirkin" , agraf@suse.de, qemu-devel@nongnu.org, blauwirbel@gmail.com, andreas.faerber@web.de, qemu-ppc@nongnu.org, michael@walle.cc, Luiz Capitulino David Gibson writes: > On Tue, Mar 10, 2015 at 10:56:22AM -0400, Luiz Capitulino wrote: >> On Tue, 10 Mar 2015 15:20:29 +0100 >> "Michael S. Tsirkin" wrote: >> >> > On Fri, Mar 06, 2015 at 03:18:20PM +1100, David Gibson wrote: >> > > At present, ISA bus support is always included in the build for all >> > > targets. However these days there are a number of targets that have >> > > never had ISA, and even more where many of the individual machines >> > > don't have ISA. >> > > >> > > Unfortunately there are some awkward dependencies in the core code on >> > > ISA, although b19c1c0 "isa: remove isa_mem_base variable" did already >> > > remove one. >> > > >> > > This series engages in some yak shaving to make the necessary >> > > dependency cleanups, then make inclusion of ISA support optional. >> > >> > For PC/PCI changes >> > Acked-by: Michael S. Tsirkin >> > >> > >> > > >> > > Given the date, this is obviously aimed at qemu 2.4, not 2.3. >> > >> > Looks like the date for 2.3 is unclear, so it might be >> > ok to merge. >> > >> > Who's taking this? Luiz? most changes are monitor-related. >> >> I can take them, but the most important question for me is >> who's reviewing them? I could do it, but not right now. > > Any further thoughts on this? I don't know who would be suitable for > review, beyond those I've already CCed. You got a full R-by from Alex and a PC/PCI one from Michael. Should be enough. I just had a look, too, and got questions on PATCH 1's completeness, and the wisdom of extending the "info pic" / "info irq" crap to more targets. Nothing seriously wrong, really.