From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750976AbbBRFQh (ORCPT ); Wed, 18 Feb 2015 00:16:37 -0500 Received: from ozlabs.org ([103.22.144.67]:40884 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750708AbbBRFQf (ORCPT ); Wed, 18 Feb 2015 00:16:35 -0500 From: Rusty Russell To: Ben Hutchings Cc: linux-kernel@vger.kernel.org, stable@vger.kernel.org, akpm@linux-foundation.org, "Michael S. Tsirkin" , Wanlong Gao Subject: Re: [PATCH 3.2 082/152] virtio: use dev_to_virtio wrapper in virtio In-Reply-To: <1424220942.23608.76.camel@decadent.org.uk> References: <873865t8fu.fsf@rustcorp.com.au> <1424220942.23608.76.camel@decadent.org.uk> User-Agent: Notmuch/0.17 (http://notmuchmail.org) Emacs/24.3.1 (x86_64-pc-linux-gnu) Date: Wed, 18 Feb 2015 15:14:35 +1030 Message-ID: <871tlnu8uk.fsf@rustcorp.com.au> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Ben Hutchings writes: > On Tue, 2015-02-17 at 15:56 +1030, Rusty Russell wrote: >> Ben Hutchings writes: >> > 3.2.67-rc1 review patch. If anyone has any objections, please let me know. >> >> Ben, what are your criteria for putting patches into 3.2? >> >> This patch is a trivial cleanup. It doesn't fix anything, but it does >> add some churn. > > It fixes the definition of dev_to_virtio(). Argh, sorry I should have caught that. The commit message didn't actually mention that it fixed anything (and I took it). :( >> I can see that 083 and 084 follow this, but 083 needed a backport >> anyway. > > Patch 083 "virtio_pci: defer kfree until release callback" uses > dev_to_virtio(_d) which would expand to a syntax error without this. > >> And it wasn't an issue we saw in Real Life (device removal >> is rare), so it wasn't CC: stable. >> >> 084 was a comment addition. Backporting that just seems weird. > > Nevertheless, it had 'cc: stable' and is obviously harmless. Ah I see, you stripped the cc:stable in your version. The original did indeed have CC:stable, which is MST's perogative... Thanks for the explanation, Rusty.