[MPTCP] Re: [MPTCP][PATCH v2 mptcp-next 4/4] mptcp: trigger the RM_ADDR signal

[Paolo Abeni <pabeni at redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 1310 bytes --]

On Wed, 2020-07-29 at 17:33 +0800, Geliang Tang wrote:
> I have sent out REMOVE_ADDR patchset v3 to you.
> 
> On Wed, Jul 22, 2020 at 01:34:25PM +0200, Paolo Abeni wrote:
> > On Wed, 2020-07-22 at 12:41 +0200, Paolo Abeni wrote:
> > > > +void mptcp_pm_nl_rm_addr_received(struct mptcp_sock *msk)
> > > > +{
> > > > + struct mptcp_subflow_context *subflow, *tmp;
> > > > +
> > > > + pr_debug("remote_id %d", msk->pm.rm_id);
> > > > +
> > > > + msk->pm.add_addr_accepted--;
> > > > + msk->pm.subflows--;
> > > > + WRITE_ONCE(msk->pm.accept_addr, true);
> > > > +
> > > > + list_for_each_entry_safe(subflow, tmp, &msk->conn_list, node) {
> > > > +         struct sock *tcp_sk = mptcp_subflow_tcp_sock(subflow);
> > > > +
> > > > +         if (msk->pm.rm_id == subflow->remote_id) {
> > > > +                 mptcp_subflow_shutdown(tcp_sk, 1, 1, msk->write_seq);
> > > 
> > > the 2nd argument for mptcp_subflow_shutdown() should be something alike
> > > 'RCV_SHUTDOWN|SEND_SHUTDOWN' - we are closing the subflow in both
> > > direction - and the third argument '0' - the msk will remain
> > > open/established.
> > > 
> 
> I have updated these arguments in patchset v3.

Thanks! I'll try to review before tomorrow's mtg - sorry for the
latency, I'm lagging behind other tasks.

/P